decnet: Remove unnecessary check for dev->name
Subsystems (2)
PATCH 1/1 decnet: Remove unnecessary check for dev->name
Clang warns that the address of a pointer will always evaluated as true in a boolean context.
net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will always evaluate to 'true' [-Wpointer-bool-conversion]
dev->name ? dev->name : "???",
~~~~~^~~~ ~1 warning generated.
Signed-off-by Nathan Chancellor <[email protected]>
--- net/decnet/dn_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/decnet/dn_dev.c +1 -1
@@ -1363,7 +1363,7 @@ static int dn_dev_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "%-8s %1s %04u %04u %04lu %04lu" " %04hu %03d %02x %-10s %-7s %-7s\n", - dev->name ? dev->name : "???", + dev->name, dn_type2asc(dn_db->parms.mode), 0, 0, dn_db->t3, dn_db->parms.t3,
Signature · 1 line
2.19.0
Quoted 11 lines · On Fri, 21 Sep 2018 12:30:34 -0700 Nathan Chancellor…
Clang warns that the address of a pointer will always evaluated as true in a boolean context.
net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will always evaluate to 'true' [-Wpointer-bool-conversion]dev->name ? dev->name : "???", ~~~~~^~~~ ~1 warning generated.
Makes sense name in net_device is an array.
Reviewed-by Stephen Hemminger <[email protected]>