i40e: Remove unnecessary print statement
Subsystems (3)
PATCH 1/1 i40e: Remove unnecessary print statement
Clang warns that the address of a pointer will always evaluated as true in a boolean context.
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address of array 'vsi->active_vlans' will always evaluate to 'true' [-Wpointer-bool-conversion]
vsi->active_vlans ? "<valid>" : "<null>");
~~~~~^~~~~~~~~~~~ ~
./include/linux/device.h:1431:33: note: expanded from macro 'dev_info'
_dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~1 warning generated.
Given that the statement shows that active_vlans is always valid, just remove the statement since it's not giving any useful information.
--- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +0 -2
@@ -132,8 +132,6 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)dev_info (&pf->pdev->dev," vlan_features = 0x%08lx\n" , (unsigned long int )nd->vlan_features); } -dev_info (&pf->pdev->dev," active_vlans is %s\n" , - vsi->active_vlans ?"<valid>" :"<null>" );dev_info (&pf->pdev->dev," flags = 0x%08lx, netdev_registered = %i, current_netdev_flags = 0x%04x\n" , vsi->flags, vsi->netdev_registered, vsi->current_netdev_flags);
Signature · 1 line
2.19.0
Bowers
PATCH 1/1 i40e: Remove unnecessary print statement
Quoted 25 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Nathan Chancellor
Sent: Friday, September 21, 2018 12:39 PM
To: Kirsher, Jeffrey T <[email protected]>; David S. Miller <[email protected]>
Cc: netdev at vger.kernel.org; Nathan Chancellor <[email protected]>; intel-wired-lan at lists.osuosl.org; linux- kernel at vger.kernel.org
Subject: [Intel-wired-lan] [PATCH] i40e: Remove unnecessary print statementClang warns that the address of a pointer will always evaluated as true in a boolean context.
drivers/net/ethernet/intel/i40e/i40e_debugfs.c:136:9: warning: address of array 'vsi->active_vlans' will always evaluate to 'true' [-Wpointer-bool-conversion]vsi->active_vlans ? "<valid>" : "<null>"); ~~~~~^~~~~~~~~~~~ ~ ./include/linux/device.h:1431:33: note: expanded from macro 'dev_info' _dev_info(dev, dev_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~~~1 warning generated.
Quoted 8 lines
Given that the statement shows that
active_vlansis always valid, just remove the statement since it's not giving any useful information.Signed-off-by Nathan Chancellor <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 -- 1 file changed, 2 deletions(-)