Skip to contentSkip to conversation

mac80211: allocate TXQs for active monitor interfaces

PATCH New Felix Fietkau 1 participant 1 message Sep 22, 2018 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mac80211: allocate TXQs for active monitor interfaces

Monitor mode interfaces with the active flag are passed down to the driver. Drivers using TXQ expect that all interfaces have allocated TXQs before they get added.

Fixes 79af1f866193d ("mac80211: avoid allocating TXQs that won't be used")
---
 net/mac80211/iface.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/mac80211/iface.c +2 -1
index 5e6cf2cee965..5836ddeac9e3 100644
@@ -1756,7 +1756,8 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
 
 		if (local->ops->wake_tx_queue &&
 		    type != NL80211_IFTYPE_AP_VLAN &&
-		    type != NL80211_IFTYPE_MONITOR)
+		    (type != NL80211_IFTYPE_MONITOR ||
+		     (params->flags & MONITOR_FLAG_ACTIVE)))
 			txq_size += sizeof(struct txq_info) +
 				    local->hw.txq_data_size;
 
Signature · 1 line
2.17.0