rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface
PATCH v2 1/1 rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface
Clang warns when one enumerated type is implicitly converted to another.
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34:
warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]
wifionly_cfg->chip_interface = BTC_INTF_PCI;
~ ^~~~~~~~~~~~drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34:
warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]
wifionly_cfg->chip_interface = BTC_INTF_USB;
~ ^~~~~~~~~~~~drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34:
warning: implicit conversion from enumeration type 'enum btc_chip_interface' to different enumeration type 'enum wifionly_chip_interface' [-Wenum-conversion]
wifionly_cfg->chip_interface = BTC_INTF_UNKNOWN;
~ ^~~~~~~~~~~~~~~~3 warnings generated.
Use the values from the correct enumerated type, wifionly_chip_interface.
BTC_INTF_UNKNOWN = WIFIONLY_INTF_UNKNOWN = 0 BTC_INTF_PCI = WIFIONLY_INTF_PCI = 1 BTC_INTF_USB = WIFIONLY_INTF_USB = 2
---
v1 -> v2:
* Fix enum values in commit message (previously all 0)
.../net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c +3 -3
@@ -1324,13 +1324,13 @@ bool exhalbtc_initlize_variables_wifi_only(struct rtl_priv *rtlpriv)switch (rtlpriv->rtlhal.interface) {case INTF_PCI : - wifionly_cfg->chip_interface =BTC_INTF_PCI ; + wifionly_cfg->chip_interface =WIFIONLY_INTF_PCI ;break ;case INTF_USB : - wifionly_cfg->chip_interface =BTC_INTF_USB ; + wifionly_cfg->chip_interface =WIFIONLY_INTF_USB ;break ;default : - wifionly_cfg->chip_interface =BTC_INTF_UNKNOWN ; + wifionly_cfg->chip_interface =WIFIONLY_INTF_UNKNOWN ;break ; }
Signature · 1 line
2.19.0
Quoted 22 lines · Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another.
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface=BTC_INTF_PCI; ~ ^~~~~~~~~~~~drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface=BTC_INTF_USB; ~ ^~~~~~~~~~~~drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface=BTC_INTF_UNKNOWN; ~ ^~~~~~~~~~~~~~~~ 3 warnings generated.
Quoted 8 lines
Use the values from the correct enumerated type,
wifionly_chip_interface.
BTC_INTF_UNKNOWN=WIFIONLY_INTF_UNKNOWN= 0BTC_INTF_PCI=WIFIONLY_INTF_PCI= 1BTC_INTF_USB=WIFIONLY_INTF_USB= 2
Quoted 24 lines · Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another.
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface = BTC_INTF_PCI; ~ ^~~~~~~~~~~~
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface = BTC_INTF_USB; ~ ^~~~~~~~~~~~
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34:
warning: implicit conversion from enumeration type 'enumbtc_chip_interface' to different enumeration type 'enumwifionly_chip_interface' [-Wenum-conversion]wifionly_cfg->chip_interface = BTC_INTF_UNKNOWN; ~ ^~~~~~~~~~~~~~~~3 warnings generated.
Use the values from the correct enumerated type,
wifionly_chip_interface.
Quoted 7 lines
BTC_INTF_UNKNOWN=WIFIONLY_INTF_UNKNOWN= 0BTC_INTF_PCI=WIFIONLY_INTF_PCI= 1BTC_INTF_USB=WIFIONLY_INTF_USB= 2
Patch applied to wireless-drivers-next.git, thanks.
31138a827d1b rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface
Signature · 3 lines
https://patchwork.kernel.org/patch/10611603/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches