STM32: Fixes for 4.19 cycle
Subsystems (2)
cover STM32: Fixes for 4.19 cycle
Hi Arnd, olof and Kevin
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside stm32mp157c.dts file. Can you please add them as fixe for 4.19 ?
Thanks in advance
Alex
Alexandre Torgue (1):
ARM: dts: stm32: update HASH1 dmas property on stm32mp157c
Amelie Delaunay (1):
ARM: dts: stm32: update SPI6 dmas property on stm32mp157c
arch/arm/boot/dts/stm32mp157c.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.7.4
PATCH 1/2 ARM: dts: stm32: update SPI6 dmas property on stm32mp157c
From: Amelie Delaunay <[email protected]>
Remove unused parameter from SPI6 dmas property on stm32mp157c SoC.
arch/arm/boot/dts/stm32mp157c.dtsi +2 -2
@@ -1078,8 +1078,8 @@ interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; clocks = <&rcc SPI6_K>; resets = <&rcc SPI6_R>; - dmas = <&mdma1 34 0x0 0x40008 0x0 0x0 0>, - <&mdma1 35 0x0 0x40002 0x0 0x0 0>; + dmas = <&mdma1 34 0x0 0x40008 0x0 0x0>, + <&mdma1 35 0x0 0x40002 0x0 0x0>; dma-names = "rx", "tx"; status = "disabled"; };
Signature · 1 line
2.7.4
PATCH 2/2 ARM: dts: stm32: update HASH1 dmas property on stm32mp157c
In reply to Alexandre TorgueRemove unused parameter from HASH1 dmas property on stm32mp157c SoC.
arch/arm/boot/dts/stm32mp157c.dtsi +1 -1
@@ -923,7 +923,7 @@ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; clocks = <&rcc HASH1>; resets = <&rcc HASH1_R>; - dmas = <&mdma1 31 0x10 0x1000A02 0x0 0x0 0x0>; + dmas = <&mdma1 31 0x10 0x1000A02 0x0 0x0>; dma-names = "in"; dma-maxburst = <2>; status = "disabled";
Signature · 1 line
2.7.4
cover STM32: Fixes for 4.19 cycle
In reply to Alexandre TorgueHi Alexandre,
Quoted 4 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?
The patches only mention removing unused property contents, not what the bug is that it fixes (or if it's even causing any problems). Care you clarify?
If it's just fixing inaccurate DT that isn't used, then it's not something we urgently need to fix in 4.19 and it can wait for 4.20.
Thanks,
-Olof
cover STM32: Fixes for 4.19 cycle
Hi Olof
Quoted 10 lines · Olof Johansson
Hi Alexandre,
Quoted 4 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?The patches only mention removing unused property contents, not what the bug is that it fixes (or if it's even causing any problems). Care you clarify?
Sure.
Concerning SPI patch: without this patch, DMA request will fail but there will be no crash because SPI will switch in interrupt mode. Concerning HASH one, it's just to align DT with dt-bindings documentation. Regarding the minor issue that they fix I could understand that you postpone the merge of those two patches for 4.20.
Regards
Alex
Quoted 10 lines
If it's just fixing inaccurate DT that isn't used, then it's not something we urgently need to fix in 4.19 and it can wait for 4.20.
Thanks,
-Olof
cover STM32: Fixes for 4.19 cycle
Hi,
Quoted 20 lines · Alexandre Torgue
Hi Olof
Quoted 7 lines · Olof Johansson
Hi Alexandre,
Quoted 3 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Quoted 8 lines
Quoted 3 lines
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?The patches only mention removing unused property contents, not what the bug is
that it fixes (or if it's even causing any problems). Care you clarify?
Quoted 6 lines
Sure.
Concerning SPI patch: without this patch, DMA request will fail but there will be no crash because SPI will switch in interrupt mode. Concerning HASH one, it's just to align DT with dt-bindings documentation. Regarding the minor issue that they fix I could understand that you postpone the merge of those two patches for 4.20.
The former sounds like an appropriate fix, but the latter is probably 4.20 material, indeed.
Should I just cherry-pick the two patches, or do you want to re-stage new branches?
-Olof
cover STM32: Fixes for 4.19 cycle
Olof
Quoted 32 lines · Olof Johansson
Hi,
Quoted 20 lines · Alexandre Torgue
Hi Olof
Quoted 7 lines · Olof Johansson
Hi Alexandre,
Quoted 3 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Quoted 8 lines
Quoted 3 lines
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?The patches only mention removing unused property contents, not what the bug is
that it fixes (or if it's even causing any problems). Care you clarify?Quoted 6 lines
Sure.
Concerning SPI patch: without this patch, DMA request will fail but there will be no crash because SPI will switch in interrupt mode. Concerning HASH one, it's just to align DT with dt-bindings documentation. Regarding the minor issue that they fix I could understand that you postpone the merge of those two patches for 4.20.
Quoted 5 lines
The former sounds like an appropriate fix, but the latter is probably 4.20 material, indeed.
Should I just cherry-pick the two patches, or do you want to re-stage new branches?
I have nothing else to send for v4.20 so if you can directly take those two patches for v4.20, I agree.
thanks
alex
Quoted 4 lines
-Olof
Olof Johansson
Appliedcover STM32: Fixes for 4.19 cycle
Quoted 35 lines · Alexandre Torgue
Olof
Quoted 32 lines · Olof Johansson
Hi,
Quoted 26 lines · Alexandre Torgue
Hi Olof
Quoted 7 lines · Olof Johansson
Hi Alexandre,
Quoted 3 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Quoted 8 lines
Quoted 3 lines
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?The patches only mention removing unused property contents, not what the bug is
that it fixes (or if it's even causing any problems). Care you clarify?Sure.
Concerning SPI patch: without this patch, DMA request will fail but there will be no crash because SPI will switch in interrupt mode. Concerning HASH one, it's just to align DT with dt-bindings documentation. Regarding the minor issue that they fix I could understand that you postpone the merge of those two patches for 4.20.
Quoted 8 lines
Quoted 5 lines
The former sounds like an appropriate fix, but the latter is probably 4.20 material, indeed.
Should I just cherry-pick the two patches, or do you want to re-stage new branches?
I have nothing else to send for v4.20 so if you can directly take those two patches for v4.20, I agree.
Thanks! Applied to fixes and next/dt respectively.
-Olof
cover STM32: Fixes for 4.19 cycle
Quoted 40 lines · Olof Johansson
Quoted 38 lines · Alexandre Torgue
Olof
Quoted 35 lines · Olof Johansson
Hi,
Quoted 20 lines · Alexandre Torgue
Hi Olof
Quoted 7 lines · Olof Johansson
Hi Alexandre,
Quoted 3 lines · Alexandre Torgue
Hi Arnd, olof and Kevin
Quoted 8 lines
Quoted 3 lines
Those 2 patches fixe the same issue on 4.19-rc: a bad usage of the mdma binding inside
stm32mp157c.dtsfile. Can you please add them as fixe for 4.19 ?The patches only mention removing unused property contents, not what the bug is
that it fixes (or if it's even causing any problems). Care you clarify?Quoted 6 lines
Sure.
Concerning SPI patch: without this patch, DMA request will fail but there will be no crash because SPI will switch in interrupt mode. Concerning HASH one, it's just to align DT with dt-bindings documentation. Regarding the minor issue that they fix I could understand that you postpone the merge of those two patches for 4.20.The former sounds like an appropriate fix, but the latter is probably 4.20 material, indeed.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Should I just cherry-pick the two patches, or do you want to re-stage new branches?
I have nothing else to send for v4.20 so if you can directly take those two patches for v4.20, I agree.
Thanks! Applied to fixes and next/dt respectively.
Looks like "ARM: dts: stm32: update HASH1 dmas property on stm32mp157c" got dropped due to being applied to the wrong tree/branch, so included it in fixes now.
-Olof