Skip to contentSkip to conversation

xlib_libxshmfence: drop AUTORECONF

PATCH New Thomas Petazzoni 3 participants 5 messages Sep 23, 2018 – Oct 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xlib_libxshmfence: drop AUTORECONF

In commit 2524acd4179fccc627a72ff188bf51c95fed9876 ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but the corresponding AUTORECONF = YES was not dropped.

This causes a build issue if just xlib_libxshmfence is built (using "make xlib_libxshmfence" or using per-package host/target directories):

Quoted 1 line
Quoted 1 line
Quoted 1 line

xlib_libxshmfence 1.3 Autoreconfiguring

configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen configure.ac:40: the top level

This commit fixes that by dropping the no longer needed AUTORECONF = YES.

---
 package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 ---
 1 file changed, 3 deletions(-)
package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk +0 -3
index f395ebe172..605408fff7 100644
@@ -12,7 +12,4 @@ XLIB_LIBXSHMFENCE_LICENSE_FILES = COPYING
 XLIB_LIBXSHMFENCE_INSTALL_STAGING = YES
 XLIB_LIBXSHMFENCE_DEPENDENCIES = host-pkgconf xorgproto
 
-# 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
-XLIB_LIBXSHMFENCE_AUTORECONF = YES
-
 $(eval $(autotools-package))
Signature · 1 line
2.14.4
#1 lore raw

PATCH 1/1 xlib_libxshmfence: drop AUTORECONF

Thomas, All,

On 2018-09-23 15:37 +0200, Thomas Petazzoni spake thusly:

Quoted 1 line

In commit 2524acd4179fccc627a72ff188bf51c95fed9876

This sha1 does not exist in the official Buildroot tree...

However, 2524acd4179fccc627a72ff188bf51c95fed9867 does exist, and its title is indeed the one you quoted... So, I really wonder how you managed to invert just the last two xdigits in that sha1... :-/

Regards,
Yann E. MORIN.

Quoted 38 lines

("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but the corresponding AUTORECONF = YES was not dropped.

This causes a build issue if just xlib_libxshmfence is built (using "make xlib_libxshmfence" or using per-package host/target directories):

Quoted 1 line
Quoted 1 line
Quoted 1 line

xlib_libxshmfence 1.3 Autoreconfiguring

configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen configure.ac:40: the top level

This commit fixes that by dropping the no longer needed AUTORECONF = YES.

---
 package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 ---
 1 file changed, 3 deletions(-)
package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk +0 -3
index f395ebe172..605408fff7 100644
@@ -12,7 +12,4 @@ XLIB_LIBXSHMFENCE_LICENSE_FILES = COPYING
 XLIB_LIBXSHMFENCE_INSTALL_STAGING = YES
 XLIB_LIBXSHMFENCE_DEPENDENCIES = host-pkgconf xorgproto
 
-# 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch
-XLIB_LIBXSHMFENCE_AUTORECONF = YES
-
 $(eval $(autotools-package))
Signature · 6 lines
2.14.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 xlib_libxshmfence: drop AUTORECONF

Hello,

Quoted 10 lines · Yann E. MORIN

Thomas, All,

On 2018-09-23 15:37 +0200, Thomas Petazzoni spake thusly:

Quoted 1 line

In commit 2524acd4179fccc627a72ff188bf51c95fed9876

This sha1 does not exist in the official Buildroot tree...

However, 2524acd4179fccc627a72ff188bf51c95fed9867 does exist, and its title is indeed the one you quoted... So, I really wonder how you managed to invert just the last two xdigits in that sha1... :-/

Gah, it's a Ctrl+T in Emacs, which inverts two characters.

Quoted 1 line

Thanks for the review and spotting this mistake!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
author Applied
#3 lore raw

PATCH 1/1 xlib_libxshmfence: drop AUTORECONF

In reply to Thomas Petazzoni

Hello,

Quoted 12 lines · Thomas Petazzoni

In commit 2524acd4179fccc627a72ff188bf51c95fed9876 ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but the corresponding AUTORECONF = YES was not dropped.

This causes a build issue if just xlib_libxshmfence is built (using "make xlib_libxshmfence" or using per-package host/target directories):

Quoted 1 line
Quoted 1 line
Quoted 1 line

xlib_libxshmfence 1.3 Autoreconfiguring

configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen configure.ac:40: the top level

Quoted 7 lines

This commit fixes that by dropping the no longer needed AUTORECONF = YES.

---
 package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 ---
 1 file changed, 3 deletions(-)

Applied to master after fixing the reference to the commit, as noticed by Yann.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 xlib_libxshmfence: drop AUTORECONF

In reply to Thomas Petazzoni
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In commit 2524acd4179fccc627a72ff188bf51c95fed9876 ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but the corresponding AUTORECONF = YES was not dropped.

This causes a build issue if just xlib_libxshmfence is built (using "make xlib_libxshmfence" or using per-package host/target directories):

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

xlib_libxshmfence 1.3 Autoreconfiguring

configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen configure.ac:40: the top level

This commit fixes that by dropping the no longer needed AUTORECONF = YES.

Committed to 2018.05.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard