Skip to contentSkip to conversation

ASoC: cs4265: Add a MIC pre. route

PATCH Superseded Matt Flax 2 participants 2 messages Sep 23, 2018 – Sep 24, 2018

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Matt Flax

author
#0 lore raw

PATCH 1/1 ASoC: cs4265: Add a MIC pre. route

The cs4265 driver is missing a microphone preamp enable. This patch enables/disables the microphone preamp when mic selection is made using the kcontrol.

---
 sound/soc/codecs/cs4265.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/soc/codecs/cs4265.c +4 -0
index 275677de..332d714a 100644
@@ -230,6 +230,10 @@ static const struct snd_soc_dapm_route cs4265_audio_map[] = {
 	{"DAI1 Capture", NULL, "DOUT"},
 	{"DAI2 Capture", NULL, "DOUT"},
 
+	{ "Pre-amp MIC", NULL, "MICL" },
+	{ "Pre-amp MIC", NULL, "MICR" },
+	{ "ADC Mux", "MIC", "Pre-amp MIC" },
+
 	/* Loopback */
 	{"Loopback", "Switch", "ADC"},
 	{"DAC", NULL, "Loopback"},
Signature · 1 line
2.17.1
#1 lore raw
Quoted 14 lines · Matt Flax

The cs4265 driver is missing a microphone preamp enable. This patch enables/disables the microphone preamp when mic selection is made using the kcontrol.

---
 sound/soc/codecs/cs4265.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/soc/codecs/cs4265.c +0 -0
index 275677de..332d714a 100644

sound/soc/codecs/cs4265.c static const struct snd_soc_dapm_route cs4265_audio_map[] = { · line 236

Quoted 7 lines
sound/soc/codecs/cs4265.c +4 -0
@@ -230,6 +230,10 @@ static const struct snd_soc_dapm_route cs4265_audio_map[] = {
 	{"DAI1 Capture", NULL, "DOUT"},
 	{"DAI2 Capture", NULL, "DOUT"},
 
+	{ "Pre-amp MIC", NULL, "MICL" },
+	{ "Pre-amp MIC", NULL, "MICR" },
+	{ "ADC Mux", "MIC", "Pre-amp MIC" },
+

This looks good but I think you should also remove the existing routes that put the mic straight into the ADC Mux.

{"ADC Mux", "MIC", "MICL"},
{"ADC Mux", "MIC", "MICR"},

Thanks,
Charles