Skip to contentSkip to conversation

ARM: dts: da850-lego-ev3: slow down A/DC as much as possible

PATCH In review David Lechner 2 participants 3 messages Sep 24, 2018 – Sep 25, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: da850-lego-ev3: slow down A/DC as much as possible

Due to the electrical design of the A/DC circuits on LEGO MINDSTORMS EV3, if we are reading analog values as fast as possible (i.e. using DMA to service the SPI) the A/DC chip will read incorrect values - as much as 0.1V off when the SPI is running at 10MHz. (This has to do with the capacitor charge time when channels are muxed in the A/DC.)

This patch slows down the SPI as much as possible (if CPU is at 456MHz, SPI runs at 1/2 of that, so 228MHz and has a max prescalar of 256, so we could get ~891kHz, but we're just rounding it to 1MHz). We also use the max allowable value for WDELAY to slow things down even more.

These changes reduce the error of the analog values to about 5mV, which is tolerable.

Commits a3762b13a596 ("spi: spi-davinci: Add support for SPI_CS_WORD") and e2540da86ef8 ("iio: adc: ti-ads7950: use SPI_CS_WORD to reduce CPU usage") introduce changes that allow DMA transfers to be used, so this slow down is needed now.

---

FYI, this patch doesn't strictly depend on the other two mentioned. In fact, it would better if it got merged before them, but the consequences are minimal, so it doesn't seem worth it to me to try coordinating merges here.

Both of these patches mentioned have been picked up in the respective subsystems.

 arch/arm/boot/dts/da850-lego-ev3.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/da850-lego-ev3.dts +2 -1
index c4729d0e6c19..66fcadf0ba91 100644
@@ -352,7 +352,8 @@
 		compatible = "ti,ads7957";
 		reg = <3>;
 		#io-channel-cells = <1>;
-		spi-max-frequency = <10000000>;
+		spi-max-frequency = <1000000>;
+		ti,spi-wdelay = <63>;
 		vref-supply = <&adc_ref>;
 	};
 };
Signature · 1 line
2.17.1
#1 lore raw

Hi David,

Quoted 5 lines · David Lechner

Due to the electrical design of the A/DC circuits on LEGO MINDSTORMS EV3, if we are reading analog values as fast as possible (i.e. using DMA to service the SPI) the A/DC chip will read incorrect values - as much as 0.1V off when the SPI is running at 10MHz. (This has to do with the capacitor charge time when channels are muxed in the A/DC.)

So you believe this is an issue with the board design rather than the limitation of the ADC chip itself? Because if its the later, the fix should be in the driver instead.

Quoted 15 lines

This patch slows down the SPI as much as possible (if CPU is at 456MHz, SPI runs at 1/2 of that, so 228MHz and has a max prescalar of 256, so we could get ~891kHz, but we're just rounding it to 1MHz). We also use the max allowable value for WDELAY to slow things down even more.

These changes reduce the error of the analog values to about 5mV, which is tolerable.

Commits a3762b13a596 ("spi: spi-davinci: Add support for SPI_CS_WORD") and e2540da86ef8 ("iio: adc: ti-ads7950: use SPI_CS_WORD to reduce CPU usage") introduce changes that allow DMA transfers to be used, so this slow down is needed now.

Quoted 8 lines

---

FYI, this patch doesn't strictly depend on the other two mentioned. In fact, it would better if it got merged before them, but the consequences are minimal, so it doesn't seem worth it to me to try coordinating merges here.

Both of these patches mentioned have been picked up in the respective subsystems.

Is this needed for the -rc cycle or can wait for v4.20?

Thanks,
Sekhar

Quoted 21 lines
 arch/arm/boot/dts/da850-lego-ev3.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/da850-lego-ev3.dts +2 -1
index c4729d0e6c19..66fcadf0ba91 100644
@@ -352,7 +352,8 @@
 		compatible = "ti,ads7957";
 		reg = <3>;
 		#io-channel-cells = <1>;
-		spi-max-frequency = <10000000>;
+		spi-max-frequency = <1000000>;
+		ti,spi-wdelay = <63>;
 		vref-supply = <&adc_ref>;
 	};
 };
Signature · 1 line
2.17.1
#2 lore raw
Quoted 9 lines · Sekhar Nori

Hi David,

Quoted 5 lines · David Lechner

Due to the electrical design of the A/DC circuits on LEGO MINDSTORMS EV3, if we are reading analog values as fast as possible (i.e. using DMA to service the SPI) the A/DC chip will read incorrect values - as much as 0.1V off when the SPI is running at 10MHz. (This has to do with the capacitor charge time when channels are muxed in the A/DC.)

Quoted 3 lines

So you believe this is an issue with the board design rather than the limitation of the ADC chip itself? Because if its the later, the fix should be in the driver instead.

It is the board design. There are external 4.7k series resistors that make the RC charge time so long.

Quoted 6 lines
Quoted 4 lines

Both of these patches mentioned have been picked up in the respective subsystems.

Is this needed for the -rc cycle or can wait for v4.20?

v4.20