Skip to contentSkip to conversation

arm64: amd: seattle: Use "spi" as name for SPI controllers

PATCH New Thierry Reding 2 participants 3 messages Sep 24, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: amd: seattle: Use "spi" as name for SPI controllers

From: Thierry Reding <[email protected]>

Recent versions of DTC contain additional checks for SPI busses and warn about certain common mistakes, such as when an SPI controller has a name other than "spi".

---
 arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi +2 -2
index 125f4deb52fe..b664e7af74eb 100644
@@ -107,7 +107,7 @@
 			clock-names = "uartclk", "apb_pclk";
 		};
 
-		spi0: ssp at e1020000 {
+		spi0: spi at e1020000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1020000 0 0x1000>;
@@ -117,7 +117,7 @@
 			clock-names = "apb_pclk";
 		};
 
-		spi1: ssp at e1030000 {
+		spi1: spi at e1030000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1030000 0 0x1000>;
Signature · 1 line
2.19.0
maintainer
#1 lore raw

PATCH 1/1 arm64: amd: seattle: Use "spi" as name for SPI controllers

Quoted 7 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Recent versions of DTC contain additional checks for SPI busses and warn about certain common mistakes, such as when an SPI controller has a name other than "spi".

Looks like the same patch was already submitted:

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-September/601706.html

Thanks,
Tom

Quoted 27 lines
---
 arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi +2 -2
index 125f4deb52fe..b664e7af74eb 100644
@@ -107,7 +107,7 @@
 			clock-names = "uartclk", "apb_pclk";
 		};
 
-		spi0: ssp at e1020000 {
+		spi0: spi at e1020000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1020000 0 0x1000>;
@@ -117,7 +117,7 @@
 			clock-names = "apb_pclk";
 		};
 
-		spi1: ssp at e1030000 {
+		spi1: spi at e1030000 {
 			status = "disabled";
 			compatible = "arm,pl022", "arm,primecell";
 			reg = <0 0xe1030000 0 0x1000>;
#2 lore raw

PATCH 1/1 arm64: amd: seattle: Use "spi" as name for SPI controllers

Quoted 7 lines · Thomas
Quoted 6 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Recent versions of DTC contain additional checks for SPI busses and warn about certain common mistakes, such as when an SPI controller has a name other than "spi".

Quoted 5 lines
Quoted 1 line

Looks like the same patch was already submitted:

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-September/601706.html

Indeed. I had done a quick search and not seen these submitted in recent days and since the DTC change that causes these had only landed in -next on Friday I had assumed that they must not have been fixed yet.

I wouldn't have thought that Rob had preemptively sent out the fixes. But it being Rob, maybe I should have. =)

Sorry for the noise,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180924/1ef69125/attachment.sig>