Skip to contentSkip to conversation

ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

PATCH In review Andreas Kemnade 2 participants 2 messages Sep 24, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: omap3-gta04: add pulldown/up settings for twl4030 gpio

Pullup and down settings were missing, so add them to avoid floating pins and make headset detection working.

---
 arch/arm/boot/dts/omap3-gta04.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)
arch/arm/boot/dts/omap3-gta04.dtsi +13 -0
index 09e45e7ad4bc..6bcb459c1b20 100644
@@ -657,6 +657,19 @@
 	status = "disabled";
 };
 
+#define BIT(x) (1 << (x))
+&twl_gpio {
+	/* pullups: BIT(2) */
+	ti,pullups = <BIT(2)>;
+	/*
+	 * pulldowns:
+	 * BIT(0),  BIT(1), BIT(6), BIT(7), BIT(8), BIT(13)
+	 * BIT(15), BIT(16), BIT(17)
+	 */
+	ti,pulldowns = <(BIT(0) | BIT(1) | BIT(6) | BIT(7) | BIT(8) |
+			 BIT(13) | BIT(15) | BIT(16) | BIT(17))>;
+};
+
 &twl_keypad {
 	status = "disabled";
 };
Signature · 1 line
2.11.0
#1 lore raw
Quoted 2 lines · Andreas Kemnade

Pullup and down settings were missing, so add them to avoid floating pins and make headset detection working.

Applying into omap-for-v4.20/dt thanks.

Tony