qed: Fix mask parameter in qed_vf_prep_tunn_req_tlv
Subsystems (3)
PATCH 1/1 qed: Fix mask parameter in qed_vf_prep_tunn_req_tlv
Clang complains when one enumerated type is implicitly converted to another.
drivers/net/ethernet/qlogic/qed/qed_vf.c:686:6: warning: implicit conversion from enumeration type 'enum qed_tunn_mode' to different enumeration type 'enum qed_tunn_clss' [-Wenum-conversion]
QED_MODE_L2GENEVE_TUNN,
^~~~~~~~~~~~~~~~~~~~~~Update mask's parameter to expect qed_tunn_mode, which is what was intended.
--- drivers/net/ethernet/qlogic/qed/qed_vf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/qlogic/qed/qed_vf.c +2 -2
@@ -572,7 +572,7 @@ int qed_vf_hw_prepare(struct qed_hwfn *p_hwfn)static void __qed_vf_prep_tunn_req_tlv (struct vfpf_update_tunn_param_tlv *p_req,struct qed_tunn_update_type *p_src, -enum qed_tunn_clss mask,u8 *p_cls) +enum qed_tunn_mode mask,u8 *p_cls) {if (p_src->b_update_mode) { p_req->tun_mode_update_mask |=BIT (mask);
@@ -587,7 +587,7 @@ __qed_vf_prep_tunn_req_tlv(struct vfpf_update_tunn_param_tlv *p_req,static void qed_vf_prep_tunn_req_tlv (struct vfpf_update_tunn_param_tlv *p_req,struct qed_tunn_update_type *p_src, -enum qed_tunn_clss mask, +enum qed_tunn_mode mask,u8 *p_cls,struct qed_tunn_update_udp_port *p_port,u8 *p_update_port,u16 *p_udp_port) {
Signature · 1 line
2.19.0
From: Nathan Chancellor <[email protected]>
Date: Mon, 24 Sep 2018 14:05:27 -0700
Quoted 6 lines
Clang complains when one enumerated type is implicitly converted to another.
drivers/net/ethernet/qlogic/qed/qed_vf.c:686:6: warning: implicit conversion from enumeration type 'enumqed_tunn_mode' to different enumeration type 'enumqed_tunn_clss' [-Wenum-conversion]
Quoted 8 lines
QED_MODE_L2GENEVE_TUNN, ^~~~~~~~~~~~~~~~~~~~~~Update mask's parameter to expect
qed_tunn_mode, which is what was intended.
Applied