Skip to contentSkip to conversation

dt-bindings: iio: light: bh1750: Add device tree binding documentation

PATCH Superseded ryang 2 participants 4 messages Sep 22, 2018 – Sep 24, 2018

Subsystems (3)
Device tree bindings IIO ROHM BH1750 ambient light sensor driver

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

ryang

author
#0 lore raw

PATCH v3 1/2 dt-bindings: iio: light: bh1750: Add device tree binding documentation

Document device tree bindings for ROHM BH1750 ambient light sensor driver.

Signed-off-by ryang <[email protected]>
---
 .../devicetree/bindings/iio/light/bh1750.txt   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
Documentation/devicetree/bindings/iio/light/bh1750.txt new file +18 -0
new file mode 100644
index 000000000000..468350cc7af6
@@ -0,0 +1,18 @@
+ROHM BH1750 - ALS, Ambient light sensor
+
+Required properties:
+
+- compatible: Must be one of:
+    "rohm,bh1710"
+    "rohm,bh1715"
+    "rohm,bh1721"
+    "rohm,bh1750"
+    "rohm,bh1751"
+- reg: the I2C address of the sensor
+
+Example:
+
+bh1750@23 {
+	compatible = "rohm,bh1750";
+	reg = <0x23>;
+};
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v3 2/2 iio: light: bh1750: Add device tree support

Add device tree support for ROHM BH1750 series ambient light sensors.

Signed-off-by ryang <[email protected]>

---
Changes in v2:
- Export module device table
Changes in v3:
- Remove of_match_ptr so that bh1750_of_match is available without CONFIG_OF.

 drivers/iio/light/bh1750.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/iio/light/bh1750.c +11 -0
index c3a481452b67..28347df78cff 100644
@@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, bh1750_id);
 
+static const struct of_device_id bh1750_of_match[] = {
+	{ .compatible = "rohm,bh1710", },
+	{ .compatible = "rohm,bh1715", },
+	{ .compatible = "rohm,bh1721", },
+	{ .compatible = "rohm,bh1750", },
+	{ .compatible = "rohm,bh1751", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, bh1750_of_match);
+
 static struct i2c_driver bh1750_driver = {
 	.driver = {
 		.name = "bh1750",
+		.of_match_table = bh1750_of_match,
 		.pm = &bh1750_pm_ops,
 	},
 	.probe = bh1750_probe,
Signature · 1 line
2.17.1
maintainer
#2 lore raw

Re: [PATCH v3 2/2] iio: light: bh1750: Add device tree support

Quoted 3 lines · On Sat, 22 Sep 2018 16:57:54 -0400 ryang <[email protected]> wrote:

Add device tree support for ROHM BH1750 series ambient light sensors.

Signed-off-by ryang <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 35 lines

---
Changes in v2:
- Export module device table
Changes in v3:
- Remove of_match_ptr so that bh1750_of_match is available without CONFIG_OF.

 drivers/iio/light/bh1750.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/iio/light/bh1750.c +11 -0
index c3a481452b67..28347df78cff 100644
@@ -307,9 +307,20 @@ static const struct i2c_device_id bh1750_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, bh1750_id);
 
+static const struct of_device_id bh1750_of_match[] = {
+	{ .compatible = "rohm,bh1710", },
+	{ .compatible = "rohm,bh1715", },
+	{ .compatible = "rohm,bh1721", },
+	{ .compatible = "rohm,bh1750", },
+	{ .compatible = "rohm,bh1751", },
+	{ }
+};
+MODULE_DEVICE_TABLE(of, bh1750_of_match);
+
 static struct i2c_driver bh1750_driver = {
 	.driver = {
 		.name = "bh1750",
+		.of_match_table = bh1750_of_match,
 		.pm = &bh1750_pm_ops,
 	},
 	.probe = bh1750_probe,
maintainer
#3 lore raw
In reply to ryang
Quoted 3 lines · On Sat, 22 Sep 2018 16:57:53 -0400 ryang <[email protected]> wrote:

Document device tree bindings for ROHM BH1750 ambient light sensor driver.

Signed-off-by ryang <[email protected]>

The devicetree maintainers haven't yet had a chance to look at this so we may well still get feedback from them. As I'm not planning on a pull request for a few days I'll apply this to the tree I push out as testing for the autobuilders to play with. The advantage if this is that isn't a non rebasing tree so I can add acks if they come in before I push it out as togreg ready for a pull request.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 29 lines
---
 .../devicetree/bindings/iio/light/bh1750.txt   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/light/bh1750.txt
Documentation/devicetree/bindings/iio/light/bh1750.txt new file +18 -0
new file mode 100644
index 000000000000..468350cc7af6
@@ -0,0 +1,18 @@
+ROHM BH1750 - ALS, Ambient light sensor
+
+Required properties:
+
+- compatible: Must be one of:
+    "rohm,bh1710"
+    "rohm,bh1715"
+    "rohm,bh1721"
+    "rohm,bh1750"
+    "rohm,bh1751"
+- reg: the I2C address of the sensor
+
+Example:
+
+bh1750@23 {
+	compatible = "rohm,bh1750";
+	reg = <0x23>;
+};