staging: vc04_services: Update TODO re: arm64
Subsystems (3)
PATCH 1/1 staging: vc04_services: Update TODO re: arm64
This patch removes the TODO item to remove manual cache flushing from b ulk_receieve - this was done in 7e8dbea. Also remove the unnecessary asm/cacheflush.h header.
--- drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/TODO +0 -6
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0 -1
@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
Signature · 1 line
2.17.1
Hi Aymen
Quoted 1 line · Aymen Qader
This patch removes the TODO item to remove manual cache flushing from b
Remove the use of "This patch".
Please read
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
"Describe your changes in imperative mood"
Also, it looks like you broke "bulk_receive" across 2 lines. Please correct and fix receive typo.
Quoted 1 line
ulk_receieve- this was done in 7e8dbea. Also remove the unnecessary
also read in the guidelines:
If you want to refer to a specific commit, don't just refer to the SHA-1 ID of the commit.
Please also include the oneline summary of the commit, to make it easier for reviewers to know what it is about.
Quoted 34 lines
asm/cacheflush.hheader.Signed-off-by Aymen Qader <[email protected]>--- drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)drivers/staging/vc04_services/bcm2835-camera/TODO +0
-6@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0
-1@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
PATCH v2 1/1 staging: vc04_services: Update TODO re: arm64
In reply to Aymen QaderRemove the TODO item to remove manual cache flushing from bulk_receive. This was previously done in this commit:
(7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush operations
Also remove the unnecessary asm/cacheflush.h header.
---
v2: Make commit message clearer
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/TODO +0 -6
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0 -1
@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
Signature · 1 line
2.17.1
Hi Aymen,
there are more than one TODO file in vc04_services (contains 3 drivers), so here is my suggestion for the subject:
staging: bcm2835-camera: Update TODO
Am 25.09.2018 um 01:34 schrieb Aymen Qader:
Quoted 5 lines
Remove the TODO item to remove manual cache flushing from
bulk_receive. This was previously done in this commit:(
7e8dbdea) staging: bcm2835-camera: Remove explicit cache flush operations
please use this format, which should also make scripts/checkpatch.pl happy:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations ")
Quoted 2 lines
Also remove the unnecessary
asm/cacheflush.hheader.
This doesn't match to the subject. Maybe a separate patch would be better here.
Thanks
Stefan
Quoted 35 lines
Signed-off-by Aymen Qader <[email protected]>---
v2: Make commit message clearerdrivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)drivers/staging/vc04_services/bcm2835-camera/TODO +0
-6@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0
-1@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
v3 cover staging: bcm2835-camera: Clean up completed TODO
In reply to Aymen QaderUpdate the bcm2835-camera driver to remove a TODO and an unused header include. These were made unnecessary in
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Remove unused header
--
v2: Make commit message clearer
v3: Separate patch into two, clean up commit messages
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)
Signature · 1 line
2.17.1
PATCH v3 1/2 staging: bcm2835-camera: Update TODO
Remove the TODO item to remove manual cache flushing from bulk_receive. This was previously done in this commit:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
--- drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/TODO +0 -6
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -
Signature · 1 line
2.17.1
PATCH v3 1/2 staging: bcm2835-camera: Update TODO
In reply to Aymen QaderRemove the TODO item to remove manual cache flushing from bulk_receive. This was previously done in this commit:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
--- drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ 1 file changed, 6 deletions(-)
drivers/staging/vc04_services/bcm2835-camera/TODO +0 -6
@@ -15,9 +15,3 @@ padding in the V4L2 spec, but that padding doesn't match what the hardware can do. If we exposed the native padding requirements through the V4L2 "multiplanar" formats, the firmware would have one less copy it needed to do. - -3) Port to ARM64 - -The bulk_receive() does some manual cache flushing that are 32-bit ARM -only, which we should convert to proper cross-platform APIs. -
Signature · 1 line
2.17.1
v3 cover staging: bcm2835-camera: Clean up completed TODO
In reply to Aymen QaderUpdate the bcm2835-camera driver to remove a TODO and an unused header include. These were made unnecessary in
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Remove unused header
--
v2: Make commit message clearer
v3: Separate patch into two, clean up commit messages
drivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)
Signature · 1 line
2.17.1
Re: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO
Looks good now.
Quoted 10 lines · Aymen Qader
Update the bcm2835-camera driver to remove a TODO and an unused header include. These were made unnecessary in
commit
7e8dbea41032("staging: bcm2835-camera: Remove explicit cache flush operations")Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Remove unused header
Quoted 8 lines
--
v2: Make commit message clearer
v3: Separate patch into two, clean up commit messagesdrivers/staging/vc04_services/bcm2835-camera/TODO | 6 ------ drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 2 files changed, 7 deletions(-)
PATCH v3 2/2 staging: bcm2835-camera: Remove unused header
In reply to Aymen QaderRemove the asm/cacheflush.h header include from mmal-vchiq.c. This dependency was removed in:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
--- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0 -1
@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
Signature · 1 line
2.17.1
PATCH v3 2/2 staging: bcm2835-camera: Remove unused header
In reply to Aymen QaderRemove the asm/cacheflush.h header include from mmal-vchiq.c. This dependency was removed in:
commit 7e8dbea41032 ("staging: bcm2835-camera: Remove explicit cache flush operations")
--- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 1 - 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c +0 -1
@@ -21,7 +21,6 @@#include <linux/slab.h> #include <linux/completion.h> #include <linux/vmalloc.h> -#include <asm/cacheflush.h> #include <media/videobuf2-vmalloc.h> #include "mmal-common.h"
Signature · 1 line
2.17.1
Re: [PATCH v3 0/2] staging: bcm2835-camera: Clean up completed TODO
In reply to Aymen QaderQuoted 7 lines
Aymen Qader <[email protected]> hat am 25. September 2018 um 10:33 geschrieben:
Update the bcm2835-camera driver to remove a TODO and an unused header include. These were made unnecessary in
Quoted 6 lines
commit
7e8dbea41032("staging: bcm2835-camera: Remove explicit cache flush operations")Aymen Qader (2):
staging: bcm2835-camera: Update TODO
staging: bcm2835-camera: Remove unused header
The whole series is