Skip to contentSkip to conversation

ARM: dts: dra7: Fix up unaligned access setting for PCIe EP

PATCH In review Vignesh R 2 participants 4 messages Sep 25, 2018 – Sep 28, 2018 Device tree bindings

lore
Share & tools
lore

Vignesh R

author
#0 lore raw

PATCH v4 1/1 ARM: dts: dra7: Fix up unaligned access setting for PCIe EP

Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are incorrectly documented in the TRM. In fact, the bit positions are swapped. Update the DT bindings for PCIe EP to reflect the same.

Fixes d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode")

---

This patch is split from v3 here:
https://lore.kernel.org/patchwork/cover/967020/
Patch can be applied standalone and has no dependencies on other patches in v3.

 arch/arm/boot/dts/dra7.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/dra7.dtsi +1 -1
index 1050da6c6d35..fc50d6a8e51a 100644
@@ -355,7 +355,7 @@
 				ti,hwmods = "pcie1";
 				phys = <&pcie1_phy>;
 				phy-names = "pcie-phy0";
-				ti,syscon-unaligned-access = <&scm_conf1 0x14 2>;
+				ti,syscon-unaligned-access = <&scm_conf1 0x14 1>;
 				status = "disabled";
 			};
 		};
Signature · 1 line
2.19.0
#1 lore raw
Quoted 8 lines · Vignesh R

Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are incorrectly documented in the TRM. In fact, the bit positions are swapped. Update the DT bindings for PCIe EP to reflect the same.

Fixes d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode")
Quoted 6 lines

---

This patch is split from v3 here:
https://lore.kernel.org/patchwork/cover/967020/
Patch can be applied standalone and has no dependencies on other patches in v3.

Hmm is this needed for v4.19-rc cycle or can this wait for v4.20 merge window?

Regards,

Tony

author
#2 lore raw
Quoted 11 lines · Tony Lindgren
Quoted 10 lines · Vignesh R

Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are incorrectly documented in the TRM. In fact, the bit positions are swapped. Update the DT bindings for PCIe EP to reflect the same.

Fixes d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode")

---

Quoted 8 lines
Quoted 4 lines

This patch is split from v3 here:
https://lore.kernel.org/patchwork/cover/967020/
Patch can be applied standalone and has no dependencies on other patches in v3.

Hmm is this needed for v4.19-rc cycle or can this wait for v4.20 merge window?

v4.20 should be fine.

Signature · 2 lines
Regards
Vignesh
#3 lore raw
Quoted 19 lines · Vignesh R
Quoted 16 lines · Tony Lindgren
Quoted 14 lines · Vignesh R

Bit positions of PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE and PCIE_SS1_AXI2OCP_LEGACY_MODE_ENABLE in CTRL_CORE_SMA_SW_7 are incorrectly documented in the TRM. In fact, the bit positions are swapped. Update the DT bindings for PCIe EP to reflect the same.

Fixes d23f3839fe97 ("ARM: dts: DRA7: Add pcie1 dt node for EP mode")

---

This patch is split from v3 here:
https://lore.kernel.org/patchwork/cover/967020/
Patch can be applied standalone and has no dependencies on other patches in v3.

Quoted 5 lines
Quoted 3 lines

Hmm is this needed for v4.19-rc cycle or can this wait for v4.20 merge window?

v4.20 should be fine.

OK thanks applying into omap-for-v4.20/dt then.

Tony