Skip to contentSkip to conversation

atmodem/sim: change vendor CINTERION in GEMALTO

PATCH In review Giacinto Cifelli 2 participants 4 messages Sep 25, 2018 – Sep 26, 2018

lore
Share & tools
lore

Giacinto Cifelli

author
#0 lore raw

PATCH 1/1 atmodem/sim: change vendor CINTERION in GEMALTO

---
 drivers/atmodem/sim.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/atmodem/sim.c +5 -5
index 0907635d..2ce72c83 100644
@@ -66,7 +66,7 @@ static const char *oercn_prefix[] = { "_OERCN:", NULL };
 static const char *cpinr_prefixes[] = { "+CPINR:", "+CPINRE:", NULL };
 static const char *epin_prefix[] = { "*EPIN:", NULL };
 static const char *simcom_spic_prefix[] = { "+SPIC:", NULL };
-static const char *cinterion_spic_prefix[] = { "^SPIC:", NULL };
+static const char *gemalto_spic_prefix[] = { "^SPIC:", NULL };
 static const char *pct_prefix[] = { "#PCT:", NULL };
 static const char *pnnm_prefix[] = { "+PNNM:", NULL };
 static const char *qpinc_prefix[] = { "+QPINC:", NULL };

@@ -1110,7 +1110,7 @@ error:
 	CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
 }
 
-static void cinterion_spic_cb(gboolean ok, GAtResult *result,
+static void gemalto_spic_cb(gboolean ok, GAtResult *result,
 							gpointer user_data)
 {
 	struct cb_data *cbd = user_data;

@@ -1227,9 +1227,9 @@ static void at_pin_retries_query(struct ofono_sim *sim,
 					upincnt_cb, cbd, g_free) > 0)
 			return;
 		break;
-	case OFONO_VENDOR_CINTERION:
-		if (g_at_chat_send(sd->chat, "AT^SPIC", cinterion_spic_prefix,
-					cinterion_spic_cb, cbd, g_free) > 0)
+	case OFONO_VENDOR_GEMALTO:
+		if (g_at_chat_send(sd->chat, "AT^SPIC", gemalto_spic_prefix,
+					gemalto_spic_cb, cbd, g_free) > 0)
 			return;
 		break;
 	default:
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 gemalto plugin: sim vendor to GEMALTO

switched from CINTERION.
Note that the cinterion plugin itself does not use the specific vendor for the sms atom.

---
 plugins/gemalto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
plugins/gemalto.c +1 -1
index b7734124..6e0d765b 100644
@@ -571,7 +571,7 @@ static void gemalto_pre_sim(struct ofono_modem *modem)
 
 	ofono_devinfo_create(modem, 0, "atmodem", data->app);
 	ofono_location_reporting_create(modem, 0, "gemaltomodem", data->app);
-	data->sim = ofono_sim_create(modem, OFONO_VENDOR_CINTERION, "atmodem",
+	data->sim = ofono_sim_create(modem, OFONO_VENDOR_GEMALTO, "atmodem",
 						data->app);
 
 	if (data->sim && data->have_sim == TRUE)
Signature · 1 line
2.17.1
#2 lore raw
In reply to Giacinto Cifelli
Quoted 4 lines · Giacinto Cifelli
---
  drivers/atmodem/sim.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Both applied. Can you make sure that your patches are also sequence-numbered.

e.g.
git format-patch -2
git send-email 000*

Regards,
-Denis

author
#3 lore raw

hi Denis,

Quoted 6 lines · On Tue, 25 Sep 2018, 16:43 Denis Kenzior, <[email protected]> wrote:
Quoted 4 lines · Giacinto Cifelli
---
  drivers/atmodem/sim.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
Quoted 7 lines

Both applied. Can you make sure that your patches are also sequence-numbered.

e.g.
git format-patch -2
git send-email 000*

yes, I have forgotten in this particular instance, apologies.

Quoted 4 lines

Regards,
-Denis

regards,
Giacinto

Quoted 1 line