Skip to contentSkip to conversation

arm64: dts: Add support for NXP LS1028A SoC

PATCH New Sudhanshu Gupta 4 participants 5 messages Aug 29, 2018 – Sep 26, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: Add support for NXP LS1028A SoC

From: Bhaskar Upadhaya <[email protected]>

LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D cache and 48 KB L1-I cache

Features summary
Two 32-bit / 64-bit ARM v8 Cortex-A72 CPUs
- Arranged as single clusters of two cores sharing a 1 MB L2 cache
- Speed Up to 1.3 GHz
- Support for cluster power-gating.
Cache coherent interconnect (CCI-400)
- Hardware-managed data coherency
- Up to 400 MHz
32-bit DDR4 SDRAM memory controller with ECC
Two PCIe 3.0 controllers
One serial ATA (SATA 3.0) controller
Two high-speed USB 3.0 controllers with integrated PHY

Following levels of DTSI/DTS files have been created for the LS1028A
SoC family:

- fsl-ls1028a.dtsi:
DTS-Include file for NXP LS1028A SoC.

- fsl-ls1028a-qds.dts:
DTS file for NXP LS1028A QDS board.

- fsl-ls1028a-rdb.dts:
DTS file for NXP LS1028A RDB board

---
 arch/arm64/boot/dts/freescale/Makefile            |   2 +
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |  93 ++++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |  74 +++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    | 355 ++++++++++++++++++++++
 4 files changed, 524 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
arch/arm64/boot/dts/freescale/Makefile +2 -0
index d116144..b33c64a 100644
@@ -3,6 +3,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1046a-qds.dtb
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +93 -0

93 lines not on this page · raw message

arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +74 -0

74 lines not on this page · raw message

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +355 -0

355 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 arm64: dts: Add support for NXP LS1028A SoC

Quoted 95 lines · Sudhanshu Gupta

From: Bhaskar Upadhaya <[email protected]>

LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D cache and 48 KB L1-I cache

Features summary
Two 32-bit / 64-bit ARM v8 Cortex-A72 CPUs
- Arranged as single clusters of two cores sharing a 1 MB L2 cache
- Speed Up to 1.3 GHz
- Support for cluster power-gating.
Cache coherent interconnect (CCI-400)
- Hardware-managed data coherency
- Up to 400 MHz
32-bit DDR4 SDRAM memory controller with ECC
Two PCIe 3.0 controllers
One serial ATA (SATA 3.0) controller
Two high-speed USB 3.0 controllers with integrated PHY

Following levels of DTSI/DTS files have been created for the LS1028A
SoC family:

- fsl-ls1028a.dtsi:
DTS-Include file for NXP LS1028A SoC.

- fsl-ls1028a-qds.dts:
DTS file for NXP LS1028A QDS board.

- fsl-ls1028a-rdb.dts:
DTS file for NXP LS1028A RDB board

---
 arch/arm64/boot/dts/freescale/Makefile            |   2 +
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |  93 ++++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |  74 +++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    | 355 ++++++++++++++++++++++
 4 files changed, 524 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
arch/arm64/boot/dts/freescale/Makefile +2 -0
index d116144..b33c64a 100644
@@ -3,6 +3,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1046a-qds.dtb
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +33 -0
new file mode 100644
index 0000000..586d5cd
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for NXP LS1028A QDS Board.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+/dts-v1/;
+
+#include "fsl-ls1028a.dtsi"
+
+/ {
+	model = "LS1028A QDS Board";
+	compatible = "fsl,ls1028a-qds", "fsl,ls1028a";
+
+	aliases {
+		gpio0 = &gpio1;
+		gpio1 = &gpio2;
+		gpio2 = &gpio3;
+		serial0 = &duart0;
+		serial1 = &duart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&duart0 {
+	status = "okay";

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 43

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +10 -0
+};
+
+&duart1 {
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+
+	pca9847 at 77 {

Please have generic node name for the device.

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 54

Quoted 11 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +11 -0
+		compatible = "nxp,pca9847";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c at 2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x2>;
+
+			ina220 at 40 {

Ditto

Quoted 18 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +18 -0
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <1000>;
+			};
+
+			ina220 at 41 {
+				compatible = "ti,ina220";
+				reg = <0x41>;
+				shunt-resistor = <1000>;
+			};
+		};
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			eeprom at 56 {

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 82

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +10 -0
+				compatible = "atmel,24c512";
+				reg = <0x56>;
+			};
+
+			eeprom at 57 {
+				compatible = "atmel,24c512";
+				reg = <0x57>;
+			};
+
+			sa56004 at 4c {

Ditto

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 90

Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +8 -0
+				compatible = "nxp,sa56004";
+				reg = <0x4c>;
+			};
+
+			rtc at 51 {
+				compatible = "nxp,pcf2129";
+				reg = <0x51>;
+			};

Sort the nodes in order of unit-address.

Quoted 28 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +3 -0
+		};
+	};
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +19 -0
new file mode 100644
index 0000000..e5c4309
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for NXP LS1028A RDB Board.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a.dtsi"
+
+/ {
+	model = "LS1028A RDB Board";
+	compatible = "fsl,ls1028a-rdb", "fsl,ls1028a";
+
+	aliases {
+		serial0 = &duart0;

arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts line 29

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +10 -0
+		serial1 = &duart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&i2c0 {
+	status = "okay";

Have a newline between property and child node.

Quoted 107 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +45 -0
+	pca9847 at 77 {
+		compatible = "nxp,pca9847";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c at 2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x02>;
+
+			ina220 at 40 {
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <500>;
+			};
+		};
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			sa56004 at 4c {
+				compatible = "nxp,sa56004";
+				reg = <0x4c>;
+			};
+
+			rtc at 51 {
+				compatible = "nxp,pcf2129";
+				reg = <0x51>;
+			};
+		};
+	};
+
+
+};
+
+&duart0 {
+	status = "okay";
+};
+
+&duart1 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +56 -0
new file mode 100644
index 0000000..bc860e2
@@ -0,0 +1,355 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree Include file for NXP Layerscape-1028A family SoC.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+	compatible = "fsl,ls1028a";
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu0: cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x0>;
+			clocks = <&clockgen 1 0>;
+			next-level-cache = <&l2>;
+			cpu-idle-states = <&CPU_PH20>;
+			#cooling-cells = <2>;
+		};
+
+		cpu1: cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x1>;
+			clocks = <&clockgen 1 0>;
+			next-level-cache = <&l2>;
+			cpu-idle-states = <&CPU_PH20>;
+		};
+
+		l2: l2-cache {
+			compatible = "cache";
+		};
+	};
+
+	idle-states {
+		/*
+		 * PSCI node is not added default, U-boot will add missing
+		 * parts if it determines to use PSCI.
+		 */
+		entry-method = "arm,psci";
+
+		CPU_PH20: cpu-ph20 {
+			compatible = "arm,idle-state";

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 66

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+			idle-state-name = "PH20";
+			arm,psci-suspend-param = <0x00010000>;
+			entry-latency-us = <1000>;
+			exit-latency-us = <1000>;
+			min-residency-us = <3000>;
+		};
+	};
+
+	memory at 80000000 {
+		device_type = "memory";

With unit-address present on node name, a 'reg' property is required.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 69

Quoted 3 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +3 -0
+	};
+
+	sysclk: sysclk {

clock-sysclk for node name might be better?

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 81

Quoted 12 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +12 -0
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <100000000>;
+		clock-output-names = "sysclk";
+	};
+
+	reboot {
+		compatible ="syscon-reboot";
+		regmap = <&dcfg>;
+		offset = <0xb0>;
+		mask = <0x02>;
+		status = "disabled";

For such reboot support, I do not see why it should be disabled by default.

Quoted 13 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +13 -0
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(0xf) |
+					  IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_RAW(0xf) |
+					  IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_RAW(0xf) |
+					  IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_RAW(0xf) |
+					  IRQ_TYPE_LEVEL_LOW)>;
+	};

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 104

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+
+	pmu {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-affinity = <&cpu0>,
+				     <&cpu1>;
+		status = "disabled";

Ditto

Quoted 4 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +4 -0
+	};
+
+	gic: interrupt-controller at 6000000 {
+		compatible= "arm,gic-v3";

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 118

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+		reg= <0x0 0x06000000 0 0x10000>, /* GIC Dist */
+			<0x0 0x06040000 0 0x40000>; /* GIC Redistributor */
+		#interrupt-cells= <3>;
+		interrupt-controller;
+		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_RAW(0xf) |
+					 IRQ_TYPE_LEVEL_LOW)>;
+		its:gic-its at 6020000 {

There should be a space between label and node name.

Quoted 62 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +62 -0
+			compatible = "arm,gic-v3-its";
+			msi-controller;
+			reg = <0x0 0x06020000 0 0x20000>;/* GIC Translater */
+		};
+	};
+
+	soc: soc {
+		compatible = "simple-bus";
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		smmu: iommu at 5000000 {
+			compatible = "arm,mmu-500";
+			reg = <0 0x5000000 0 0x800000>;
+			#global-interrupts = <8>;
+			#iommu-cells = <1>;
+			stream-match-mask = <0x7C00>;
+			/* global secure fault */
+			interrupts = <0 13 4>,
+			/* combined secure interrupt */
+				     <0 14 4>,
+			/* global non-secure fault */
+				     <0 15 4>,
+			/* combined non-secure interrupt */
+				     <0 16 4>,
+			/* performance counter interrupts 0-7 */
+				     <0 211 4>, <0 212 4>,
+				     <0 213 4>, <0 214 4>,
+			/* per context interrupt, 64 interrupts */
+				     <0 146 4>, <0 147 4>,
+				     <0 148 4>, <0 149 4>,
+				     <0 150 4>, <0 151 4>,
+				     <0 152 4>, <0 153 4>,
+				     <0 154 4>, <0 155 4>,
+				     <0 156 4>, <0 157 4>,
+				     <0 158 4>, <0 159 4>,
+				     <0 160 4>, <0 161 4>,
+				     <0 162 4>, <0 163 4>,
+				     <0 164 4>, <0 165 4>,
+				     <0 166 4>, <0 167 4>,
+				     <0 168 4>, <0 169 4>,
+				     <0 170 4>, <0 171 4>,
+				     <0 172 4>, <0 173 4>,
+				     <0 174 4>, <0 175 4>,
+				     <0 176 4>, <0 177 4>,
+				     <0 178 4>, <0 179 4>,
+				     <0 180 4>, <0 181 4>,
+				     <0 182 4>, <0 183 4>,
+				     <0 184 4>, <0 185 4>,
+				     <0 186 4>, <0 187 4>,
+				     <0 188 4>, <0 189 4>,
+				     <0 190 4>, <0 191 4>,
+				     <0 192 4>, <0 193 4>,
+				     <0 194 4>, <0 195 4>,
+				     <0 196 4>, <0 197 4>,
+				     <0 198 4>, <0 199 4>,
+				     <0 200 4>, <0 201 4>,
+				     <0 202 4>, <0 203 4>,
+				     <0 204 4>, <0 205 4>,
+				     <0 206 4>, <0 207 4>,
+				     <0 208 4>, <0 209 4>;

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+		};
+
+		ddr: memory-controller at 1080000 {
+			compatible = "fsl,qoriq-memory-controller";
+			reg = <0x0 0x1080000 0x0 0x1000>;
+			interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+			big-endian;
+		};
+
+		scfg: scfg at 1fc0000 {

syscon is recommended by device tree spec as the node name.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 196

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+			compatible = "fsl,ls1028a-scfg", "syscon";
+			reg = <0x0 0x1fc0000 0x0 0x10000>;
+			big-endian;
+		};
+
+		dcfg: dcfg at 1e00000 {

Ditto

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 202

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+			compatible = "fsl,ls1028a-dcfg", "syscon";
+			reg = <0x0 0x1e00000 0x0 0x10000>;
+			big-endian;
+		};
+
+		clockgen: clocking at 1300000 {

clock-controller is recommended by device tree spec as the node name.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 207

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +5 -0
+			compatible = "fsl,ls1028a-clockgen";
+			reg = <0x0 0x1300000 0x0 0xa0000>;
+			#clock-cells = <2>;
+			clocks = <&sysclk>;
+		};

Nodes should be well sorted in unit-address.

Quoted 118 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +118 -0
+
+		i2c0: i2c at 2000000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2000000 0x0 0x10000>;
+			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			dma-names = "tx", "rx";
+			status = "disabled";
+		};
+
+		i2c1: i2c at 2010000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2010000 0x0 0x10000>;
+			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c2: i2c at 2020000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2020000 0x0 0x10000>;
+			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c3: i2c at 2030000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2030000 0x0 0x10000>;
+			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c4: i2c at 2040000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2040000 0x0 0x10000>;
+			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c5: i2c at 2050000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2050000 0x0 0x10000>;
+			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c6: i2c at 2060000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2060000 0x0 0x10000>;
+			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		i2c7: i2c at 2070000 {
+			compatible = "fsl,vf610-i2c";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x0 0x2070000 0x0 0x10000>;
+			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+		duart0: serial at 21c0500 {
+			compatible = "fsl,ns16550", "ns16550a";
+			reg = <0x00 0x21c0500 0x0 0x100>;
+			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+		};
+
+		duart1: serial at 21c0600 {
+			compatible = "fsl,ns16550", "ns16550a";
+			reg = <0x00 0x21c0600 0x0 0x100>;
+			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+		};
+
+		gpio1: gpio at 2300000 {
+			compatible = "fsl,qoriq-gpio";
+			reg = <0x0 0x2300000 0x0 0x10000>;
+			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		gpio2: gpio at 2310000 {
+			compatible = "fsl,qoriq-gpio";
+			reg = <0x0 0x2310000 0x0 0x10000>;
+			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		gpio3: gpio at 2320000 {
+			compatible = "fsl,qoriq-gpio";

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 335

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+			reg = <0x0 0x2320000 0x0 0x10000>;
+			interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		wdog0: watchdog at 23c0000 {
+			compatible= "arm,armv8-timer";

Why does a watchdog device get a timer compatible?

Shawn

Quoted 28 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +20 -0
+			reg = <0x0 0x23c0000 0x0 0x10000>;
+			interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			big-endian;
+			status = "disabled";
+		};
+
+		sata: sata at 3200000 {
+			compatible = "fsl,ls1028a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+				<0x0 0x20140520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+	};
+};
+
Signature · 7 lines
1.9.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 1/1 arm64: dts: Add support for NXP LS1028A SoC

Quoted 14 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, September 3, 2018 7:27 AM
To: Sudhanshu Gupta <[email protected]>
Cc: devicetree at vger.kernel.org; Harninder Rai <[email protected]>; Bhaskar Upadhaya <[email protected]>; stuart.yoder at nxp.com; Leo Li <[email protected]>; oss at buserror.net; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH] arm64: dts: Add support for NXP LS1028A SoC

Quoted 2 lines · Sudhanshu Gupta

From: Bhaskar Upadhaya <[email protected]>

Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 43

Quoted 6 lines

LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D cache and 48 KB L1-I cache
+&i2c0 {

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +3 -0
+	status = "okay";
+
+	pca9847 at 77 {

Please have generic node name for the device.

is i2c-mux at 77 ok ?

Quoted 14 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 54

Quoted 12 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +11 -0
+		compatible = "nxp,pca9847";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c at 2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x2>;
+
+			ina220 at 40 {

Ditto

Is current-monitor at 40 ok ?

Quoted 23 lines
Quoted 23 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +22 -0
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <1000>;
+			};
+
+			ina220 at 41 {
+				compatible = "ti,ina220";
+				reg = <0x41>;
+				shunt-resistor = <1000>;
+			};
+		};
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			eeprom at 56 {
+				compatible = "atmel,24c512";
+				reg = <0x56>;
+			};
+
Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 82

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +6 -0
+			eeprom at 57 {
+				compatible = "atmel,24c512";
+				reg = <0x57>;
+			};
+
+			sa56004 at 4c {

Ditto

Is thermal-monitor at 4c ok ?

Quoted 95 lines
Quoted 95 lines
(quoted diff) +2 -0
+	};
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +72 -0
new file mode 100644
index 0000000..e5c4309
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for NXP LS1028A RDB Board.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a.dtsi"
+
+/ {
+	model = "LS1028A RDB Board";
+	compatible = "fsl,ls1028a-rdb", "fsl,ls1028a";
+
+	aliases {
+		serial0 = &duart0;
+		serial1 = &duart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+	pca9847 at 77 {
+		compatible = "nxp,pca9847";
+		reg = <0x77>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		i2c at 2 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x02>;
+
+			ina220 at 40 {
+				compatible = "ti,ina220";
+				reg = <0x40>;
+				shunt-resistor = <500>;
+			};
+		};
+
+		i2c at 3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x3>;
+
+			sa56004 at 4c {
+				compatible = "nxp,sa56004";
+				reg = <0x4c>;
+			};
+
+			rtc at 51 {
+				compatible = "nxp,pcf2129";
+				reg = <0x51>;
+			};
+		};
+	};
+
+
+};
+
+&duart0 {
+	status = "okay";
+};
+
+&duart1 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +7 -0
new file mode 100644
index 0000000..bc860e2
@@ -0,0 +1,355 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree Include file for NXP Layerscape-1028A family SoC.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 69

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+ *
+ */
+
+	};
+
+	sysclk: sysclk {

clock-sysclk for node name might be better?

Is clock-sysclk: sysclk { ok ?

Quoted 66 lines
Quoted 66 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +65 -0
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <100000000>;
+		clock-output-names = "sysclk";
+	};
+	soc: soc {
+		compatible = "simple-bus";
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		smmu: iommu at 5000000 {
+			compatible = "arm,mmu-500";
+			reg = <0 0x5000000 0 0x800000>;
+			#global-interrupts = <8>;
+			#iommu-cells = <1>;
+			stream-match-mask = <0x7C00>;
+			/* global secure fault */
+			interrupts = <0 13 4>,
+			/* combined secure interrupt */
+				     <0 14 4>,
+			/* global non-secure fault */
+				     <0 15 4>,
+			/* combined non-secure interrupt */
+				     <0 16 4>,
+			/* performance counter interrupts 0-7 */
+				     <0 211 4>, <0 212 4>,
+				     <0 213 4>, <0 214 4>,
+			/* per context interrupt, 64 interrupts */
+				     <0 146 4>, <0 147 4>,
+				     <0 148 4>, <0 149 4>,
+				     <0 150 4>, <0 151 4>,
+				     <0 152 4>, <0 153 4>,
+				     <0 154 4>, <0 155 4>,
+				     <0 156 4>, <0 157 4>,
+				     <0 158 4>, <0 159 4>,
+				     <0 160 4>, <0 161 4>,
+				     <0 162 4>, <0 163 4>,
+				     <0 164 4>, <0 165 4>,
+				     <0 166 4>, <0 167 4>,
+				     <0 168 4>, <0 169 4>,
+				     <0 170 4>, <0 171 4>,
+				     <0 172 4>, <0 173 4>,
+				     <0 174 4>, <0 175 4>,
+				     <0 176 4>, <0 177 4>,
+				     <0 178 4>, <0 179 4>,
+				     <0 180 4>, <0 181 4>,
+				     <0 182 4>, <0 183 4>,
+				     <0 184 4>, <0 185 4>,
+				     <0 186 4>, <0 187 4>,
+				     <0 188 4>, <0 189 4>,
+				     <0 190 4>, <0 191 4>,
+				     <0 192 4>, <0 193 4>,
+				     <0 194 4>, <0 195 4>,
+				     <0 196 4>, <0 197 4>,
+				     <0 198 4>, <0 199 4>,
+				     <0 200 4>, <0 201 4>,
+				     <0 202 4>, <0 203 4>,
+				     <0 204 4>, <0 205 4>,
+				     <0 206 4>, <0 207 4>,
+				     <0 208 4>, <0 209 4>;
+		};
+
+		ddr: memory-controller at 1080000 {
+			compatible = "fsl,qoriq-memory-controller";
Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 190

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+			reg = <0x0 0x1080000 0x0 0x1000>;
+			interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+			big-endian;
+		};
+
+		scfg: scfg at 1fc0000 {

syscon is recommended by device tree spec as the node name.

Is syscon:scfg at 1fc0000 { ok ?

Quoted 9 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 196

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+			compatible = "fsl,ls1028a-scfg", "syscon";
+			reg = <0x0 0x1fc0000 0x0 0x10000>;
+			big-endian;
+		};
+
+		dcfg: dcfg at 1e00000 {

Ditto

Is syscon:dcfg at 1e00000 { ok ?

Quoted 9 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 202

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +6 -0
+			compatible = "fsl,ls1028a-dcfg", "syscon";
+			reg = <0x0 0x1e00000 0x0 0x10000>;
+			big-endian;
+		};
+
+		clockgen: clocking at 1300000 {

clock-controller is recommended by device tree spec as the node name.

Is clock-controller: clocking at 1300000 { ok ?

Quoted 12 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi

Quoted 9 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +9 -0
+			compatible = "fsl,ls1028a-clockgen";
+			reg = <0x0 0x1300000 0x0 0xa0000>;
+			#clock-cells = <2>;
+			clocks = <&sysclk>;
+		};
+
+
+		wdog0: watchdog at 23c0000 {
+			compatible= "arm,armv8-timer";

Why does a watchdog device get a timer compatible?

Quoted 1 line

Shawn

Ok will remove "arm,armv8-timer" and add "fsl,ls1028a-wdt" in compatible property.

Quoted 41 lines
Quoted 25 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +20 -1
+			reg = <0x0 0x23c0000 0x0 0x10000>;
+			interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			big-endian;
+			status = "disabled";
+		};
+
+		sata: sata at 3200000 {
+			compatible = "fsl,ls1028a-ahci";
+			reg = <0x0 0x3200000 0x0 0x10000>,
+				<0x0 0x20140520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
+			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clockgen 4 1>;
+			status = "disabled";
+		};
+
+	};
+};
+
--

1.9.1

Quoted 5 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flist
s.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-

kernel&amp;data=02%7C

Quoted 1 line

01%7CBhaskar.Upadhaya%40nxp.com%7Ce64045be25434453549f08d61140bc b0%7C6

Quoted 1 line

86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636715367139688619&amp; sdata

Quoted 1 line

=hnyzdSymQ1J%2FUwuF2UGfKCm56%2Fh%2FFpSadxvZ3P%2FO%2Ftg%3D&a mp;reserved

Quoted 1 line

=0

#3 lore raw

PATCH 1/1 arm64: dts: Add support for NXP LS1028A SoC

Quoted 22 lines · Bhaskar Upadhaya
Quoted 14 lines

-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Monday, September 3, 2018 7:27 AM
To: Sudhanshu Gupta <[email protected]>
Cc: devicetree at vger.kernel.org; Harninder Rai <[email protected]>; Bhaskar Upadhaya <[email protected]>; stuart.yoder at nxp.com; Leo Li <[email protected]>; oss at buserror.net; linux-arm- kernel at lists.infradead.org
Subject: Re: [PATCH] arm64: dts: Add support for NXP LS1028A SoC

Quoted 2 lines · Sudhanshu Gupta

From: Bhaskar Upadhaya <[email protected]>

Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 43

Quoted 6 lines

LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D cache and 48 KB L1-I cache
+&i2c0 {

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +3 -0
+	status = "okay";
+
+	pca9847 at 77 {

Please have generic node name for the device.

Quoted 1 line

is i2c-mux at 77 ok ?

There are some name suggestions in DeviceTree Specification [1].

Shawn

[1] https://www.devicetree.org/

#4 lore raw

PATCH 1/1 arm64: dts: Add support for NXP LS1028A SoC

In reply to Sudhanshu Gupta
Quoted 137 lines · Sudhanshu Gupta

From: Bhaskar Upadhaya <[email protected]>

LS1028A contains two ARM v8 CortexA72 processor cores with 32 KB L1-D cache and 48 KB L1-I cache

Features summary
Two 32-bit / 64-bit ARM v8 Cortex-A72 CPUs
- Arranged as single clusters of two cores sharing a 1 MB L2 cache
- Speed Up to 1.3 GHz
- Support for cluster power-gating.
Cache coherent interconnect (CCI-400)
- Hardware-managed data coherency
- Up to 400 MHz
32-bit DDR4 SDRAM memory controller with ECC
Two PCIe 3.0 controllers
One serial ATA (SATA 3.0) controller
Two high-speed USB 3.0 controllers with integrated PHY

Following levels of DTSI/DTS files have been created for the LS1028A
SoC family:

- fsl-ls1028a.dtsi:
DTS-Include file for NXP LS1028A SoC.

- fsl-ls1028a-qds.dts:
DTS file for NXP LS1028A QDS board.

- fsl-ls1028a-rdb.dts:
DTS file for NXP LS1028A RDB board

---
 arch/arm64/boot/dts/freescale/Makefile            |   2 +
 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts |  93 ++++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts |  74 +++++
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi    | 355 ++++++++++++++++++++++
 4 files changed, 524 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
arch/arm64/boot/dts/freescale/Makefile +2 -0
index d116144..b33c64a 100644
@@ -3,6 +3,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frwy.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-frdm.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1012a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-qds.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1028a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1043a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls1046a-qds.dtb
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +74 -0
new file mode 100644
index 0000000..586d5cd
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for NXP LS1028A QDS Board.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+/dts-v1/;
+
+#include "fsl-ls1028a.dtsi"
+
+/ {
+       model = "LS1028A QDS Board";
+       compatible = "fsl,ls1028a-qds", "fsl,ls1028a";
+
+       aliases {
+               gpio0 = &gpio1;
+               gpio1 = &gpio2;
+               gpio2 = &gpio3;
+               serial0 = &duart0;
+               serial1 = &duart1;
+       };
+
+       chosen {
+               stdout-path = "serial0:115200n8";
+       };
+};
+
+&duart0 {
+       status = "okay";
+};
+
+&duart1 {
+       status = "okay";
+};
+
+&i2c0 {
+       status = "okay";
+
+       pca9847 at 77 {
+               compatible = "nxp,pca9847";
+               reg = <0x77>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x2>;
+
+                       ina220 at 40 {
+                               compatible = "ti,ina220";
+                               reg = <0x40>;
+                               shunt-resistor = <1000>;
+                       };
+
+                       ina220 at 41 {
+                               compatible = "ti,ina220";
+                               reg = <0x41>;
+                               shunt-resistor = <1000>;
+                       };
+               };
+
+               i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x3>;
+
+                       eeprom at 56 {
+                               compatible = "atmel,24c512";
+                               reg = <0x56>;

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts line 84

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +10 -0
+                       };
+
+                       eeprom at 57 {
+                               compatible = "atmel,24c512";
+                               reg = <0x57>;
+                       };
+
+                       sa56004 at 4c {
+                               compatible = "nxp,sa56004";
+                               reg = <0x4c>;

The binding requires a vcc-supply property which is missing here.

Quoted 116 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts new file +9 -0
+                       };
+
+                       rtc at 51 {
+                               compatible = "nxp,pcf2129";
+                               reg = <0x51>;
+                       };
+               };
+       };
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts new file +74 -0
new file mode 100644
index 0000000..e5c4309
@@ -0,0 +1,74 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree file for NXP LS1028A RDB Board.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+/dts-v1/;
+#include "fsl-ls1028a.dtsi"
+
+/ {
+       model = "LS1028A RDB Board";
+       compatible = "fsl,ls1028a-rdb", "fsl,ls1028a";
+
+       aliases {
+               serial0 = &duart0;
+               serial1 = &duart1;
+       };
+
+       chosen {
+               stdout-path = "serial0:115200n8";
+       };
+};
+
+&i2c0 {
+       status = "okay";
+       pca9847 at 77 {
+               compatible = "nxp,pca9847";
+               reg = <0x77>;
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x02>;
+
+                       ina220 at 40 {
+                               compatible = "ti,ina220";
+                               reg = <0x40>;
+                               shunt-resistor = <500>;
+                       };
+               };
+
+               i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x3>;
+
+                       sa56004 at 4c {
+                               compatible = "nxp,sa56004";
+                               reg = <0x4c>;
+                       };
+
+                       rtc at 51 {
+                               compatible = "nxp,pcf2129";
+                               reg = <0x51>;
+                       };
+               };
+       };
+
+
+};
+
+&duart0 {
+       status = "okay";
+};
+
+&duart1 {
+       status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +21 -0
new file mode 100644
index 0000000..bc860e2
@@ -0,0 +1,355 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Device Tree Include file for NXP Layerscape-1028A family SoC.
+ *
+ * Copyright 2018 NXP
+ *
+ * Harninder Rai <[email protected]>
+ *
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+       compatible = "fsl,ls1028a";
+       interrupt-parent = <&gic>;
+       #address-cells = <2>;
+       #size-cells = <2>;
+
+       cpus {
+               #address-cells = <1>;

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 31

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+               #size-cells = <0>;
+
+               cpu0: cpu at 0 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a72";
+                       reg = <0x0>;
+                       clocks = <&clockgen 1 0>;
+                       next-level-cache = <&l2>;
+                       cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;

enable-method property is required.
#cooling-cells is not needed as you don't define the cooling device.

Quoted 45 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +45 -0
+               };
+
+               cpu1: cpu at 1 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a72";
+                       reg = <0x1>;
+                       clocks = <&clockgen 1 0>;
+                       next-level-cache = <&l2>;
+                       cpu-idle-states = <&CPU_PH20>;
+               };
+
+               l2: l2-cache {
+                       compatible = "cache";
+               };
+       };
+
+       idle-states {
+               /*
+                * PSCI node is not added default, U-boot will add missing
+                * parts if it determines to use PSCI.
+                */
+               entry-method = "arm,psci";
+
+               CPU_PH20: cpu-ph20 {
+                       compatible = "arm,idle-state";
+                       idle-state-name = "PH20";
+                       arm,psci-suspend-param = <0x00010000>;
+                       entry-latency-us = <1000>;
+                       exit-latency-us = <1000>;
+                       min-residency-us = <3000>;
+               };
+       };
+
+       memory at 80000000 {
+               device_type = "memory";
+       };
+
+       sysclk: sysclk {
+               compatible = "fixed-clock";
+               #clock-cells = <0>;
+               clock-frequency = <100000000>;
+               clock-output-names = "sysclk";
+       };
+
+       reboot {

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 86

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+               compatible ="syscon-reboot";
+               regmap = <&dcfg>;
+               offset = <0xb0>;
+               mask = <0x02>;
+               status = "disabled";
+       };
+
+       timer {
+               compatible = "arm,armv8-timer";
+               interrupts = <GIC_PPI 13 (GIC_CPU_MASK_RAW(0xf) |

Probably GIC_CPU_MASK_SIMPLE(2) as you only have two cores. The same for all the PPI interrupts below.

Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +5 -0
+                                         IRQ_TYPE_LEVEL_LOW)>,
+                            <GIC_PPI 14 (GIC_CPU_MASK_RAW(0xf) |
+                                         IRQ_TYPE_LEVEL_LOW)>,
+                            <GIC_PPI 11 (GIC_CPU_MASK_RAW(0xf) |
+                                         IRQ_TYPE_LEVEL_LOW)>,

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 101

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+                            <GIC_PPI 10 (GIC_CPU_MASK_RAW(0xf) |
+                                         IRQ_TYPE_LEVEL_LOW)>;
+       };
+
+       pmu {
+               compatible = "arm,cortex-a72-pmu";
+               interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+                            <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+                            <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>,
+                            <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;

The binding says one interrupt per core, why we are having 4 interrupts here.

Quoted 105 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +105 -0
+               interrupt-affinity = <&cpu0>,
+                                    <&cpu1>;
+               status = "disabled";
+       };
+
+       gic: interrupt-controller at 6000000 {
+               compatible= "arm,gic-v3";
+               #address-cells = <2>;
+               #size-cells = <2>;
+               ranges;
+               reg= <0x0 0x06000000 0 0x10000>, /* GIC Dist */
+                       <0x0 0x06040000 0 0x40000>; /* GIC Redistributor */
+               #interrupt-cells= <3>;
+               interrupt-controller;
+               interrupts = <GIC_PPI 9 (GIC_CPU_MASK_RAW(0xf) |
+                                        IRQ_TYPE_LEVEL_LOW)>;
+               its:gic-its at 6020000 {
+                       compatible = "arm,gic-v3-its";
+                       msi-controller;
+                       reg = <0x0 0x06020000 0 0x20000>;/* GIC Translater */
+               };
+       };
+
+       soc: soc {
+               compatible = "simple-bus";
+               #address-cells = <2>;
+               #size-cells = <2>;
+               ranges;
+
+               smmu: iommu at 5000000 {
+                       compatible = "arm,mmu-500";
+                       reg = <0 0x5000000 0 0x800000>;
+                       #global-interrupts = <8>;
+                       #iommu-cells = <1>;
+                       stream-match-mask = <0x7C00>;
+                       /* global secure fault */
+                       interrupts = <0 13 4>,
+                       /* combined secure interrupt */
+                                    <0 14 4>,
+                       /* global non-secure fault */
+                                    <0 15 4>,
+                       /* combined non-secure interrupt */
+                                    <0 16 4>,
+                       /* performance counter interrupts 0-7 */
+                                    <0 211 4>, <0 212 4>,
+                                    <0 213 4>, <0 214 4>,
+                       /* per context interrupt, 64 interrupts */
+                                    <0 146 4>, <0 147 4>,
+                                    <0 148 4>, <0 149 4>,
+                                    <0 150 4>, <0 151 4>,
+                                    <0 152 4>, <0 153 4>,
+                                    <0 154 4>, <0 155 4>,
+                                    <0 156 4>, <0 157 4>,
+                                    <0 158 4>, <0 159 4>,
+                                    <0 160 4>, <0 161 4>,
+                                    <0 162 4>, <0 163 4>,
+                                    <0 164 4>, <0 165 4>,
+                                    <0 166 4>, <0 167 4>,
+                                    <0 168 4>, <0 169 4>,
+                                    <0 170 4>, <0 171 4>,
+                                    <0 172 4>, <0 173 4>,
+                                    <0 174 4>, <0 175 4>,
+                                    <0 176 4>, <0 177 4>,
+                                    <0 178 4>, <0 179 4>,
+                                    <0 180 4>, <0 181 4>,
+                                    <0 182 4>, <0 183 4>,
+                                    <0 184 4>, <0 185 4>,
+                                    <0 186 4>, <0 187 4>,
+                                    <0 188 4>, <0 189 4>,
+                                    <0 190 4>, <0 191 4>,
+                                    <0 192 4>, <0 193 4>,
+                                    <0 194 4>, <0 195 4>,
+                                    <0 196 4>, <0 197 4>,
+                                    <0 198 4>, <0 199 4>,
+                                    <0 200 4>, <0 201 4>,
+                                    <0 202 4>, <0 203 4>,
+                                    <0 204 4>, <0 205 4>,
+                                    <0 206 4>, <0 207 4>,
+                                    <0 208 4>, <0 209 4>;
+               };
+
+               ddr: memory-controller at 1080000 {
+                       compatible = "fsl,qoriq-memory-controller";
+                       reg = <0x0 0x1080000 0x0 0x1000>;
+                       interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+                       big-endian;
+               };
+
+               scfg: scfg at 1fc0000 {
+                       compatible = "fsl,ls1028a-scfg", "syscon";
+                       reg = <0x0 0x1fc0000 0x0 0x10000>;
+                       big-endian;
+               };
+
+               dcfg: dcfg at 1e00000 {
+                       compatible = "fsl,ls1028a-dcfg", "syscon";
+                       reg = <0x0 0x1e00000 0x0 0x10000>;
+                       big-endian;
+               };
+
+               clockgen: clocking at 1300000 {
+                       compatible = "fsl,ls1028a-clockgen";
+                       reg = <0x0 0x1300000 0x0 0xa0000>;
+                       #clock-cells = <2>;
+                       clocks = <&sysclk>;

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 216

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+               };
+
+               i2c0: i2c at 2000000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2000000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       dma-names = "tx", "rx";

You don't define dmas here why you add dma-names? And you only added this in the first i2c node.

Quoted 68 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +68 -0
+                       status = "disabled";
+               };
+
+               i2c1: i2c at 2010000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2010000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c2: i2c at 2020000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2020000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c3: i2c at 2030000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2030000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c4: i2c at 2040000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2040000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c5: i2c at 2050000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2050000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c6: i2c at 2060000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2060000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               i2c7: i2c at 2070000 {
+                       compatible = "fsl,vf610-i2c";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0x0 0x2070000 0x0 0x10000>;

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 294

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +10 -0
+                       interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+               duart0: serial at 21c0500 {
+                       compatible = "fsl,ns16550", "ns16550a";
+                       reg = <0x00 0x21c0500 0x0 0x100>;
+                       interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;

Should be disabled by default? As you enabled it in board dts.

arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi line 301

Quoted 7 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +7 -0
+               };
+
+               duart1: serial at 21c0600 {
+                       compatible = "fsl,ns16550", "ns16550a";
+                       reg = <0x00 0x21c0600 0x0 0x100>;
+                       interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;

Should be disabled by default? As you enabled it in board dts.

Quoted 57 lines
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi new file +54 -1
+               };
+
+               gpio1: gpio at 2300000 {
+                       compatible = "fsl,qoriq-gpio";
+                       reg = <0x0 0x2300000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
+                       gpio-controller;
+                       #gpio-cells = <2>;
+                       interrupt-controller;
+                       #interrupt-cells = <2>;
+               };
+
+               gpio2: gpio at 2310000 {
+                       compatible = "fsl,qoriq-gpio";
+                       reg = <0x0 0x2310000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
+                       gpio-controller;
+                       #gpio-cells = <2>;
+                       interrupt-controller;
+                       #interrupt-cells = <2>;
+               };
+
+               gpio3: gpio at 2320000 {
+                       compatible = "fsl,qoriq-gpio";
+                       reg = <0x0 0x2320000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
+                       gpio-controller;
+                       #gpio-cells = <2>;
+                       interrupt-controller;
+                       #interrupt-cells = <2>;
+               };
+
+               wdog0: watchdog at 23c0000 {
+                       compatible= "arm,armv8-timer";
+                       reg = <0x0 0x23c0000 0x0 0x10000>;
+                       interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       big-endian;
+                       status = "disabled";
+               };
+
+               sata: sata at 3200000 {
+                       compatible = "fsl,ls1028a-ahci";
+                       reg = <0x0 0x3200000 0x0 0x10000>,
+                               <0x0 0x20140520 0x0 0x4>;
+                       reg-names = "ahci", "sata-ecc";
+                       interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&clockgen 4 1>;
+                       status = "disabled";
+               };
+
+       };
+};
+
--

1.9.1