Skip to contentSkip to conversation

drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl

PATCH In review Mika Kuoppala 4 participants 5 messages Sep 25, 2018 – Sep 26, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl

Using fbc with VT-d flickers also on kbl and cfl.

Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc <[email protected]> # v4.9+
---
 drivers/gpu/drm/i915/intel_fbc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_fbc.c +3 -2
index 74d425c700ef..a149f08c1b79 100644
@@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 
 static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
+	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */
 	if (intel_vtd_active() &&
-	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) {
+	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) ||
+	     IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) {
 		DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n");
 		return true;
 	}
Signature · 1 line
2.17.1
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl

== Series Details ==

== Series Details ==

Series: drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl
URL : https://patchwork.freedesktop.org/series/50147/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4874 -> Patchwork_10278 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10278 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10278, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/50147/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10278:

=== IGT changes ===

    ==== Possible regressions ====

    igt@core_prop_blob@basic:
      fi-kbl-7560u:       PASS -> INCOMPLETE

== Known issues ==

Here are the changes found in Patchwork_10278 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload:
      fi-blb-e6850:       INCOMPLETE (fdo#107718) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-cfl-8109u:       INCOMPLETE (fdo#106070) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-cnl-u:           FAIL (fdo#107336) -> PASS

fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718

== Participating hosts (48 -> 42) ==

Additional (1): fi-skl-6700hq
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_4874 -> Patchwork_10278

CI_DRM_4874: 7bb42432ef1cc63b4a6a223e19455f6c4f9a1538 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4649: 19b0c74d20d9b53d4c82be14af0909a3b6846010 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10278: c69ec0b36f565adb6cefa42cb51ca1a64f91bb1d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c69ec0b36f56 drm/i915/fbc: Disable fbc with VT-d also with kbl and cfl

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10278/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Mika Kuoppala
Quoted 17 lines · Mika Kuoppala

Using fbc with VT-d flickers also on kbl and cfl.

Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc <[email protected]> # v4.9+
---
 drivers/gpu/drm/i915/intel_fbc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_fbc.c +0 -0
index 74d425c700ef..a149f08c1b79 100644

drivers/gpu/drm/i915/intel_fbc.c static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) · line 1278

Quoted 5 lines
drivers/gpu/drm/i915/intel_fbc.c +1 -1
@@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 
 static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
+	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */

The hsds seem to be saying that this was fixed in kbl/cnl. I guess the flicker could be due to a different vt-d vs. fbc issue.

Is the chicken bit in CHICKEN_PIPESL in the correct position?

Hmm. Bspec doesn't list chicken bit for glk. That would seem to suggest that we need this w/a for glk as well.

Quoted 9 lines
drivers/gpu/drm/i915/intel_fbc.c +2 -1
 	if (intel_vtd_active() &&
-	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) {
+	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) ||
+	     IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) {
 		DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n");
 		return true;
 	}
Signature · 1 line
2.17.1
Signature · 2 lines
Ville Syrjälä
Intel
#3 lore raw
Quoted 19 lines · Ville Syrjälä
Quoted 18 lines · Mika Kuoppala

Using fbc with VT-d flickers also on kbl and cfl.

Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc <[email protected]> # v4.9+
---
 drivers/gpu/drm/i915/intel_fbc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_fbc.c +0 -0
index 74d425c700ef..a149f08c1b79 100644
@@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 
Quoted 8 lines

drivers/gpu/drm/i915/intel_fbc.c static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) · line 1278

Quoted 4 lines
drivers/gpu/drm/i915/intel_fbc.c +1 -1
 static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
+	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */

The hsds seem to be saying that this was fixed in kbl/cnl. I guess the flicker could be due to a different vt-d vs. fbc issue.

I was trusting the wa database on this one.

Quoted 1 line

Is the chicken bit in CHICKEN_PIPESL in the correct position?

Yes it is zero.

Quoted 3 lines

Hmm. Bspec doesn't list chicken bit for glk. That would seem to suggest that we need this w/a for glk as well.

Agreed. The questio is that should we follow bspec and logic or leave it until we get a report if it is a problem?

cfl is close enough|similar in this respect that we mimic kbl with it?

Thanks,
-Mika

Quoted 14 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_fbc.c +2 -1
 	if (intel_vtd_active() &&
-	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) {
+	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) ||
+	     IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) {
 		DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n");
 		return true;
 	}
Signature · 1 line
2.17.1
Signature · 2 lines
Ville Syrjälä
Intel
maintainer
#4 lore raw
Quoted 30 lines · Mika Kuoppala
Quoted 19 lines · Ville Syrjälä
Quoted 18 lines · Mika Kuoppala

Using fbc with VT-d flickers also on kbl and cfl.

Cc Paulo Zanoni <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Chris Wilson <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc <[email protected]> # v4.9+
---
 drivers/gpu/drm/i915/intel_fbc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_fbc.c +0 -0
index 74d425c700ef..a149f08c1b79 100644
@@ -1275,9 +1275,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv)
 
Quoted 8 lines

drivers/gpu/drm/i915/intel_fbc.c static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) · line 1278

Quoted 4 lines
drivers/gpu/drm/i915/intel_fbc.c +1 -1
 static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv)
 {
-	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */
+	/* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,kbl,cfl */

The hsds seem to be saying that this was fixed in kbl/cnl. I guess the flicker could be due to a different vt-d vs. fbc issue.

Quoted 1 line

I was trusting the wa database on this one.

I believe it would be worth to trust the wa_database, but this database can be tricky too...

Like on this case it is listed for KBL, but A0 only and not listed for CFL.

Quoted 6 lines
Quoted 2 lines

Is the chicken bit in CHICKEN_PIPESL in the correct position?

Yes it is zero.

Quoted 1 line
Quoted 8 lines
Quoted 2 lines

Hmm. Bspec doesn't list chicken bit for glk. That would seem to suggest that we need this w/a for glk as well.

Agreed. The questio is that should we follow bspec and logic or leave it until we get a report if it is a problem?

cfl is close enough|similar in this respect that we mimic kbl with it?

yes, we can safely consider it is similar to latest steppings of KBL.

Quoted 18 lines

Thanks,
-Mika

Quoted 14 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_fbc.c +2 -1
 	if (intel_vtd_active() &&
-	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) {
+	    (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv) ||
+	     IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv))) {
 		DRM_INFO("Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n");
 		return true;
 	}
Signature · 1 line
2.17.1
Signature · 2 lines
Ville Syrjälä
Intel