Skip to contentSkip to conversation

Add API to retrieve the Bluetooth Device Address (BD_ADDR)

PATCH In review Matthias Kaehlcke 5 participants 13 messages Sep 25, 2018 – Sep 27, 2018

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

cover Add API to retrieve the Bluetooth Device Address (BD_ADDR)

(previous v3 post was messed up, resending as v3.1 with the correct stack)

On some systems the Bluetooth Device Address (BD_ADDR) isn't stored on the Bluetooth chip itself. One way to configure the BD address is through the device tree. The btqcomsmd driver is an example, it can read the BD address from the DT property 'local-bd-address'. It is also planned to extend the hci_qca driver to support setting the BD address through the DT.

To avoid redundant open-coded reading of 'local-bd-address' and error handling this series adds an API to retrieve the BD address of a device and adapts the btqcomsmd driver to use this API.

Matthias Kaehlcke (2):
device property: Add device_get_bd_address() and
fwnode_get_bd_address()
Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

 drivers/base/property.c           | 46 +++++++++++++++++++++++++++++++
 drivers/bluetooth/btqcomsmd.c     |  4 +--
 include/linux/property.h          | 18 ++++++++++++
 include/linux/types.h             |  5 ++++
 include/net/bluetooth/bluetooth.h |  5 ----
 5 files changed, 70 insertions(+), 8 deletions(-)
Signature · 1 line
2.19.0.605.g01d371f741-goog
#1 lore raw

PATCH 1/2 device property: Add device_get_bd_address() and fwnode_get_bd_address()

Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property.

The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to include (the mostly unrelated) bluetooth.h

---
Changes in v3:
- move definition of bdaddr_t to types.h to avoid include of bluetooth.h from property.h
- add stubs for the new functions

Changes in v2:
- use bdaddr_t instead of byte pointer + len
- use EXPORT_SYMBOL_GPL for the new functions instead of EXPORT_SYMBOL
- put new functions inside #if IS_ENABLED(CONFIG_BT)
- some new line juggling in property.h
- added 'Reviewed-by: Andy Shevchenko <[email protected]>' tag

---
 drivers/base/property.c           | 46 +++++++++++++++++++++++++++++++
 include/linux/property.h          | 18 ++++++++++++
 include/linux/types.h             |  5 ++++
 include/net/bluetooth/bluetooth.h |  5 ----
 4 files changed, 69 insertions(+), 5 deletions(-)
drivers/base/property.c +46 -0
index 240ab5230ff6..afe412133188 100644
@@ -1315,6 +1315,52 @@ void *device_get_mac_address(struct device *dev, char *addr, int alen)
 }
 EXPORT_SYMBOL(device_get_mac_address);
 
+#if IS_ENABLED(CONFIG_BT)
+
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_bd_address);
+
+/**
+ * device_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) for a
+ *                         given device
+ * @dev:	Pointer to the device
+ * @bd_addr:	Pointer to struct to store the BD address in
+ */
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr)
+{
+	return fwnode_get_bd_address(dev_fwnode(dev), bd_addr);
+}
+EXPORT_SYMBOL_GPL(device_get_bd_address);
+
+#endif
+
 /**
  * fwnode_irq_get - Get IRQ directly from a fwnode
  * @fwnode:	Pointer to the firmware node
include/linux/property.h +18 -0
index ac8a1ebc4c1b..5df4e0bd8c83 100644
@@ -286,10 +286,28 @@ const void *device_get_match_data(struct device *dev);
 int device_get_phy_mode(struct device *dev);
 
 void *device_get_mac_address(struct device *dev, char *addr, int alen);
+#if IS_ENABLED(CONFIG_BT)
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
+#else
+static inline int device_get_bd_address(struct device *dev,
+					bdaddr_t *bd_addr)
+{
+	return -ENOTSUPP;
+}
+#endif
 
 int fwnode_get_phy_mode(struct fwnode_handle *fwnode);
 void *fwnode_get_mac_address(struct fwnode_handle *fwnode,
 			     char *addr, int alen);
+#if IS_ENABLED(CONFIG_BT)
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr);
+#else
+static inline int fwnode_get_bd_address(struct fwnode_handle *fwnode,
+					bdaddr_t *bd_addr)
+{
+	return -ENOTSUPP;
+}
+#endif
 struct fwnode_handle *fwnode_graph_get_next_endpoint(
 	const struct fwnode_handle *fwnode, struct fwnode_handle *prev);
 struct fwnode_handle *
include/linux/types.h +5 -0
index 9834e90aa010..ff6984a00a3b 100644
@@ -230,5 +230,10 @@ struct callback_head {
 typedef void (*rcu_callback_t)(struct rcu_head *head);
 typedef void (*call_rcu_func_t)(struct rcu_head *head, rcu_callback_t func);
 
+/* Bluetooth Device Address (BD_ADDR) */
+typedef struct {
+	__u8 b[6];
+} __packed bdaddr_t;
+
 #endif /*  __ASSEMBLY__ */
 #endif /* _LINUX_TYPES_H */
include/net/bluetooth/bluetooth.h +0 -5
index ec9d6bc65855..9401c7431a8f 100644
@@ -190,11 +190,6 @@ static inline const char *state_to_string(int state)
 	return "invalid state";
 }
 
-/* BD Address */
-typedef struct {
-	__u8 b[6];
-} __packed bdaddr_t;
-
 /* BD Address type */
 #define BDADDR_BREDR		0x00
 #define BDADDR_LE_PUBLIC	0x01
Signature · 1 line
2.19.0.605.g01d371f741-goog
reviewer Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

Hi Matthias,

Quoted 47 lines · Matthias Kaehlcke

Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property.

The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to include (the mostly unrelated) bluetooth.h

---
Changes in v3:
- move definition of bdaddr_t to types.h to avoid include of bluetooth.h from property.h
- add stubs for the new functions

Changes in v2:
- use bdaddr_t instead of byte pointer + len
- use EXPORT_SYMBOL_GPL for the new functions instead of EXPORT_SYMBOL
- put new functions inside #if IS_ENABLED(CONFIG_BT)
- some new line juggling in property.h
- added 'Reviewed-by: Andy Shevchenko <[email protected]>' tag

---
 drivers/base/property.c           | 46 +++++++++++++++++++++++++++++++
 include/linux/property.h          | 18 ++++++++++++
 include/linux/types.h             |  5 ++++
 include/net/bluetooth/bluetooth.h |  5 ----
 4 files changed, 69 insertions(+), 5 deletions(-)
drivers/base/property.c +11 -0
index 240ab5230ff6..afe412133188 100644
@@ -1315,6 +1315,52 @@ void *device_get_mac_address(struct device *dev, char *addr, int alen)
 }
 EXPORT_SYMBOL(device_get_mac_address);
 
+#if IS_ENABLED(CONFIG_BT)
+
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1338

Quoted 10 lines
drivers/base/property.c +10 -0
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));

sizeof(ba)

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1344

Quoted 6 lines
drivers/base/property.c +6 -0
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));

How about simply:

	*bd_addr = ba;

Either way,

Quoted 86 lines
drivers/base/property.c +19 -0
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_bd_address);
+
+/**
+ * device_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) for a
+ *                         given device
+ * @dev:	Pointer to the device
+ * @bd_addr:	Pointer to struct to store the BD address in
+ */
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr)
+{
+	return fwnode_get_bd_address(dev_fwnode(dev), bd_addr);
+}
+EXPORT_SYMBOL_GPL(device_get_bd_address);
+
+#endif
+
 /**
  * fwnode_irq_get - Get IRQ directly from a fwnode
  * @fwnode:	Pointer to the firmware node
include/linux/property.h +18 -0
index ac8a1ebc4c1b..5df4e0bd8c83 100644
@@ -286,10 +286,28 @@ const void *device_get_match_data(struct device *dev);
 int device_get_phy_mode(struct device *dev);
 
 void *device_get_mac_address(struct device *dev, char *addr, int alen);
+#if IS_ENABLED(CONFIG_BT)
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr);
+#else
+static inline int device_get_bd_address(struct device *dev,
+					bdaddr_t *bd_addr)
+{
+	return -ENOTSUPP;
+}
+#endif
 
 int fwnode_get_phy_mode(struct fwnode_handle *fwnode);
 void *fwnode_get_mac_address(struct fwnode_handle *fwnode,
 			     char *addr, int alen);
+#if IS_ENABLED(CONFIG_BT)
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr);
+#else
+static inline int fwnode_get_bd_address(struct fwnode_handle *fwnode,
+					bdaddr_t *bd_addr)
+{
+	return -ENOTSUPP;
+}
+#endif
 struct fwnode_handle *fwnode_graph_get_next_endpoint(
 	const struct fwnode_handle *fwnode, struct fwnode_handle *prev);
 struct fwnode_handle *
include/linux/types.h +5 -0
index 9834e90aa010..ff6984a00a3b 100644
@@ -230,5 +230,10 @@ struct callback_head {
 typedef void (*rcu_callback_t)(struct rcu_head *head);
 typedef void (*call_rcu_func_t)(struct rcu_head *head, rcu_callback_t func);
 
+/* Bluetooth Device Address (BD_ADDR) */
+typedef struct {
+	__u8 b[6];
+} __packed bdaddr_t;
+
 #endif /*  __ASSEMBLY__ */
 #endif /* _LINUX_TYPES_H */
include/net/bluetooth/bluetooth.h +0 -5
index ec9d6bc65855..9401c7431a8f 100644
@@ -190,11 +190,6 @@ static inline const char *state_to_string(int state)
 	return "invalid state";
 }
 
-/* BD Address */
-typedef struct {
-	__u8 b[6];
-} __packed bdaddr_t;
-
 /* BD Address type */
 #define BDADDR_BREDR		0x00
 #define BDADDR_LE_PUBLIC	0x01
Signature · 4 lines
Kind regards,

Sakari Ailus
[email protected]
#3 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

Hi Sakari,

thanks for the reviews

Quoted 72 lines · Sakari Ailus

Hi Matthias,

Quoted 47 lines · Matthias Kaehlcke

Provide an API for Bluetooth drivers to retrieve the Bluetooth Device address (BD_ADDR) for a device. If the device node has a property 'local-bd-address' the BD address is read from this property.

The definition of bdaddr_t is moved to types.h to make it visible in property.h without having to include (the mostly unrelated) bluetooth.h

---
Changes in v3:
- move definition of bdaddr_t to types.h to avoid include of bluetooth.h from property.h
- add stubs for the new functions

Changes in v2:
- use bdaddr_t instead of byte pointer + len
- use EXPORT_SYMBOL_GPL for the new functions instead of EXPORT_SYMBOL
- put new functions inside #if IS_ENABLED(CONFIG_BT)
- some new line juggling in property.h
- added 'Reviewed-by: Andy Shevchenko <[email protected]>' tag

---
 drivers/base/property.c           | 46 +++++++++++++++++++++++++++++++
 include/linux/property.h          | 18 ++++++++++++
 include/linux/types.h             |  5 ++++
 include/net/bluetooth/bluetooth.h |  5 ----
 4 files changed, 69 insertions(+), 5 deletions(-)
drivers/base/property.c +11 -0
index 240ab5230ff6..afe412133188 100644
@@ -1315,6 +1315,52 @@ void *device_get_mac_address(struct device *dev, char *addr, int alen)
 }
 EXPORT_SYMBOL(device_get_mac_address);
 
+#if IS_ENABLED(CONFIG_BT)
+
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1338

Quoted 10 lines
drivers/base/property.c +10 -0
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));

sizeof(ba)

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1344

Quoted 6 lines
drivers/base/property.c +6 -0
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));

How about simply:

Quoted 5 lines
	*bd_addr = ba;

Either way,

Thanks I'll address your comments in v4. I'll wait a day or two before re-spinning for if others have additional feedback.

Cheers

Matthias

#4 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

In reply to Matthias Kaehlcke
Quoted 31 lines · Matthias Kaehlcke
drivers/base/property.c +31 -0
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_bd_address);
+
+/**

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1360

Quoted 10 lines
drivers/base/property.c +10 -0
+ * device_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) for a
+ *                         given device
+ * @dev:	Pointer to the device
+ * @bd_addr:	Pointer to struct to store the BD address in
+ */
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr)
+{
+	return fwnode_get_bd_address(dev_fwnode(dev), bd_addr);
+}
+EXPORT_SYMBOL_GPL(device_get_bd_address);

Let's not fill property.c with framework specific helper functions any more!

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

Thanks,

Signature · 1 line
heikki
#5 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

Quoted 9 lines · Heikki Krogerus

On Tue, Sep 25, 2018 at 12:10:13PM -0700, Matthias Kaehlcke wrote:

Let's not fill property.c with framework specific helper functions any more!

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

Actually good point.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

In reply to Heikki Krogerus
Quoted 46 lines · Heikki Krogerus
Quoted 31 lines · Matthias Kaehlcke
drivers/base/property.c +31 -0
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_bd_address);
+
+/**

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1360

Quoted 10 lines
drivers/base/property.c +10 -0
+ * device_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) for a
+ *                         given device
+ * @dev:	Pointer to the device
+ * @bd_addr:	Pointer to struct to store the BD address in
+ */
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr)
+{
+	return fwnode_get_bd_address(dev_fwnode(dev), bd_addr);
+}
+EXPORT_SYMBOL_GPL(device_get_bd_address);

Let's not fill property.c with framework specific helper functions any more!

Quoted 3 lines

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

You have a point, I'll see if I can find a better place.

Thanks

Matthias

maintainer
#7 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

In reply to Heikki Krogerus

Hi Heikki,

Quoted 45 lines
Quoted 31 lines
drivers/base/property.c +31 -0
+/**
+ * fwnode_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) from the
+ *                         firmware node
+ * @fwnode:	Pointer to the firmware node
+ * @bd_addr:	Pointer to struct to store the BD address in
+ *
+ * Search the firmware node for 'local-bd-address'.
+ *
+ * All-zero BD addresses are rejected, because those could be properties
+ * that exist in the firmware tables, but were not updated by the firmware. For
+ * example, the DTS could define 'local-bd-address', with zero BD addresses.
+ */
+int fwnode_get_bd_address(struct fwnode_handle *fwnode, bdaddr_t *bd_addr)
+{
+	bdaddr_t ba;
+	int ret;
+
+	ret = fwnode_property_read_u8_array(fwnode, "local-bd-address",
+					    (u8 *)&ba, sizeof(bdaddr_t));
+	if (ret < 0)
+		return ret;
+	if (is_zero_ether_addr((u8 *)&ba))
+		return -ENODATA;
+
+	memcpy(bd_addr, &ba, sizeof(bdaddr_t));
+
+	return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_bd_address);
+
+/**

drivers/base/property.c void *device_get_mac_address(struct device *dev, char *addr, int alen) · line 1360

Quoted 10 lines
drivers/base/property.c +10 -0
+ * device_get_bd_address - Get the Bluetooth Device Address (BD_ADDR) for a
+ *                         given device
+ * @dev:	Pointer to the device
+ * @bd_addr:	Pointer to struct to store the BD address in
+ */
+int device_get_bd_address(struct device *dev, bdaddr_t *bd_addr)
+{
+	return fwnode_get_bd_address(dev_fwnode(dev), bd_addr);
+}
+EXPORT_SYMBOL_GPL(device_get_bd_address);

Let's not fill property.c with framework specific helper functions any more!

Quoted 3 lines

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

so? The firmware guys decided to put MAC addresses and BD addresses into the firmware. So you have to deal with that.

Moving this into the Bluetooth subsystem is as pointless. I rather keep the accessor function to firmware specific data in one place and not spread around the whole tree. Especially once this is also provided via ACPI or some other means. I assumed that is what the whole device_get part was suppose to abstract.

Regards

Marcel

#8 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

Hi Marcel,

Quoted 9 lines · Marcel Holtmann
Quoted 6 lines

Let's not fill property.c with framework specific helper functions any more!

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

so? The firmware guys decided to put MAC addresses and BD addresses into the firmware. So you have to deal with that.

I think you have misunderstood the point.

Quoted 5 lines

Moving this into the Bluetooth subsystem is as pointless. I rather keep the accessor function to firmware specific data in one place and not spread around the whole tree. Especially once this is also provided via ACPI or some other means. I assumed that is what the whole device_get part was suppose to abstract.

Unified device property API defines a _generic_ API that can be used by any type of device to access the device properties regardless of the way the hardware is described.

Any device can use device_property_read_u8/u16/u32/u64/string() functions, but only bluetooth devices can use device_get_bd_address(). Therefore that function does not belong to drivers/base/properties.c.

Thanks,

Signature · 1 line
heikki
reviewer
#9 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

Hi guys,

Quoted 21 lines · Heikki Krogerus

Hi Marcel,

Quoted 9 lines · Marcel Holtmann
Quoted 6 lines

Let's not fill property.c with framework specific helper functions any more!

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

so? The firmware guys decided to put MAC addresses and BD addresses into the firmware. So you have to deal with that.

I think you have misunderstood the point.

Quoted 5 lines

Moving this into the Bluetooth subsystem is as pointless. I rather keep the accessor function to firmware specific data in one place and not spread around the whole tree. Especially once this is also provided via ACPI or some other means. I assumed that is what the whole device_get part was suppose to abstract.

Quoted 7 lines

Unified device property API defines a _generic_ API that can be used by any type of device to access the device properties regardless of the way the hardware is described.

Any device can use device_property_read_u8/u16/u32/u64/string() functions, but only bluetooth devices can use device_get_bd_address(). Therefore that function does not belong to drivers/base/properties.c.

FWIW, what's been relevant for V4L2 devices has always been parsed within the V4L2 framework. It's way more than needed by BT here though; see:

	drivers/media/v4l2-core/v4l2-fwnode.c

I wouldn't think of putting this under drivers/base.

Signature · 4 lines
Regards,

Sakari Ailus
[email protected]
#10 lore raw

Re: [PATCH v3.1 1/2] device property: Add device_get_bd_address() and fwnode_get_bd_address()

In reply to Heikki Krogerus
Quoted 21 lines · Heikki Krogerus

Hi Marcel,

Quoted 9 lines · Marcel Holtmann
Quoted 6 lines

Let's not fill property.c with framework specific helper functions any more!

Those functions are completely bluetooth specific, so they do not belong here. The fact that some other framework already managed to slip their helpers in does not justify others to do the same.

so? The firmware guys decided to put MAC addresses and BD addresses into the firmware. So you have to deal with that.

I think you have misunderstood the point.

Quoted 5 lines

Moving this into the Bluetooth subsystem is as pointless. I rather keep the accessor function to firmware specific data in one place and not spread around the whole tree. Especially once this is also provided via ACPI or some other means. I assumed that is what the whole device_get part was suppose to abstract.

Quoted 7 lines

Unified device property API defines a _generic_ API that can be used by any type of device to access the device properties regardless of the way the hardware is described.

Any device can use device_property_read_u8/u16/u32/u64/string() functions, but only bluetooth devices can use device_get_bd_address(). Therefore that function does not belong to drivers/base/properties.c.

Initially property.[ch] seemed the correct place to me since the device_get_bd_address() is the equivalent to device_get_mac_address(), which lives there. However I doubted to use bdaddr_t in the interface when I noticed that the other functions only use generic data types. Not a red flag but a first hint that it's probably not the right place for Bluetooth specific functions. I agree with Heikki that the Bluetooth subsystem seems a better home for this API.

Cheers

Matthias

#11 lore raw

PATCH 2/2 Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

In reply to Matthias Kaehlcke

Use the new API to get the BD address instead of reading it directly from the device tree.

Also remove an unncessary pair of braces in the same area of code.

---
Changes in v3:
- added 'Reviewed-by: Andy Shevchenko <[email protected]>' tag

Changes in v2:
- pass bdaddr_t instead of byte pointer + len

---
 drivers/bluetooth/btqcomsmd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/bluetooth/btqcomsmd.c +1 -3
index 7df3eed1ef5e..ff74d2c46991 100644
@@ -172,11 +172,9 @@ static int btqcomsmd_probe(struct platform_device *pdev)
 	/* The local-bd-address property is usually injected by the
 	 * bootloader which has access to the allocated BD address.
 	 */
-	if (!of_property_read_u8_array(pdev->dev.of_node, "local-bd-address",
-				       (u8 *)&btq->bdaddr, sizeof(bdaddr_t))) {
+	if (!device_get_bd_address(&pdev->dev, &btq->bdaddr))
 		dev_info(&pdev->dev, "BD address %pMR retrieved from device-tree",
 			 &btq->bdaddr);
-	}
 
 	hdev = hci_alloc_dev();
 	if (!hdev)
Signature · 1 line
2.19.0.605.g01d371f741-goog
reviewer Reviewed-by on v1 2/2
#12 lore raw

Re: [PATCH v3.1 2/2] Bluetooth: btqcomsmd: Get the BD address with device_get_bd_address()

Quoted 7 lines · Matthias Kaehlcke

Use the new API to get the BD address instead of reading it directly from the device tree.

Also remove an unncessary pair of braces in the same area of code.

Signature · 2 lines
Sakari Ailus
[email protected]