arm64: percpu: Initialize ret in the default case
Subsystems (2)
PATCH 1/1 arm64: percpu: Initialize ret in the default case
Clang warns that if the default case is taken, ret will be uninitialized.
./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs
here
return ret;
^~~
./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable
'ret' to silence this warning
unsigned long ret, loop;
^
= 0This warning appears several times while building the erofs filesystem. While it's not strictly wrong, the BUILD_BUG will prevent this from becoming a true problem. Initialize ret to 0 in the default case right before the BUILD_BUG to silence all of these warnings.
--- arch/arm64/include/asm/percpu.h | 3 +++ 1 file changed, 3 insertions(+)
arch/arm64/include/asm/percpu.h +3 -0
@@ -96,6 +96,7 @@ static inline unsigned long __percpu_##op(void *ptr, \ : [val] "Ir" (val)); \break ; \default : \ + ret =0 ; \BUILD_BUG (); \ } \ \
@@ -125,6 +126,7 @@ static inline unsigned long __percpu_read(void *ptr, int size) ret =READ_ONCE (*(u64 *)ptr);break ;default : + ret =0 ;BUILD_BUG (); }
@@ -194,6 +196,7 @@ static inline unsigned long __percpu_xchg(void *ptr, unsigned long val, : [val] "r" (val));break ;default : + ret =0 ;BUILD_BUG (); }
Signature · 1 line
2.19.0
Quoted 19 lines · Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized.
./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]default: ^~~~~~~ ./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs here return ret; ^~~ ./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable 'ret' to silence this warning unsigned long ret, loop; ^ = 0
Quoted 4 lines
This warning appears several times while building the erofs filesystem. While it's not strictly wrong, the
BUILD_BUGwill prevent this from becoming a true problem. Initialize ret to 0 in the default case right before theBUILD_BUGto silence all of these warnings.
Clang does semantic analysis BEFORE inlining/optimizations, so I can't determine that default is never reachable. Nathan, thanks for this patch.
Quoted 38 lines
Reported-by Prasad Sodagudi <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- arch/arm64/include/asm/percpu.h | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/include/asm/percpu.h +3
-1@@ -96,6 +96,7 @@ static inline unsigned long __percpu_##op(void *ptr, \ : [val] "Ir" (val)); \break ; \default : \ + ret =0 ; \BUILD_BUG (); \ } \ \@@ -125,6 +126,7 @@ static inline unsigned long __percpu_read(void *ptr, int size) ret =READ_ONCE (*(u64 *)ptr);break ;default : + ret =0 ;BUILD_BUG (); }@@ -194,6 +196,7 @@ static inline unsigned long __percpu_xchg(void *ptr, unsigned long val, : [val] "r" (val));break ;default : + ret =0 ;BUILD_BUG (); } --2.19.0
Signature · 2 lines
Thanks, ~Nick Desaulniers
Quoted 22 lines · Nick Desaulniers
Quoted 19 lines · Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized.
./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]default: ^~~~~~~ ./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs here return ret; ^~~ ./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable 'ret' to silence this warning unsigned long ret, loop; ^ = 0
Quoted 6 lines
Quoted 4 lines
This warning appears several times while building the erofs filesystem. While it's not strictly wrong, the
BUILD_BUGwill prevent this from becoming a true problem. Initialize ret to 0 in the default case right before theBUILD_BUGto silence all of these warnings.Clang does semantic analysis BEFORE inlining/optimizations, so I can't
s/I/it/
Quoted 47 lines
determine that default is never reachable. Nathan, thanks for this patch.
Reviewed-by Nick Desaulniers <[email protected]>Quoted 36 lines
Reported-by Prasad Sodagudi <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>--- arch/arm64/include/asm/percpu.h | 3 +++ 1 file changed, 3 insertions(+)arch/arm64/include/asm/percpu.h +3
-1@@ -96,6 +96,7 @@ static inline unsigned long __percpu_##op(void *ptr, \ : [val] "Ir" (val)); \break ; \default : \ + ret =0 ; \BUILD_BUG (); \ } \ \@@ -125,6 +126,7 @@ static inline unsigned long __percpu_read(void *ptr, int size) ret =READ_ONCE (*(u64 *)ptr);break ;default : + ret =0 ;BUILD_BUG (); }@@ -194,6 +196,7 @@ static inline unsigned long __percpu_xchg(void *ptr, unsigned long val, : [val] "r" (val));break ;default : + ret =0 ;BUILD_BUG (); } --Quoted 2 lines
2.19.0
--
Thanks,
~Nick Desaulniers
Signature · 2 lines
Thanks, ~Nick Desaulniers
Dennis Zhou
maintainerHi Nick,
Quoted 26 lines · Nick Desaulniers
Quoted 19 lines · Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized.
./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]default: ^~~~~~~ ./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs here return ret; ^~~ ./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable 'ret' to silence this warning unsigned long ret, loop; ^ = 0Quoted 4 lines
This warning appears several times while building the erofs filesystem. While it's not strictly wrong, the
BUILD_BUGwill prevent this from becoming a true problem. Initialize ret to 0 in the default case right before theBUILD_BUGto silence all of these warnings.
Quoted 5 lines
Clang does semantic analysis BEFORE inlining/optimizations, so I can't determine that default is never reachable. Nathan, thanks for this patch.
Reviewed-by Nick Desaulniers <[email protected]>
Thanks for the explanation!
Dennis
Hi Nathan,
Quoted 18 lines · Nathan Chancellor
Clang warns that if the default case is taken, ret will be uninitialized.
./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]default: ^~~~~~~ ./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs here return ret; ^~~ ./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable 'ret' to silence this warning unsigned long ret, loop; ^ = 0
Quoted 7 lines
This warning appears several times while building the erofs filesystem. While it's not strictly wrong, the
BUILD_BUGwill prevent this from becoming a true problem. Initialize ret to 0 in the default case right before theBUILD_BUGto silence all of these warnings.Reported-by Prasad Sodagudi <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>
I've applied this to percpu/for-4.20.
Thanks,
Dennis