Skip to contentSkip to conversation

package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf

PATCH New Thomas Petazzoni 2 participants 3 messages Sep 23, 2018 – Oct 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf

The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so it should depend on host-pkgconf. Otherwise, a "make host-xutil_makedepend" fails with:

"""
checking for X... configure: error: in `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
configure: error: The pkg-config script could not be found or is too old. Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you may set the environment variables X_CFLAGS and X_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
"""

This was detected using per-package host/target directories, but can be reproduced without it.

---
 package/x11r7/xutil_makedepend/xutil_makedepend.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/x11r7/xutil_makedepend/xutil_makedepend.mk +2 -2
index 8a058efcec..a50320ba93 100644
@@ -10,8 +10,8 @@ XUTIL_MAKEDEPEND_SITE = http://xorg.freedesktop.org/releases/individual/util
 XUTIL_MAKEDEPEND_LICENSE = MIT
 XUTIL_MAKEDEPEND_LICENSE_FILES = COPYING
 
-XUTIL_MAKEDEPEND_DEPENDENCIES = xorgproto
-HOST_XUTIL_MAKEDEPEND_DEPENDENCIES = host-xorgproto
+XUTIL_MAKEDEPEND_DEPENDENCIES = xorgproto host-pkgconf
+HOST_XUTIL_MAKEDEPEND_DEPENDENCIES = host-xorgproto host-pkgconf
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
Signature · 1 line
2.14.4
author Applied
#1 lore raw

PATCH 1/1 package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf

Hello,

Quoted 17 lines · Thomas Petazzoni

The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so it should depend on host-pkgconf. Otherwise, a "make host-xutil_makedepend" fails with:

"""
checking for X... configure: error: in `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
configure: error: The pkg-config script could not be found or is too old. Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you may set the environment variables X_CFLAGS and X_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
"""

Quoted 7 lines

This was detected using per-package host/target directories, but can be reproduced without it.

---
 package/x11r7/xutil_makedepend/xutil_makedepend.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/x11r7/xutil_makedepend: add missing dependency on host-pkgconf

In reply to Thomas Petazzoni
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

The configure script of xutil_makedepend uses PKG_CHECK_MODULES(), so it should depend on host-pkgconf. Otherwise, a "make host-xutil_makedepend" fails with:

"""
checking for X... configure: error: in `/home/thomas/projets/buildroot/output/build/host-xutil_makedepend-1.0.5':
configure: error: The pkg-config script could not be found or is too old. Make sure it is in your PATH or set the PKG_CONFIG environment variable to the full path to pkg-config.

Alternatively, you may set the environment variables X_CFLAGS and X_LIBS to avoid the need to call pkg-config. See the pkg-config man page for more details.

Quoted 7 lines

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
"""

This was detected using per-package host/target directories, but can be reproduced without it.

Committed to 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard