Skip to contentSkip to conversation

net/netvsc: check return from kvargs_process

PATCH Applied Stephen Hemminger 2 participants 2 messages Sep 26, 2018 – Oct 1, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/netvsc: check return from kvargs_process

Should check return value from processing latency value.

Coverity issue: 322104

---
Patch against dpdk-next-net

 drivers/net/netvsc/hn_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/netvsc/hn_ethdev.c +6 -2
index b67cce1ba8f5..8845fc0e6176 100644
@@ -167,6 +167,7 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
 		NULL
 	};
 	struct rte_kvargs *kvlist;
+	int ret;
 
 	if (!devargs)
 		return 0;
@@ -180,9 +181,12 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
 		return -EINVAL;
 	}
 
-	rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	ret = rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	if (ret)
+		PMD_DRV_LOG(ERR, "Unable to process latency arg\n");
+
 	rte_kvargs_free(kvlist);
-	return 0;
+	return ret;
 }
 
 /* Update link status.
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 4 lines · Stephen Hemminger

Should check return value from processing latency value.

Coverity issue: 322104

Fixes a25d39a3eb69 ("net/netvsc: allow tuning latency with devargs")

Applied to dpdk-next-net/master, thanks.