Skip to contentSkip to conversation

crypto: caam/qi2 - add CONFIG_NETDEVICES dependency

PATCH In review Arnd Bergmann 3 participants 3 messages Sep 26, 2018 – Oct 5, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: caam/qi2 - add CONFIG_NETDEVICES dependency

This driver implements a (part of a) network driver, and fails to build if we have turned off networking support:

drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
caamalg_qi2.c:(.text+0x577c): undefined reference to napi_schedule_prep' caamalg_qi2.c:(.text+0x578c): undefined reference to __napi_schedule_irqoff' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
caamalg_qi2.c:(.text+0x59b8): undefined reference to napi_complete_done' drivers/crypto/caam/caamalg_qi2.o: In function dpaa2_caam_remove':
caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to napi_disable' caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to netif_napi_del' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'

Quoted 1 line

From what I can tell, CONFIG_NETDEVICES is the correct dependency here,

and adding it fixes the randconfig failures.

Fixes 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
---
 drivers/crypto/caam/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/crypto/caam/Kconfig +1 -0
index ec42fb652167..619a2c929f3e 100644
@@ -156,6 +156,7 @@ endif # CRYPTO_DEV_FSL_CAAM
 config CRYPTO_DEV_FSL_DPAA2_CAAM
 	tristate "QorIQ DPAA2 CAAM (DPSECI) driver"
 	depends on FSL_MC_DPIO
+	depends on NETDEVICES
 	select CRYPTO_DEV_FSL_CAAM_COMMON
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AUTHENC
Signature · 1 line
2.18.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 14 lines · Arnd Bergmann

This driver implements a (part of a) network driver, and fails to build if we have turned off networking support:

drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
caamalg_qi2.c:(.text+0x577c): undefined reference to napi_schedule_prep' caamalg_qi2.c:(.text+0x578c): undefined reference to __napi_schedule_irqoff' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
caamalg_qi2.c:(.text+0x59b8): undefined reference to napi_complete_done' drivers/crypto/caam/caamalg_qi2.o: In function dpaa2_caam_remove':
caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to napi_disable' caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to netif_napi_del' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'

Quoted 5 lines

From what I can tell, CONFIG_NETDEVICES is the correct dependency here, and adding it fixes the randconfig failures.

Fixes 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")

Thanks,
Horia

maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 14 lines · Arnd Bergmann

This driver implements a (part of a) network driver, and fails to build if we have turned off networking support:

drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
caamalg_qi2.c:(.text+0x577c): undefined reference to napi_schedule_prep' caamalg_qi2.c:(.text+0x578c): undefined reference to __napi_schedule_irqoff' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
caamalg_qi2.c:(.text+0x59b8): undefined reference to napi_complete_done' drivers/crypto/caam/caamalg_qi2.o: In function dpaa2_caam_remove':
caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to napi_disable' caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to netif_napi_del' drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'

Quoted 5 lines
Quoted 1 line

From what I can tell, CONFIG_NETDEVICES is the correct dependency here,

and adding it fixes the randconfig failures.

Fixes 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt