Skip to contentSkip to conversation

drm/i915: Log HWS seqno consistently

PATCH Superseded Tvrtko Ursulin 4 participants 8 messages Sep 26, 2018 – Sep 27, 2018

Subsystems (2)
lore
Share & tools
lore

Tvrtko Ursulin

author maintainer
#0 lore raw

PATCH 1/1 drm/i915: Log HWS seqno consistently

From: Tvrtko Ursulin <[email protected]>

We mix hexa- and decimal which is confusing when reading the logs. So make the single odd one out instance decimal for consistency.

---
Later we can consider whether we should move them all to unsigned, or hex, etc..

---
 drivers/gpu/drm/i915/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +1 -1
index 4b28225320ff..ad93aa4b0a6e 100644
@@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
 	unsigned long flags;
 	u32 *regs;
 
-	GEM_TRACE("%s request global=%x, current=%d\n",
+	GEM_TRACE("%s request global=%d, current=%d\n",
 		  engine->name, request ? request->global_seqno : 0,
 		  intel_engine_get_seqno(engine));
 
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Tvrtko Ursulin (2018-09-26 12:12:17)

Quoted 19 lines

From: Tvrtko Ursulin <[email protected]>

We mix hexa- and decimal which is confusing when reading the logs. So make the single odd one out instance decimal for consistency.

---
Later we can consider whether we should move them all to unsigned, or hex, etc..

---
 drivers/gpu/drm/i915/intel_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +0 -0
index 4b28225320ff..ad93aa4b0a6e 100644

drivers/gpu/drm/i915/intel_lrc.c static void execlists_reset(struct intel_engine_cs *engine, · line 1910

Quoted 8 lines
drivers/gpu/drm/i915/intel_lrc.c +1 -1
@@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
        unsigned long flags;
        u32 *regs;
 
-       GEM_TRACE("%s request global=%x, current=%d\n",
+       GEM_TRACE("%s request global=%d, current=%d\n",
                  engine->name, request ? request->global_seqno : 0,
                  intel_engine_get_seqno(engine));
 

One more in intel_ringbuffer.c
drivers/gpu/drm/i915/intel_ringbuffer.c: GEM_TRACE("%s seqno=%x\n", engine->name, rq ? rq->global_seqno : 0);
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author maintainer
#2 lore raw

PATCH v2 1/1 drm/i915: Log HWS seqno consistently

From: Tvrtko Ursulin <[email protected]>

We mix hexa- and decimal which is confusing when reading the logs. So make the single odd one out instance decimal for consistency.

v2:
* Do the intel_ringbuffer.c as well. (Chris Wilson)

---
 drivers/gpu/drm/i915/intel_lrc.c        | 2 +-
 drivers/gpu/drm/i915/intel_ringbuffer.c | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_lrc.c +1 -1
index 4b28225320ff..ad93aa4b0a6e 100644
@@ -1904,7 +1904,7 @@ static void execlists_reset(struct intel_engine_cs *engine,
 	unsigned long flags;
 	u32 *regs;
 
-	GEM_TRACE("%s request global=%x, current=%d\n",
+	GEM_TRACE("%s request global=%d, current=%d\n",
 		  engine->name, request ? request->global_seqno : 0,
 		  intel_engine_get_seqno(engine));
 
drivers/gpu/drm/i915/intel_ringbuffer.c +3 -1
index d0ef50bf930a..c092d5099ebf 100644
@@ -574,7 +574,9 @@ static void skip_request(struct i915_request *rq)
 
 static void reset_ring(struct intel_engine_cs *engine, struct i915_request *rq)
 {
-	GEM_TRACE("%s seqno=%x\n", engine->name, rq ? rq->global_seqno : 0);
+	GEM_TRACE("%s request global=%d, current=%d\n",
+		  engine->name, rq ? rq->global_seqno : 0,
+		  intel_engine_get_seqno(engine));
 
 	/*
 	 * Try to restore the logical GPU state to match the continuation
Signature · 6 lines
2.17.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 1/1
#3 lore raw

Quoting Tvrtko Ursulin (2018-09-26 15:50:33)

Quoted 10 lines

From: Tvrtko Ursulin <[email protected]>

We mix hexa- and decimal which is confusing when reading the logs. So make the single odd one out instance decimal for consistency.

v2:
* Do the intel_ringbuffer.c as well. (Chris Wilson)

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.BAT: failure for drm/i915: Log HWS seqno consistently

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915: Log HWS seqno consistently
URL : https://patchwork.freedesktop.org/series/50193/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4879 -> Patchwork_10284 =

== Summary - FAILURE ==

Serious unknown changes coming with Patchwork_10284 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10284, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/50193/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10284:

=== IGT changes ===

    ==== Possible regressions ====

    igt@kms_psr@primary_page_flip:
      fi-icl-u:           NOTRUN -> DMESG-FAIL

== Known issues ==

Here are the changes found in Patchwork_10284 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-no-display:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108071) +1

    igt@kms_flip@basic-flip-vs-dpms:
      fi-skl-6700hq:      PASS -> DMESG-WARN (fdo#105998)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-icl-u:           NOTRUN -> DMESG-WARN (fdo#108070) +45

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bdw-samus:       NOTRUN -> INCOMPLETE (fdo#107773)

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-bdw-samus:       INCOMPLETE (fdo#107773) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS

fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
fdo#108071 https://bugs.freedesktop.org/show_bug.cgi?id=108071

== Participating hosts (46 -> 42) ==

Additional (2): fi-icl-u fi-snb-2520m
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600

== Build changes ==

* Linux: CI_DRM_4879 -> Patchwork_10284

CI_DRM_4879: 4479cfaa37f67802bf6d9af92ae703011926bcb8 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4650: a6e21812d100dce68450727e79fc09e0c0033683 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10284: 84ce25b5df3fc28629a41982b6a700f54b85322f @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

84ce25b5df3f drm/i915: Log HWS seqno consistently

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10284/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✓ Fi.CI.BAT: success for drm/i915: Log HWS seqno consistently (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915: Log HWS seqno consistently (rev2)
URL : https://patchwork.freedesktop.org/series/50193/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4883 -> Patchwork_10286 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10286 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10286, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/50193/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10286:

=== IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@module-reload:
      fi-hsw-4770r:       PASS -> SKIP

== Known issues ==

Here are the changes found in Patchwork_10286 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-icl-u:           PASS -> DMESG-WARN (fdo#107724, fdo#108070)

    igt@drv_getparams_basic@basic-eu-total:
      fi-icl-u:           PASS -> DMESG-WARN (fdo#107724)

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107924, fdo#107425)

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

    
    ==== Possible fixes ====

    igt@kms_psr@primary_page_flip:
      fi-cfl-s3:          FAIL (fdo#107336) -> PASS
      fi-kbl-r:           FAIL (fdo#107336) -> PASS

fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070

== Participating hosts (47 -> 42) ==

Missing (5): fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4883 -> Patchwork_10286

CI_DRM_4883: fe61f770c6bb80e924efb5c822440d265df3dc7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4650: a6e21812d100dce68450727e79fc09e0c0033683 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10286: c2f0ae53ffd34dab3ec832fbaea4ba5ba9fbcbd5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c2f0ae53ffd3 drm/i915: Log HWS seqno consistently

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10286/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Log HWS seqno consistently (rev2)

Quoted 84 lines · Patchwork

== Series Details ==

Series: drm/i915: Log HWS seqno consistently (rev2)
URL : https://patchwork.freedesktop.org/series/50193/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4883 -> Patchwork_10286 =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10286 need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10286, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

   External URL: https://patchwork.freedesktop.org/api/1.0/series/50193/revisions/2/mbox/

== Possible new issues ==

   Here are the unknown changes that may have been introduced in Patchwork_10286:

   === IGT changes ===

     ==== Warnings ====

     igt@pm_rpm@module-reload:
       fi-hsw-4770r:       PASS -> SKIP

== Known issues ==

   Here are the changes found in Patchwork_10286 that come from known issues:

   === IGT changes ===

     ==== Issues hit ====

     igt@debugfs_test@read_all_entries:
       fi-icl-u:           PASS -> DMESG-WARN (fdo#107724, fdo#108070)

     igt@drv_getparams_basic@basic-eu-total:
       fi-icl-u:           PASS -> DMESG-WARN (fdo#107724)

     igt@drv_module_reload@basic-reload-inject:
       fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107924, fdo#107425)

     igt@gem_exec_suspend@basic-s3:
       fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)
       fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

     igt@kms_frontbuffer_tracking@basic:
       fi-hsw-peppy:       PASS -> DMESG-WARN (fdo#102614)

     
     ==== Possible fixes ====

     igt@kms_psr@primary_page_flip:
       fi-cfl-s3:          FAIL (fdo#107336) -> PASS
       fi-kbl-r:           FAIL (fdo#107336) -> PASS

     
   fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
   fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
   fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
   fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
   fdo#107724 https://bugs.freedesktop.org/show_bug.cgi?id=107724
   fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
   fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
   fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070

== Participating hosts (47 -> 42) ==

   Missing    (5): fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4883 -> Patchwork_10286

Quoted 8 lines
   CI_DRM_4883: fe61f770c6bb80e924efb5c822440d265df3dc7f @ git://anongit.freedesktop.org/gfx-ci/linux
   IGT_4650: a6e21812d100dce68450727e79fc09e0c0033683 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
   Patchwork_10286: c2f0ae53ffd34dab3ec832fbaea4ba5ba9fbcbd5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

c2f0ae53ffd3 drm/i915: Log HWS seqno consistently

Pushed, thanks for the review!

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.IGT: success for drm/i915: Log HWS seqno consistently (rev2)

In reply to Tvrtko Ursulin
== Series Details ==

== Series Details ==

Series: drm/i915: Log HWS seqno consistently (rev2)
URL : https://patchwork.freedesktop.org/series/50193/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4883_full -> Patchwork_10286_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_10286_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_10286_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_10286_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_busy@basic-modeset-b:
      shard-snb:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_10286_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          PASS -> FAIL (fdo#106509, fdo#105454) +1

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@pm_rpm@drm-resources-equal:
      shard-kbl:          PASS -> FAIL (fdo#104767)

    
    ==== Possible fixes ====

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
      shard-snb:          DMESG-WARN (fdo#107956) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_universal_plane@disable-primary-vs-flip-pipe-e:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

fdo#104767 https://bugs.freedesktop.org/show_bug.cgi?id=104767
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (6 -> 5) ==

Missing (1): shard-skl

== Build changes ==

* Linux: CI_DRM_4883 -> Patchwork_10286

CI_DRM_4883: fe61f770c6bb80e924efb5c822440d265df3dc7f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4650: a6e21812d100dce68450727e79fc09e0c0033683 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10286: c2f0ae53ffd34dab3ec832fbaea4ba5ba9fbcbd5 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10286/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx