Skip to contentSkip to conversation

Remove some userspace related tests

RFC PATCH Superseded Petr Vorel 2 participants 6 messages Sep 24, 2018 – Sep 27, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

cover Remove some userspace related tests

Hi,

there was some discussion to remove userspace related tests in the past [1]. This patchset does something similar for ftp and ssh login commands and cron tests (part of EAL2 testsuite) + EAL2 testsuite script itself. They're unmaintained and related to userspace security rather than kernel security. Other non-filesystem or non-kernel related commands (e.g. tar, gzip, file) should be deleted as well, as Sebastian proposed [2].

We've recently discussed with Cyril the idea of ltp-userspace package. We can create this project and move this code there if anyone step up being a maintainer of it.

Kind regards,
Petr

[1] http://lists.linux.it/pipermail/ltp/2018-April/007899.html
[2] http://lists.linux.it/pipermail/ltp/2018-April/007898.html

Petr Vorel (3):
testscripts: Remove EAL2 testsuite script
net: Remove network_commands (ftp, ssh)
Remove cron tests

 runtest/admin_tools                           |   9 -
 runtest/commands                              |   1 -
 runtest/network_commands                      |   8 -
 scenario_groups/default                       |   1 -
 scenario_groups/network                       |   1 -
 testcases/commands/.gitignore                 |   1 -
 testcases/commands/cron/00_Descriptions.txt   |   4 -
 testcases/commands/cron/Makefile              |  29 --
 testcases/commands/cron/README.tests          |  25 --
 testcases/commands/cron/cron02                |  80 -----
 testcases/commands/cron/cron03                |  83 ------
 testcases/commands/cron/cron_allow01          | 202 -------------
 testcases/commands/cron/cron_deny01           | 192 ------------
 testcases/commands/cron/cron_dirs_check.c     |  44 ---
 testcases/commands/cron/cron_dirs_checks01    |  46 ---
 .../commands/cron/cron_illegal_cron_lines     |  39 ---
 testcases/commands/cron/cron_neg_tests.sh     | 141 ---------
 testcases/commands/cron/cron_pos_tests.sh     | 118 --------
 testcases/commands/cron/cron_tests.sh         | 276 ------------------
 testcases/network/tcp_cmds/ftp/ftp02          |  98 -------
 testcases/network/tcp_cmds/ftp/ftp03          | 106 -------
 testcases/network/tcp_cmds/ftp/ftp04          |  81 -----
 testcases/network/tcp_cmds/ftp/ftp05          | 110 -------
 testcases/network/tcp_cmds/ssh/Makefile       |  31 --
 testcases/network/tcp_cmds/ssh/ssh01          |  57 ----
 testcases/network/tcp_cmds/ssh/ssh01_s1       |  72 -----
 testcases/network/tcp_cmds/ssh/ssh02          |  57 ----
 testcases/network/tcp_cmds/ssh/ssh02_s1       |  73 -----
 testcases/network/tcp_cmds/ssh/ssh03          |  52 ----
 testcases/network/tcp_cmds/ssh/ssh03_s1       |  67 -----
 testcases/network/tcp_cmds/ssh/ssh_setup      |  54 ----
 testscripts/runEALtests.sh                    | 235 ---------------
 32 files changed, 2393 deletions(-)
 delete mode 100644 runtest/admin_tools
 delete mode 100644 runtest/network_commands
 delete mode 100644 testcases/commands/cron/00_Descriptions.txt
 delete mode 100644 testcases/commands/cron/Makefile
 delete mode 100644 testcases/commands/cron/README.tests
 delete mode 100755 testcases/commands/cron/cron02
 delete mode 100755 testcases/commands/cron/cron03
 delete mode 100755 testcases/commands/cron/cron_allow01
 delete mode 100755 testcases/commands/cron/cron_deny01
 delete mode 100644 testcases/commands/cron/cron_dirs_check.c
 delete mode 100755 testcases/commands/cron/cron_dirs_checks01
 delete mode 100644 testcases/commands/cron/cron_illegal_cron_lines
 delete mode 100755 testcases/commands/cron/cron_neg_tests.sh
 delete mode 100755 testcases/commands/cron/cron_pos_tests.sh
 delete mode 100644 testcases/commands/cron/cron_tests.sh
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp02
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp03
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp04
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp05
 delete mode 100644 testcases/network/tcp_cmds/ssh/Makefile
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh01
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh01_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh02
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh02_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh03
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh03_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh_setup
 delete mode 100755 testscripts/runEALtests.sh
Signature · 1 line
2.19.0
author
#1 lore raw

RFC PATCH 1/3 testscripts: Remove EAL2 testsuite script

as it's not maintained any more.

---
 testscripts/runEALtests.sh | 235 -------------------------------------
 1 file changed, 235 deletions(-)
 delete mode 100755 testscripts/runEALtests.sh
testscripts/runEALtests.sh deleted +0 -235
deleted file mode 100755
index 810dc4718..000000000
@@ -1,235 +0,0 @@
-#!/bin/bash
-
-
-#
-#  07/10/02 - Jeff Martin - [email protected]: Added instance and
-#                           time command line options
-#
-#  12/15/02 - Manoj Iyer  - [email protected]: Added options to run
-#                           LTP under CPU, IO and MM load.
-#
-#  01/26/03 - Manoj Iyer  - [email protected]: Added -f option; Execute
-#                           user defined set of testcases.
-#
-#  01/27/03 - Manoj Iyer  - [email protected]: Enabled formatted printing
-#                           of logfiles.
-#
-#  01/28/03 - Manoj Iyer  - [email protected]: added option to enable
-#                           formatted printing of logfiles.
-#
-#  01/29/03 - Manoj Iyer  - [email protected]: merged networktests.sh with
-#                           this script, added the -n option to run these
-#                           tests. Also, added -h option to print help messages.
-#
-#  01/29/03 - Manoj Iyer  - [email protected]:
-#                           added code to cause pan to print less verbose
-#                           output.
-#  02/01/03 - Manoj Iyer  - [email protected]: Removed variables
-#                           initialization of RHOST and PASSWD.
-#
-#  02/05/03 - Robbie Williamson - Added configurability to the optional load
-#                                 generator sections.  Also added network traffic
-#				  option.
-#
-
-cd `dirname $0`
-export LTPROOT=${PWD}
-export TMPBASE="/tmp"
-export TMP="${TMPBASE}/runalltests-$$"
-export PATH="${PATH}:${LTPROOT}/../testcases/bin"
-cmdfile=""
-pretty_prt=" "
-alt_dir=0
-run_netest=0
-quiet_mode=" "
-NetPipe=0
-GenLoad=0
-
-usage()
-{
-	cat <<-END >&2
-    usage: ./${0##*/} -c [-d tmpdir] [-f cmdfile ] [-i # (in Mb)] [ -l logfile ]
-                  [ -m # (in Mb)] -N -n -q [ -r ltproot ] [ -t duration ] [ -x instances ]
-
-    -c              Run LTP under additional background CPU load.
-    -d tmpdir       Directory where temporary files will be created.
-    -f cmdfile      Execute user defined list of testcases.
-    -h              Help. Prints all available options.
-    -i # (in Mb)    Run LTP with a _minimum_ IO load of # megabytes in background.
-    -l logfile      Log results of test in a logfile.
-    -m # (in Mb)    Run LTP with a _minimum_ memory load of # megabytes in background.
-    -N              Run all the networking tests.
-                    (export RHOST = remote hostname)
-                    (export PASSWD = passwd of remote host)
-    -n              Run LTP with network traffic in background.
-    -p              Human readable format logfiles.
-    -q              Print less verbose output to screen.
-    -r ltproot      Fully qualified path where testsuite is installed.
-    -t duration     Execute the testsuite for given duration in hours.
-    -x instances    Run multiple instances of this testsuite.
-
-    example: ./${0##*/} -i 1024 -m 128 -p -q  -l /tmp/resultlog.$$ -d ${PWD}
-	END
-exit
-}
-
-mkdir -p ${TMP}
-
-cd ${TMP}
-if [ $? -ne 0 ]; then
-  echo "could not cd ${TMP} ... exiting"
-  exit
-fi
-
-while getopts cd:f:hi:l:m:Npqr:t:x arg
-do  case $arg in
-    c)
-            $LTPROOT/../testcases/bin/genload --cpu 1 >/dev/null 2>&1 &
-	    GenLoad=1 ;;
-
-    d)      # append $$ to TMP, as it is recursively
-            # removed at end of script.
-            TMPBASE=$OPTARG;;
-    f)        # Execute user defined set of testcases.
-            cmdfile=$OPTARG;;
-
-    h)	    usage;;
-
-    i)
-            bytesize=$(($OPTARG * 1024 * 1024))
-            $LTPROOT/../testcases/bin/genload --io 1 >/dev/null 2>&1 &
-            $LTPROOT/../testcases/bin/genload --hdd 0 --hdd-bytes $bytesize \
-            >/dev/null 2>&1 &
-	    GenLoad=1 ;;
-
-    l)
-            if [ ${OPTARG:0:1} != "/" ]
-			then
-				if [ -d $LTPROOT/results ]
-				then
-					logfile="-l $LTPROOT/results/$OPTARG"
-				else
-					mkdir -p $LTPROOT/results
-					if [ $? -ne 0 ]
-					then
-						echo "ERROR: failed to create $LTPROOT/results"
-						exit 1
-					fi
-					logfile="-l $LTPROOT/results/$OPTARG"
-				fi
-				alt_dir=1
-            else
-				logfile="-l $OPTARG"
-			fi ;;
-
-    m)
-            memsize=$(($OPTARG * 1024 * 1024))
-	    $LTPROOT/../testcases/bin/genload  --vm 0 --vm-bytes $memsize\
-            >/dev/null 2>&1 &
-	    GenLoad=1;;
-
-    N)	    run_netest=1;;
-
-    p)      pretty_prt=" -p ";;
-
-    q)      quiet_mode=" -q ";;
-
-    r)      LTPROOT=$OPTARG;;
-
-    t)      # In case you want to specify the time
-            # to run from the command line
-            # (2m = two minutes, 2h = two hours, etc)
-            duration="-t $OPTARG" ;;
-
-    x)      # number of ltp's to run
-            instances="-x $OPTARG";;
-
-    \?)     usage;;
-    esac
-done
-
-if [ -z $PASSWD ]
-then
-	echo " "
-	echo "ERROR:"
-	echo "Please export enviroment variable PASSWD"
-	echo "INFO: export PASSWD = 'root's password'"
-    exit 1
-fi
-
-#if [ $run_netest -eq 1 ]
-#then
-#	if [[ -z $RHOST || -z $PASSWD ]]
-#	then
-#		echo " "
-#		echo " "
-#		echo "ERROR: Initializing networking tests."
-#		echo "INFO: Please export RHOST = 'name of the remote host machine'"
-#		echo "INFO: Please export PASSWD = 'passwd of the remote host machine'"
-#		echo "INFO: before running the networking tests."
-#		echo " "
-#		echo " "
-#		echo " "
-#		usage
-#	fi
-#fi
-
-if [ -n "$instances" ]; then
-  instances="$instances -O ${TMP}"
-fi
-
-
-# If user does not provide a command file select a default set of testcases
-# to execute.
-if [ -z $cmdfile ]
-then
-	cat ${LTPROOT}/../runtest/admin_tools > ${TMP}/alltests
-else
-    cat $cmdfile > ${TMP}/alltests
-fi
-
-if [ $run_netest -eq 1 ]
-then
-	cat ${LTPROOT}/../runtest/network_commands >> ${TMP}/alltests
-fi
-
-# The fsx-linux tests use the SCRATCHDEV environment variable as a location
-# that can be reformatted and run on.  Set SCRATCHDEV if you want to run
-# these tests.  As a safeguard, this is disabled.
-unset SCRATCHDEV
-if [ -n "$SCRATCHDEV" ]; then
-  cat ${LTPROOT}/../runtest/fsx >> ${TMP}/alltests
-fi
-
-# display versions of installed software
-${LTPROOT}/../ver_linux
-
-${LTPROOT}/../bin/ltp-pan $quiet_mode -e -S $instances $duration -a $$ -n $$ $pretty_prt -f ${TMP}/alltests $logfile
-
-if [ $? -eq 0 ]; then
-  echo ltp-pan reported PASS
-else
-  echo ltp-pan reported FAIL
-fi
-
-if [ $GenLoad -eq 1 ]
-then
-	killall -9 genload >/dev/null 2>&1
-fi
-
-if [ $NetPipe -eq 1 ]
-then
-	killall -9 NPtcp
-fi
-
-if [ $alt_dir -eq 1 ]
-then
-	echo " "
-	echo "###############################################################"
-	echo " "
-	echo " result log is in the $LTPROOT/results directory"
-	echo " "
-	echo "###############################################################"
-	echo " "
-fi
-rm -rf ${TMP}
Signature · 1 line
2.19.0
author
#2 lore raw

RFC PATCH 2/3 net: Remove network_commands (ftp, ssh)

In reply to Petr Vorel

network_commands contains ftp and ssh login tests as a part of EAL2 testsuite. Removing them as they don't really fit into "kernel testing", it'd be better to have them in some "LTP userspace" project.

---
 runtest/network_commands                 |   8 --
 scenario_groups/network                  |   1 -
 testcases/network/tcp_cmds/ftp/ftp02     |  98 --------------------
 testcases/network/tcp_cmds/ftp/ftp03     | 106 ----------------------
 testcases/network/tcp_cmds/ftp/ftp04     |  81 -----------------
 testcases/network/tcp_cmds/ftp/ftp05     | 110 -----------------------
 testcases/network/tcp_cmds/ssh/Makefile  |  31 -------
 testcases/network/tcp_cmds/ssh/ssh01     |  57 ------------
 testcases/network/tcp_cmds/ssh/ssh01_s1  |  72 ---------------
 testcases/network/tcp_cmds/ssh/ssh02     |  57 ------------
 testcases/network/tcp_cmds/ssh/ssh02_s1  |  73 ---------------
 testcases/network/tcp_cmds/ssh/ssh03     |  52 -----------
 testcases/network/tcp_cmds/ssh/ssh03_s1  |  67 --------------
 testcases/network/tcp_cmds/ssh/ssh_setup |  54 -----------
 14 files changed, 867 deletions(-)
 delete mode 100644 runtest/network_commands
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp02
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp03
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp04
 delete mode 100755 testcases/network/tcp_cmds/ftp/ftp05
 delete mode 100644 testcases/network/tcp_cmds/ssh/Makefile
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh01
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh01_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh02
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh02_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh03
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh03_s1
 delete mode 100755 testcases/network/tcp_cmds/ssh/ssh_setup
runtest/network_commands deleted +0 -8
deleted file mode 100644
index c2eb142b3..000000000
@@ -1,8 +0,0 @@
-ftp02 ftp02
-ftp03 ftp03
-ftp04 ftp04
-ftp05 ftp05
-
-ssh01 ssh01
-ssh02 ssh02
-ssh03 ssh03
scenario_groups/network +0 -1
index d447daf88..46829501f 100644
@@ -9,7 +9,6 @@ net.nfs
 net.rpc_tests
 net.tirpc_tests
 net.sctp
-network_commands
 net_stress.appl
 net_stress.broken_ip
 net_stress.interface
testcases/network/tcp_cmds/ftp/ftp02 deleted +0 -98

98 lines not on this page · raw message

testcases/network/tcp_cmds/ftp/ftp03 deleted +0 -106

106 lines not on this page · raw message

testcases/network/tcp_cmds/ftp/ftp04 deleted +0 -81

81 lines not on this page · raw message

testcases/network/tcp_cmds/ftp/ftp05 deleted +0 -110

110 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/Makefile deleted +0 -31
deleted file mode 100644
index 8ce99e068..000000000
@@ -1,31 +0,0 @@
-#
-#    network/tcp_cmds/ssh testcases Makefile.
-#
-#    Copyright (C) 2009, Cisco Systems Inc.
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-# Ngie Cooper, July 2009
-#
-
-top_srcdir		?= ../../../..
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-INSTALL_TARGETS		:= ssh*
-
-MAKE_TARGETS		:=
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/network/tcp_cmds/ssh/ssh01 deleted +0 -57

57 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh01_s1 deleted +0 -72

72 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh02 deleted +0 -57

57 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh02_s1 deleted +0 -73

73 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh03 deleted +0 -52

52 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh03_s1 deleted +0 -67

67 lines not on this page · raw message

testcases/network/tcp_cmds/ssh/ssh_setup deleted +0 -54

54 lines not on this page · raw message

Signature · 1 line
2.19.0
author
#3 lore raw

RFC PATCH 3/3 Remove cron tests

In reply to Petr Vorel

Removing them as they don't really fit into "kernel testing", it'd be better to have them in some "LTP userspace" project.

+ remove admin_tools runtest file which run them (as a part of EAL2 testsuite).

---
 runtest/admin_tools                           |   9 -
 runtest/commands                              |   1 -
 scenario_groups/default                       |   1 -
 testcases/commands/.gitignore                 |   1 -
 testcases/commands/cron/00_Descriptions.txt   |   4 -
 testcases/commands/cron/Makefile              |  29 --
 testcases/commands/cron/README.tests          |  25 --
 testcases/commands/cron/cron02                |  80 -----
 testcases/commands/cron/cron03                |  83 ------
 testcases/commands/cron/cron_allow01          | 202 -------------
 testcases/commands/cron/cron_deny01           | 192 ------------
 testcases/commands/cron/cron_dirs_check.c     |  44 ---
 testcases/commands/cron/cron_dirs_checks01    |  46 ---
 .../commands/cron/cron_illegal_cron_lines     |  39 ---
 testcases/commands/cron/cron_neg_tests.sh     | 141 ---------
 testcases/commands/cron/cron_pos_tests.sh     | 118 --------
 testcases/commands/cron/cron_tests.sh         | 276 ------------------
 17 files changed, 1291 deletions(-)
 delete mode 100644 runtest/admin_tools
 delete mode 100644 testcases/commands/cron/00_Descriptions.txt
 delete mode 100644 testcases/commands/cron/Makefile
 delete mode 100644 testcases/commands/cron/README.tests
 delete mode 100755 testcases/commands/cron/cron02
 delete mode 100755 testcases/commands/cron/cron03
 delete mode 100755 testcases/commands/cron/cron_allow01
 delete mode 100755 testcases/commands/cron/cron_deny01
 delete mode 100644 testcases/commands/cron/cron_dirs_check.c
 delete mode 100755 testcases/commands/cron/cron_dirs_checks01
 delete mode 100644 testcases/commands/cron/cron_illegal_cron_lines
 delete mode 100755 testcases/commands/cron/cron_neg_tests.sh
 delete mode 100755 testcases/commands/cron/cron_pos_tests.sh
 delete mode 100644 testcases/commands/cron/cron_tests.sh
runtest/admin_tools deleted +0 -9
deleted file mode 100644
index 0a46468c8..000000000
@@ -1,9 +0,0 @@
-su01 export TCbin=$LTPROOT/testcases/bin;su01
-#cron01 cron01
-cron02 cron02
-cron_deny01 cron_deny01
-cron_allow01 cron_allow01
-cron_dirs_checks01 cron_dirs_checks01
-at_deny01 at_deny01
-at_allow01 at_allow01
-acl_test01 acl_test01
runtest/commands +0 -1
index ee7e9f440..462633017 100644
@@ -5,7 +5,6 @@ ldd01 ldd01
 nm01 nm01
 file01 file01.sh
 tar01  tar_tests.sh
-cron cron_tests.sh
 logrotate export TCdat=$LTPROOT/testcases/bin; logrotate_tests.sh
 cpio01 cpio_tests.sh
 unzip01 unzip01.sh
scenario_groups/default +0 -1
index 5658a618b..b1739b77e 100644
@@ -17,7 +17,6 @@ filecaps
 cap_bounds
 fcntl-locktests
 connectors
-admin_tools
 timers
 power_management_tests
 numa
testcases/commands/.gitignore +0 -1
index 9aa1caf6c..0ed343881 100644
@@ -1,5 +1,4 @@
 /ldd/datafiles/lddfile.out
 /ldd/datafiles/*.obj.so
-/cron/cron_dirs_check
 /eject/eject_check_tray
 /insmod/ltp_insmod01.ko
testcases/commands/cron/00_Descriptions.txt deleted +0 -4
deleted file mode 100644
index 9566e0aaa..000000000
@@ -1,4 +0,0 @@
-cron01
-	Test that crontab <filename> installs the cron-job-file and cron will
-	schedule the job correctly.
-
testcases/commands/cron/Makefile deleted +0 -29
deleted file mode 100644
index 4969ec7bb..000000000
@@ -1,29 +0,0 @@
-#
-#    commands/cron testcases Makefile.
-#
-#    Copyright (C) 2009, Cisco Systems Inc.
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-# Ngie Cooper, July 2009
-#
-
-top_srcdir		?= ../../..
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-INSTALL_TARGETS		:= cron0[23] cron_illegal_cron_lines cron_allow01 cron_deny01 cron_dirs_checks01 *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/commands/cron/README.tests deleted +0 -25
deleted file mode 100644
index 0d5db7113..000000000
@@ -1,25 +0,0 @@
-This directory contains two scripts and one data file to test cron. Both
-shouldn't be run as root but they warn for themselves. If a username is
-given as parameter they run as this user.
-
-Both scripts save the current crontab and restore it after finishing.
-
-* Positive tests
-
-	cron_pos_tests.sh [username]
-
-	- add new job
-	- check correct execution of job
-	- delete job
-
-* Negative tests
-
-	cron_neg_tests.sh [username]
-
-	- try to edit the crontab of root
-	- try to set illegal or nondefined execution times
-	  Here the script uses file illegal_cron_lines which contains two
-	  fields per line: the cron line to be tested (without script name),
-	  and the description of this test. The description is written to
-	  stdout during execution of the test.
-	- try to do things you aren't allowed as non-root (cron runs as root)
testcases/commands/cron/cron02 deleted +0 -80

80 lines not on this page · raw message

testcases/commands/cron/cron03 deleted +0 -83

83 lines not on this page · raw message

testcases/commands/cron/cron_allow01 deleted +0 -202

202 lines not on this page · raw message

testcases/commands/cron/cron_deny01 deleted +0 -192

192 lines not on this page · raw message

testcases/commands/cron/cron_dirs_check.c deleted +0 -44

44 lines not on this page · raw message

testcases/commands/cron/cron_dirs_checks01 deleted +0 -46

46 lines not on this page · raw message

testcases/commands/cron/cron_illegal_cron_lines deleted +0 -39
deleted file mode 100644
index 3b32dc844..000000000
@@ -1,39 +0,0 @@
-# Collection of illegal cron lines
-# Comment lines must habe its '#' as first character.
-# The cron conf line and its description is seperated by '|'.
-# cron job command 'true' is appended automatically
-
-# Illegal Minutes
-61 * * * * | Minute 61
--1 * * * * | Minute -1 (might be interpreted as range)
-0.5 * * * * | Minute 0.5
--1-10 * * * *| Minute Range -1-10
-0-61 * * * * | Minute Range 0-61
-
-# Illegal hours
-0 25 * * * | Hour 25
-0 -2 * * * | Hour -2
-0 3.5 * * *| Hour 3.5
-0 -4-10 * * *| Hour Range -4-10
-0 0-25 * * * | Hour Range 0-25
-
-# Illegal day of month
-0 0 32 * * | Day 32
-0 0 -1 * * | Day -1
-0 0 3.5 * *| Day 3.5
-0 0 -3-3 * *| Day Range -3-3
-0 0 0-32 * *| Day Range 0-32
-
-# Illegal month
-0 0 1 13 * | Month 13
-0 0 1 -1 * | Month -1
-0 0 1 2.5 * | Month 2.5
-0 0 1 -2-3 * | Month Range -2-3
-0 0 1 0-13 * | Month Range 0-13
-
-# Illegal day of week
-0 0 * * 8 | Day of Week 8
-0 0 * * -2 | Day of Week -2
-0 0 * * 2.5 | Day of Week 2.5
-0 0 * * -7-7 | Day of Week Range -7-7
-0 0 * * 0-8 | Day of Week Range 0-8
testcases/commands/cron/cron_neg_tests.sh deleted +0 -141

141 lines not on this page · raw message

testcases/commands/cron/cron_pos_tests.sh deleted +0 -118

118 lines not on this page · raw message

testcases/commands/cron/cron_tests.sh deleted +0 -276

276 lines not on this page · raw message

Signature · 1 line
2.19.0
#4 lore raw

RFC PATCH 3/3 Remove cron tests

Hi!

Quoted 2 lines

+ remove admin_tools runtest file which run them (as a part of EAL2 testsuite).

Can we get rid of the at_allow01 and at_deny01 tests as well?

Other than that this patchset looks good to me.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#5 lore raw

RFC PATCH 3/3 Remove cron tests

Hi Cyril,

Quoted 5 lines

Hi!

Quoted 2 lines

+ remove admin_tools runtest file which run them (as a part of EAL2 testsuite).

Can we get rid of the at_allow01 and at_deny01 tests as well?

Sure, I'll put it into v2.

Quoted 1 line

Other than that this patchset looks good to me.

Kind regards,
Petr