EDAC, dsm_edac: Wrap ACPI DSM methods for address translation
Luck, Tony
maintainerPATCH 4/5 EDAC, dsm_edac: Wrap ACPI DSM methods for address translation
Quoted 10 lines · Borislav Petkov
+ Rafael.
Quoted 6 lines · Tony Luck
From: Qiuxu Zhuo <[email protected]>
Some machines provide BIOS ACPI DSM (Device Specific Method) to translate memory system address to DRAM address (socket, memory controller, channel, rank, bank, row, column). This patch wraps the DSM methods, and registers them to EDAC core.
Quoted 4 lines
Why?
Why isn't this part of the ACPI core and why isn't it exporting proper interfaces for EDAC to use?
This isn't part of ACPI spec. Just a device specific method available to the OS. Someday, after we clean up the rough edges found by using it, we might submit it for inclusion in the ACPI spec. But we are a long way from that point.
Quoted 2 lines
This looks like a bunch of ACPI code outside of ACPI. And it is grafted on the EDAC core with an ops reg/dereg thing. Ewww.
We can put it someplace else if you have a better suggestion.
Quoted 2 lines
Can we please design this properly instead of just slapping it where it sticks?
Sure. I should have posted it as [RFC] rather than [PATCH].
The plan going forward is that EDAC drivers can be much smaller. They just need to discover memory controller and DIMM topology and register a handler on the mce_decode_chain. All the work in turning system addresses into DIMM addresses can be handled by a call to the BIOS (which knows how to do this, and the people writing it have resources to validate on way more configurations than I can).
-Tony