Skip to contentSkip to conversation

drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION

PATCH In review Arnd Bergmann 2 participants 2 messages Sep 26, 2018 – Sep 27, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION

The variable is declared in an #ifdef section, but the user is now unconditional, which leads to a build failure:

drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?

Remove the remaining #ifdef as well.

Fixes f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")
---
 drivers/gpu/drm/imx/imx-drm-core.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/imx/imx-drm-core.c +0 -2
index a70f3131a377..0e6942f21a4e 100644
@@ -35,10 +35,8 @@
 
 #define MAX_CRTC	4
 
-#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
 static int legacyfb_depth = 16;
 module_param(legacyfb_depth, int, 0444);
-#endif
 
 DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);
 
Signature · 1 line
2.18.0
#1 lore raw

Den 26.09.2018 21.38, skrev Arnd Bergmann:

Quoted 11 lines

The variable is declared in an #ifdef section, but the user is now unconditional, which leads to a build failure:

drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind':
drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you mean 'lockdep_depth'?

Remove the remaining #ifdef as well.

Fixes f53705fd9803 ("drm/imx: Use drm_fbdev_generic_setup()")

---

Thanks for fixing my mistakes Arnd.
Applied to drm-misc-next.

Noralf.

Quoted 18 lines
  drivers/gpu/drm/imx/imx-drm-core.c | 2 --
  1 file changed, 2 deletions(-)
drivers/gpu/drm/imx/imx-drm-core.c +0 -2
index a70f3131a377..0e6942f21a4e 100644
@@ -35,10 +35,8 @@
 
  #define MAX_CRTC	4
 
-#if IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION)
  static int legacyfb_depth = 16;
  module_param(legacyfb_depth, int, 0444);
-#endif
 
  DEFINE_DRM_GEM_CMA_FOPS(imx_drm_driver_fops);