9p: potential NULL dereference
Subsystems (4)
PATCH 1/1 9p: potential NULL dereference
p9_tag_alloc() is supposed to return error pointers, but we accidentally return a NULL here. It would cause a NULL dereference in the caller.
Fixes 996d5b4db4b1 ("9p: Use a slab for allocating requests")
Signed-off-by Dan Carpenter <[email protected]>
net/9p/client.c +1 -1
@@ -281,7 +281,7 @@ p9_tag_alloc(struct p9_client *c, int8_t type, unsigned int max_size)int tag;if (!req) -return NULL ; +return ERR_PTR (-ENOMEM );if (p9_fcall_init (c, &req->tc, alloc_msize)) goto free_req;
Dominique Martinet
maintainerDan Carpenter wrote on Wed, Sep 26, 2018:
Quoted 5 lines
p9_tag_alloc()is supposed to return error pointers, but we accidentally return a NULL here. It would cause a NULL dereference in the caller.Fixes 996d5b4db4b1 ("9p: Use a slab for allocating requests")Signed-off-by Dan Carpenter <[email protected]>
Good catch, the culprit commit is only in -next so just adding this to the queue right away.
Thanks!
Signature · 1 line
Dominique