Skip to contentSkip to conversation

mfd: arizona: Correct link for sound binding document

PATCH Applied Charles Keepax 3 participants 6 messages Sep 17, 2018 – Oct 31, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: arizona: Correct link for sound binding document

---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mfd/arizona.txt +1 -1
index 9b62831fdf3e..148ef621a5e5 100644
@@ -76,7 +76,7 @@ Deprecated properties:
 Also see child specific device properties:
   Regulator - ../regulator/arizona-regulator.txt
   Extcon    - ../extcon/extcon-arizona.txt
-  Sound     - ../sound/arizona.txt
+  Sound     - ../sound/wlf,arizona.txt
 
 Example:
 
Signature · 1 line
2.11.0
#2 lore raw
Quoted 7 lines · Rob Herring
Quoted 4 lines · Charles Keepax
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Probably won't do any harm in this instance, but it's usually better for MFD binding changes to go through the MFD tree to avoid merge-conflicts.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer
#3 lore raw
Quoted 9 lines · Lee Jones
Quoted 6 lines · Rob Herring
Quoted 4 lines · Charles Keepax
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines
Quoted 1 line

Applied.

Probably won't do any harm in this instance, but it's usually better for MFD binding changes to go through the MFD tree to avoid merge-conflicts.

It had been sitting there for a while, so I picked it up. Plus if we have conflicts within a binding (other than tree wide clean ups I do), that's not a good sign that the binding is changing.

Rob

#4 lore raw
Quoted 10 lines · Rob Herring
Quoted 9 lines · Lee Jones
Quoted 6 lines · Rob Herring
Quoted 4 lines · Charles Keepax
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Applied.

Probably won't do any harm in this instance, but it's usually better for MFD binding changes to go through the MFD tree to avoid merge-conflicts.

It had been sitting there for a while, so I picked it up. Plus if we

A little over a week is not 'a while'. :)

Quoted 2 lines

have conflicts within a binding (other than tree wide clean ups I do), that's not a good sign that the binding is changing.

Not sure I understand this.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
maintainer
#5 lore raw
Quoted 15 lines · Lee Jones
Quoted 12 lines · Rob Herring
Quoted 11 lines · Lee Jones
Quoted 7 lines · Rob Herring
Quoted 4 lines · Charles Keepax
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Probably won't do any harm in this instance, but it's usually better for MFD binding changes to go through the MFD tree to avoid merge-conflicts.

It had been sitting there for a while, so I picked it up. Plus if we

A little over a week is not 'a while'. :)

You're right. Probably should have waited 2 weeks. Developers shouldn't have to wait longer than that for a response (according to the chief penguin).

Quoted 4 lines
Quoted 2 lines

have conflicts within a binding (other than tree wide clean ups I do), that's not a good sign that the binding is changing.

Not sure I understand this.

If there are multiple sets of changes to a single binding within 1 release cycle (more than 1 really IMO), then that is a problem in and of itself. We may want drivers enhanced feature by feature, but I don't want bindings to. Bindings shouldn't be evolving. Maybe sometimes different people add different things, but then they need to work out the dependencies and conflicts, not you or me.

Rob