lib: Reuse Gen9 mediafill on Gen11
PATCH 1/2 lib: Reuse Gen9 mediafill on Gen11
From: Daniele Ceraolo Spurio <[email protected]>
We can reuse gen9 mediafill function, because no changes are required to support Gen11.
--- lib/intel_batchbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/intel_batchbuffer.c +1 -1
@@ -860,7 +860,7 @@ igt_fillfunc_t igt_get_media_fillfunc(int devid) {igt_fillfunc_t fill =NULL ; -if (IS_GEN9 (devid) ||IS_GEN10 (devid)) +if (IS_GEN9 (devid) ||IS_GEN10 (devid) ||IS_GEN11 (devid)) fill = gen9_media_fillfunc;else if (IS_GEN8 (devid)) fill = gen8_media_fillfunc;
Signature · 6 lines
2.19.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
PATCH 2/2 lib/gpgpu_fill: Implement gpgpu_fillfunc for Gen11
From: Katarzyna Dec <[email protected]>
Added gen11_gpgpu_fillfunc to have gpgpu_fill passing on Gen11.
Gpgpu shader was generated using IGA (Intel Graphics Assembler) based on binary found in lib/gpgpu_fill.c to match the changes in Gen11 HW:
Changed 'mul' instruction to 'shl' (since Gen11 'mul' does not support integer values for both src and dest). Changed SEND message descriptor (it should have length 2 not 3).
--- lib/gpgpu_fill.c | 23 +++++++++++++++++++++++ lib/gpgpu_fill.h | 7 +++++++ lib/intel_batchbuffer.c | 2 ++ 3 files changed, 32 insertions(+)
lib/gpgpu_fill.c +23 -0
@@ -74,6 +74,19 @@ static const uint32_t gen9_gpgpu_kernel[][4] = { { 0x07800031, 0x20000a40, 0x06000e00, 0x82000010 }, }; +static const uint32_t gen11_gpgpu_kernel[][4 ] = { + {0x00400001 ,0x20202288 ,0x00000020 ,0x00000000 }, + {0x00000009 ,0x20400208 ,0x06000004 ,0x00000004 }, + {0x00000001 ,0x20440208 ,0x00000018 ,0x00000000 }, + {0x00600001 ,0x20800208 ,0x008d0000 ,0x00000000 }, + {0x00200001 ,0x20800208 ,0x00450040 ,0x00000000 }, + {0x00000001 ,0x20880608 ,0x00000000 ,0x0000000f }, + {0x00800001 ,0x20a00208 ,0x00000020 ,0x00000000 }, + {0x0c800031 ,0x24000a40 ,0x06000080 ,0x040a8000 }, + {0x00600001 ,0x2e000208 ,0x008d0000 ,0x00000000 }, + {0x07800031 ,0x20000a40 ,0x06000e00 ,0x82000010 }, +}; +/* * This sets up the gpgpu pipeline, *
@@ -259,3 +272,13 @@ void gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch,__gen9_gpgpu_fillfunc (batch, dst, x, y, width, height, color, gen9_gpgpu_kernel,sizeof (gen9_gpgpu_kernel)); } + +void gen11_gpgpu_fillfunc (struct intel_batchbuffer *batch, +const struct igt_buf *dst, +unsigned int x,unsigned int y, +unsigned int width,unsigned int height, +uint8_t color) +{ +__gen9_gpgpu_fillfunc (batch, dst, x, y, width, height, color, + gen11_gpgpu_kernel,sizeof (gen11_gpgpu_kernel)); +}
lib/gpgpu_fill.h +7 -0
@@ -50,4 +50,11 @@ gen9_gpgpu_fillfunc(struct intel_batchbuffer *batch, unsigned int width, unsigned int height, uint8_t color); +void +gen11_gpgpu_fillfunc (struct intel_batchbuffer *batch, +const struct igt_buf *dst, +unsigned int x,unsigned int y, +unsigned int width,unsigned int height, +uint8_t color); +#endif /* GPGPU_FILL_H */
lib/intel_batchbuffer.c +2 -0
@@ -889,6 +889,8 @@ igt_fillfunc_t igt_get_gpgpu_fillfunc(int devid) fill = gen8_gpgpu_fillfunc; else if (IS_GEN9(devid) || IS_GEN10(devid)) fill = gen9_gpgpu_fillfunc; + else if (IS_GEN11(devid)) + fill = gen11_gpgpu_fillfunc;return fill; }
Signature · 6 lines
2.19.0 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [PATCH i-g-t 2/2] lib/gpgpu_fill: Implement gpgpu_fillfunc for Gen11
Quoted 11 lines · José Roberto de Souza
From: Katarzyna Dec <[email protected]>
Added
gen11_gpgpu_fillfuncto havegpgpu_fillpassing on Gen11.Gpgpu shader was generated using IGA (Intel Graphics Assembler) based on binary found in
lib/gpgpu_fill.cto match the changes in Gen11 HW:
Changed 'mul' instruction to 'shl' (since Gen11 'mul' does not support integer values for both src and dest). Changed SEND message descriptor (it should have length 2 not 3).
Quoted 5 lines
Cc Lukasz Kalamarz <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Katarzyna Dec <[email protected]>Signed-off-by Lukasz Kalamarz <[email protected]>
Kasia :)
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [PATCH i-g-t 2/2] lib/gpgpu_fill: Implement gpgpu_fillfunc for Gen11
Quoted 12 lines · Katarzyna Dec
Quoted 11 lines · José Roberto de Souza
From: Katarzyna Dec <[email protected]>
Added
gen11_gpgpu_fillfuncto havegpgpu_fillpassing on Gen11.Gpgpu shader was generated using IGA (Intel Graphics Assembler) based on binary found in
lib/gpgpu_fill.cto match the changes in Gen11 HW:
Changed 'mul' instruction to 'shl' (since Gen11 'mul' does not support integer values for both src and dest). Changed SEND message descriptor (it should have length 2 not 3).
Quoted 8 lines
Quoted 5 lines
Cc Lukasz Kalamarz <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Katarzyna Dec <[email protected]>Signed-off-by Lukasz Kalamarz <[email protected]>Acked-by Katarzyna Dec <[email protected]>Kasia :)
pushed, thanks
Quoted 4 lines
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Re: [igt-dev] [PATCH i-g-t 2/2] lib/gpgpu_fill: Implement gpgpu_fillfunc for Gen11
Quoting Rodrigo Vivi (2018-09-27 02:57:01)
Quoted 13 lines · Katarzyna Dec
Quoted 12 lines · José Roberto de Souza
Quoted 11 lines
From: Katarzyna Dec <[email protected]>
Added
gen11_gpgpu_fillfuncto havegpgpu_fillpassing on Gen11.Gpgpu shader was generated using IGA (Intel Graphics Assembler) based on binary found in
lib/gpgpu_fill.cto match the changes in Gen11 HW:
Changed 'mul' instruction to 'shl' (since Gen11 'mul' does not support integer values for both src and dest). Changed SEND message descriptor (it should have length 2 not 3).
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
Cc Lukasz Kalamarz <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Katarzyna Dec <[email protected]>Signed-off-by Lukasz Kalamarz <[email protected]>Acked-by Katarzyna Dec <[email protected]>Kasia :)
I'm fairly sure the addition of the source code and compiling instructions was brought up in the early review of the series.
Any reason not following through with it?
Regards, Joonas
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 5 lines · José Roberto de Souza
From: Daniele Ceraolo Spurio <[email protected]>
We can reuse gen9 mediafill function, because no changes are required to support Gen11.
Quoted 8 lines
Cc Daniele Ceraolo Spurio <[email protected]>Cc Katarzyna Dec <[email protected]>Cc Lucas De Marchi <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Daniele Ceraolo Spurio <[email protected]>Signed-off-by Katarzyna Dec <[email protected]>---
Kasia :)
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
URL : https://patchwork.freedesktop.org/series/49872/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4836 -> IGTPW_1855 =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1855 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_1855, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49872/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1855:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-no-display:
fi-bsw-kefka: NOTRUN -> DMESG-WARN== Known issues ==
Here are the changes found in IGTPW_1855 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: PASS -> INCOMPLETE (fdo#107773)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-WARN (fdo#102614)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: NOTRUN -> FAIL (fdo#103191, fdo#107362)
igt@kms_psr@primary_page_flip:
fi-whl-u: PASS -> FAIL (fdo#107336)
==== Possible fixes ====
igt@drv_getparams_basic@basic-subslice-total:
fi-snb-2520m: DMESG-WARN (fdo#103713) -> PASS +9
igt@drv_module_reload@basic-reload:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@gem_mmap_gtt@basic-read-write:
fi-glk-dsi: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (47 -> 47) ==
Additional (6): fi-gdg-551 fi-pnv-d510 fi-elk-e7500 fi-bsw-kefka fi-byt-clapper fi-skl-6700hq
Missing (6): fi-kbl-soraka fi-cnl-u fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4645 -> IGTPW_1855
CI_DRM_4836: b2b0444aa439ade1ed809a91a19d382fbb5e7700 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1855: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1855/
IGT_4645: 03b90a39ed12a568c9da752466ea708d6348e110 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1855/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
URL : https://patchwork.freedesktop.org/series/49872/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4844 -> IGTPW_1863 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1863 need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_1863, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49872/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1863:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@module-reload:
fi-hsw-4770r: SKIP -> PASS== Known issues ==
Here are the changes found in IGTPW_1863 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-bdw-samus: PASS -> INCOMPLETE (fdo#107773)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-glk-j4005: DMESG-WARN (fdo#106725, fdo#106248) -> PASS
igt@drv_module_reload@basic-reload-inject:
fi-hsw-4770r: DMESG-WARN (fdo#107924, fdo#107425) -> PASS
igt@drv_selftest@mock_hugepages:
fi-bwr-2160: DMESG-FAIL (fdo#107930) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128, fdo#107139) -> PASS
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
igt@kms_psr@primary_mmap_gtt:
fi-cnl-u: FAIL (fdo#107383) -> PASS +3
igt@pm_rpm@module-reload:
fi-glk-j4005: DMESG-WARN (fdo#107726) -> PASS fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
fdo#107930 https://bugs.freedesktop.org/show_bug.cgi?id=107930
== Participating hosts (52 -> 47) ==
Additional (1): fi-gdg-551
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4646 -> IGTPW_1863
CI_DRM_4844: 73c0da2189956c18a0fff343bd84eb0493f81db1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1863: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1863/
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1863/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: series starting with [i-g-t,1/2] lib: Reuse Gen9 mediafill on Gen11
URL : https://patchwork.freedesktop.org/series/49872/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4646_full -> IGTPW_1863_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1863_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_1863_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49872/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1863_full:
=== IGT changes ===
==== Warnings ====
igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-ytiled:
shard-apl: PASS -> SKIP +12== Known issues ==
Here are the changes found in IGTPW_1863_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-glk: PASS -> DMESG-WARN (fdo#107956)
igt@kms_plane@pixel-format-pipe-a-planes:
shard-snb: PASS -> FAIL (fdo#107749, fdo#103166)
igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
shard-apl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +36
igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
==== Possible fixes ====
igt@gem_userptr_blits@readonly-pwrite-unsync:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS +1
igt@kms_chv_cursor_fail@pipe-a-64x64-bottom-edge:
shard-glk: FAIL (fdo#104671) -> PASS
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-xtiled:
shard-glk: FAIL (fdo#103184) -> PASS
igt@kms_fbcon_fbt@fbc-suspend:
shard-snb: DMESG-WARN (fdo#102365) -> PASS
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-indfb-fliptrack:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-msflip-blt:
shard-glk: FAIL (fdo#103167) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-snb: FAIL (fdo#103166) -> PASS fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104671 https://bugs.freedesktop.org/show_bug.cgi?id=104671
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4646 -> IGTPW_1863
* Linux: CI_DRM_4836 -> CI_DRM_4844
CI_DRM_4836: b2b0444aa439ade1ed809a91a19d382fbb5e7700 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4844: 73c0da2189956c18a0fff343bd84eb0493f81db1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1863: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1863/
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1863/shards.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev