Skip to contentSkip to conversation

staging: rtl8188eu: Use proper enum in rtl8188eu_config_rf_reg

PATCH New Nathan Chancellor 1 participant 1 message Sep 27, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: Use proper enum in rtl8188eu_config_rf_reg

Clang warns when an enumerated type is implicitly converted to another.

drivers/staging/rtl8188eu/hal/rf_cfg.c:180:25: warning: implicit conversion from enumeration type 'enum rf90_radio_path' to different enumeration type 'enum rf_radio_path' [-Wenum-conversion]
rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
~~~~~~~~~~~~~~~ ^~~~~~~~~~~
1 warning generated.

Avoid this by using the equivalent value from the expected type, rf_radio_path:

RF90_PATH_A = RF_PATH_A = 0

---
 drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/rf_cfg.c +1 -1
index 0700d8bd448d..02aeb12c9870 100644
@@ -177,7 +177,7 @@ static void rtl8188e_config_rf_reg(struct adapter *adapt,
 	u32 content = 0x1000; /*RF Content: radio_a_txt*/
 	u32 maskforphyset = content & 0xE000;
 
-	rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
+	rtl_rfreg_delay(adapt, RF_PATH_A, addr | maskforphyset,
 			RFREG_OFFSET_MASK,
 			data);
 }
Signature · 1 line
2.19.0