drm/i915/aml: Add new Amber Lake PCI ID
Subsystems (2)
PATCH v2 1/1 drm/i915/aml: Add new Amber Lake PCI ID
This new AML PCI ID uses the same gen graphics as Coffe Lake not a Kaby Lake one like the other AMLs.
So to make it more explicit renaming INTEL_AML_GT2_IDS to INTEL_AML_KBL_GT2_IDS and naming this id as INTEL_AML_CFL_GT2_IDS.
v2:
- missed add new AML macro to INTEL_CFL_IDS()
- added derivated platform initials to AML macros
--- drivers/gpu/drm/i915/i915_pci.c | 3 ++- include/drm/i915_pciids.h | 11 ++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_pci.c +2 -1
@@ -665,7 +665,7 @@ static const struct pci_device_id pciidlist[] = {INTEL_KBL_GT2_IDS (&intel_kabylake_gt2_info),INTEL_KBL_GT3_IDS (&intel_kabylake_gt3_info),INTEL_KBL_GT4_IDS (&intel_kabylake_gt3_info), -INTEL_AML_GT2_IDS (&intel_kabylake_gt2_info), +INTEL_AML_KBL_GT2_IDS (&intel_kabylake_gt2_info),INTEL_CFL_S_GT1_IDS (&intel_coffeelake_gt1_info),INTEL_CFL_S_GT2_IDS (&intel_coffeelake_gt2_info), INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
@@ -673,6 +673,7 @@ static const struct pci_device_id pciidlist[] = {INTEL_CFL_U_GT3_IDS (&intel_coffeelake_gt3_info),INTEL_WHL_U_GT1_IDS (&intel_coffeelake_gt1_info),INTEL_WHL_U_GT2_IDS (&intel_coffeelake_gt2_info), +INTEL_AML_CFL_GT2_IDS (&intel_coffeelake_gt2_info),INTEL_WHL_U_GT3_IDS (&intel_coffeelake_gt3_info),INTEL_CNL_IDS (&intel_cannonlake_info), INTEL_ICL_11_IDS(&intel_icelake_11_info),
include/drm/i915_pciids.h +8 -3
@@ -365,16 +365,20 @@INTEL_VGA_DEVICE (0x593B , info)/* Halo GT4 */ /* AML/KBL Y GT2 */ -#define INTEL_AML_GT2_IDS (info) \ +#define INTEL_AML_KBL_GT2_IDS (info) \ INTEL_VGA_DEVICE(0x591C, info),/* ULX GT2 */ \INTEL_VGA_DEVICE (0x87C0 , info)/* ULX GT2 */ +/* AML/CFL Y GT2 */ +#define INTEL_AML_CFL_GT2_IDS (info) \ + INTEL_VGA_DEVICE(0x87CA, info) +#define INTEL_KBL_IDS (info) \ INTEL_KBL_GT1_IDS(info), \ INTEL_KBL_GT2_IDS(info), \ INTEL_KBL_GT3_IDS(info), \ INTEL_KBL_GT4_IDS(info), \ - INTEL_AML_GT2_IDS(info) + INTEL_AML_KBL_GT2_IDS(info)/* CFL S */ #define INTEL_CFL_S_GT1_IDS (info) \
@@ -427,7 +431,8 @@INTEL_CFL_U_GT3_IDS (info), \INTEL_WHL_U_GT1_IDS (info), \INTEL_WHL_U_GT2_IDS (info), \ -INTEL_WHL_U_GT3_IDS (info) +INTEL_WHL_U_GT3_IDS (info), \ +INTEL_AML_CFL_GT2_IDS (info) /* CNL */#define INTEL_CNL_IDS (info) \
Signature · 6 lines
2.19.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for drm/i915/aml: Add new Amber Lake PCI ID (rev2)
== Series Details ==
== Series Details ==
Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL : https://patchwork.freedesktop.org/series/50037/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip b83389a0d094 drm/i915/aml: Add new Amber Lake PCI ID -:52: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #52: FILE: include/drm/i915_pciids.h:368: +#define INTEL_AML_KBL_GT2_IDS(info) \ INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \ INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
-:52: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects? #52: FILE: include/drm/i915_pciids.h:368:
+#define INTEL_AML_KBL_GT2_IDS(info) \
INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
total: 1 errors, 0 warnings, 1 checks, 46 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915/aml: Add new Amber Lake PCI ID (rev2)
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL : https://patchwork.freedesktop.org/series/50037/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4888 -> Patchwork_10289 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10289 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10289, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50037/revisions/2/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10289:
=== IGT changes ===
==== Possible regressions ====
igt@gem_mmap_gtt@basic-wc:
fi-blb-e6850: PASS -> FAIL== Known issues ==
Here are the changes found in Patchwork_10289 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
fi-icl-u: NOTRUN -> DMESG-WARN (fdo#108071) +1
igt@drv_module_reload@basic-reload:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: PASS -> INCOMPLETE (fdo#107773)
igt@kms_psr@primary_page_flip:
fi-icl-u: NOTRUN -> DMESG-WARN (fdo#108070) +11
==== Possible fixes ====
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: DMESG-WARN (fdo#105998) -> PASS +1
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-c:
fi-skl-6700k2: FAIL (fdo#103191) -> PASS
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: FAIL (fdo#107336) -> PASS
==== Warnings ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-icl-u: INCOMPLETE (fdo#107713) -> DMESG-WARN (fdo#108070) fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107713 https://bugs.freedesktop.org/show_bug.cgi?id=107713
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#108070 https://bugs.freedesktop.org/show_bug.cgi?id=108070
fdo#108071 https://bugs.freedesktop.org/show_bug.cgi?id=108071
== Participating hosts (44 -> 40) ==
Additional (1): fi-snb-2520m
Missing (5): fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2 fi-glk-j4005
== Build changes ==
* Linux: CI_DRM_4888 -> Patchwork_10289
CI_DRM_4888: 7387ec51878c0d3d2df48c697a22cf9e6c60a3c9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4652: 83352d08b52acd6ee677f9f62dd032b0b8d31835 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10289: b83389a0d0940f1998e067c427d4b87224e7e759 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b83389a0d094 drm/i915/aml: Add new Amber Lake PCI ID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10289/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/aml: Add new Amber Lake PCI ID (rev2)
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL : https://patchwork.freedesktop.org/series/50037/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4944 -> Patchwork_10382 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50037/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10382 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
fi-bsw-n3050: PASS -> DMESG-WARN (fdo#106207) +22
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-cfl-8109u: PASS -> INCOMPLETE (fdo#108126, fdo#106070)
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
igt@pm_rpm@module-reload:
fi-glk-j4005: DMESG-WARN (fdo#107726) -> PASS fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#106207 https://bugs.freedesktop.org/show_bug.cgi?id=106207
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
== Participating hosts (45 -> 40) ==
Missing (5): fi-ctg-p8600 fi-bsw-cyan fi-ilk-m540 fi-byt-squawks fi-icl-u2
== Build changes ==
* Linux: CI_DRM_4944 -> Patchwork_10382
CI_DRM_4944: 66bd263b99fd264b57432c232756baf95b0a6255 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4670: 7e066794d2ea860f4199fd67549080de17b6b852 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10382: 51a09360297d698c32e82227b8ae922984082480 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
51a09360297d drm/i915/aml: Add new Amber Lake PCI ID
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10382/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/aml: Add new Amber Lake PCI ID (rev2)
In reply to José Roberto de Souza== Series Details ==
== Series Details ==
Series: drm/i915/aml: Add new Amber Lake PCI ID (rev2)
URL : https://patchwork.freedesktop.org/series/50037/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4944_full -> Patchwork_10382_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10382_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10382_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10382_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: SKIP -> PASS== Known issues ==
Here are the changes found in Patchwork_10382_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_cpu_reloc@full:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108073)
igt@gem_exec_await@wide-contexts:
shard-glk: PASS -> FAIL (fdo#106680)
igt@gem_exec_big:
shard-hsw: PASS -> TIMEOUT (fdo#107937)
igt@gem_exec_schedule@pi-ringfull-blt:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_cursor_crc@cursor-128x128-dpms:
shard-skl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-256x256-random:
shard-glk: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-apl: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763)
igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-xtiled:
shard-skl: PASS -> FAIL (fdo#103184)
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363) +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-skl: NOTRUN -> FAIL (fdo#103167)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
shard-glk: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
shard-skl: PASS -> FAIL (fdo#103167) +4
igt@kms_plane@pixel-format-pipe-c-planes:
shard-skl: NOTRUN -> DMESG-WARN (fdo#106885)
igt@kms_plane@plane-panning-top-left-pipe-a-planes:
shard-skl: PASS -> FAIL (fdo#103166)
{igt@kms_plane_alpha_blend@pipe-a-coverage-7efc}:
shard-skl: PASS -> FAIL (fdo#108145)
{igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +3
igt@kms_rotation_crc@exhaust-fences:
shard-skl: NOTRUN -> DMESG-WARN (fdo#105748)
igt@kms_universal_plane@universal-plane-pipe-b-functional:
shard-glk: PASS -> FAIL (fdo#103166)
==== Possible fixes ====
igt@gem_pwrite_pread@display-pwrite-blt-gtt_mmap-performance:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_cursor_crc@cursor-256x85-random:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-glk: FAIL (fdo#103232) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
shard-glk: FAIL (fdo#103167) -> PASS +7
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-apl: FAIL (fdo#103166) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-glk: FAIL (fdo#103166) -> PASS +4 {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105748 https://bugs.freedesktop.org/show_bug.cgi?id=105748
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4944 -> Patchwork_10382
CI_DRM_4944: 66bd263b99fd264b57432c232756baf95b0a6255 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4670: 7e066794d2ea860f4199fd67549080de17b6b852 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10382: 51a09360297d698c32e82227b8ae922984082480 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10382/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · José Roberto de Souza
This new AML PCI ID uses the same gen graphics as Coffe Lake not a Kaby Lake one like the other AMLs.
So to make it more explicit renaming
INTEL_AML_GT2_IDStoINTEL_AML_KBL_GT2_IDSand naming this id asINTEL_AML_CFL_GT2_IDS.
Quoted 6 lines
v2:
- missed add new AML macro toINTEL_CFL_IDS()
- added derivated platform initials to AML macrosReviewed-by Rodrigo Vivi <[email protected]>Signed-off-by José Roberto de Souza <[email protected]>
pushed to dinq.
Quoted 70 lines
--- drivers/gpu/drm/i915/i915_pci.c | 3 ++- include/drm/i915_pciids.h | 11 ++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/i915_pci.c +2
-1@@ -665,7 +665,7 @@ static const struct pci_device_id pciidlist[] = {INTEL_KBL_GT2_IDS (&intel_kabylake_gt2_info),INTEL_KBL_GT3_IDS (&intel_kabylake_gt3_info),INTEL_KBL_GT4_IDS (&intel_kabylake_gt3_info), -INTEL_AML_GT2_IDS (&intel_kabylake_gt2_info), +INTEL_AML_KBL_GT2_IDS (&intel_kabylake_gt2_info),INTEL_CFL_S_GT1_IDS (&intel_coffeelake_gt1_info),INTEL_CFL_S_GT2_IDS (&intel_coffeelake_gt2_info), INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),@@ -673,6 +673,7 @@ static const struct pci_device_id pciidlist[] = {INTEL_CFL_U_GT3_IDS (&intel_coffeelake_gt3_info),INTEL_WHL_U_GT1_IDS (&intel_coffeelake_gt1_info),INTEL_WHL_U_GT2_IDS (&intel_coffeelake_gt2_info), +INTEL_AML_CFL_GT2_IDS (&intel_coffeelake_gt2_info),INTEL_WHL_U_GT3_IDS (&intel_coffeelake_gt3_info),INTEL_CNL_IDS (&intel_cannonlake_info), INTEL_ICL_11_IDS(&intel_icelake_11_info),include/drm/i915_pciids.h +8
-3@@ -365,16 +365,20 @@INTEL_VGA_DEVICE (0x593B , info)/* Halo GT4 */ /* AML/KBL Y GT2 */ -#define INTEL_AML_GT2_IDS (info) \ +#define INTEL_AML_KBL_GT2_IDS (info) \ INTEL_VGA_DEVICE(0x591C, info),/* ULX GT2 */ \INTEL_VGA_DEVICE (0x87C0 , info)/* ULX GT2 */ +/* AML/CFL Y GT2 */ +#define INTEL_AML_CFL_GT2_IDS (info) \ + INTEL_VGA_DEVICE(0x87CA, info) +#define INTEL_KBL_IDS (info) \ INTEL_KBL_GT1_IDS(info), \ INTEL_KBL_GT2_IDS(info), \ INTEL_KBL_GT3_IDS(info), \ INTEL_KBL_GT4_IDS(info), \ - INTEL_AML_GT2_IDS(info) + INTEL_AML_KBL_GT2_IDS(info)/* CFL S */ #define INTEL_CFL_S_GT1_IDS (info) \@@ -427,7 +431,8 @@INTEL_CFL_U_GT3_IDS (info), \INTEL_WHL_U_GT1_IDS (info), \INTEL_WHL_U_GT2_IDS (info), \ -INTEL_WHL_U_GT3_IDS (info) +INTEL_WHL_U_GT3_IDS (info), \ +INTEL_AML_CFL_GT2_IDS (info) /* CNL */#define INTEL_CNL_IDS (info) \Signature · 6 lines
2.19.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx