Skip to contentSkip to conversation

arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address

PATCH In review Vignesh R 4 participants 5 messages Sep 27, 2018 – Nov 9, 2018

Subsystems (2)
lore
Share & tools
lore

Vignesh R

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address

cbass_wakeup interconnect which is the parent of wakeup_uart node defines address-cells=1 and size-cells=1, therefore fix up reg property of wakeup_uart node accordingly. Otherwise, this UART instance fails to probe if enabled.

Fixes 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")

---

Based on next-20180926

 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
index ee56959f4af8..c617393ea767 100644
@@ -44,7 +44,7 @@
 
 	wkup_uart0: serial@42300000 {
 		compatible = "ti,am654-uart";
-		reg = <0x00 0x42300000 0x00 0x100>;
+		reg = <0x42300000 0x100>;
 		reg-shift = <2>;
 		reg-io-width = <4>;
 		interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.19.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Vignesh R

cbass_wakeup interconnect which is the parent of wakeup_uart node defines address-cells=1 and size-cells=1, therefore fix up reg property of wakeup_uart node accordingly. Otherwise, this UART instance fails to probe if enabled.

Fixes 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")

Thanks and regards,
Lokesh

maintainer
#2 lore raw
Quoted 8 lines · Lokesh
Quoted 5 lines · Vignesh R

cbass_wakeup interconnect which is the parent of wakeup_uart node defines address-cells=1 and size-cells=1, therefore fix up reg property of wakeup_uart node accordingly. Otherwise, this UART instance fails to probe if enabled.

Quoted 4 lines
Quoted 2 lines
Fixes 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")

Tero:

Could we pick this up for rc2? looks like $subject might be good to fix up to:
arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address instead of
arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address

could be fixed locally.

Signature · 2 lines
Regards,
Nishanth Menon
#3 lore raw
Quoted 16 lines · Nishanth Menon
Quoted 8 lines · Lokesh
Quoted 5 lines · Vignesh R

cbass_wakeup interconnect which is the parent of wakeup_uart node defines address-cells=1 and size-cells=1, therefore fix up reg property of wakeup_uart node accordingly. Otherwise, this UART instance fails to probe if enabled.

Quoted 4 lines
Quoted 2 lines
Fixes 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")

Tero:

Quoted 8 lines

Could we pick this up for rc2? looks like $subject might be good to fix up to:
arm64: dts: ti: k3-am65-wakeup: Fix wakeup_uart reg address instead of
arm64: dts: k3-am65-wakeup: Fix wakeup_uart reg address

could be fixed locally.

Thanks, queued up for 4.20-rc.

-Tero

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

maintainer Acked-by on v1 1/1
#4 lore raw
In reply to Vignesh R
Quoted 19 lines · Vignesh R

cbass_wakeup interconnect which is the parent of wakeup_uart node defines address-cells=1 and size-cells=1, therefore fix up reg property of wakeup_uart node accordingly. Otherwise, this UART instance fails to probe if enabled.

Fixes 4201af2544b3 ("arm64: dts: ti: am654: Add uart nodes")

---

Based on next-20180926

 arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +0 -0
index ee56959f4af8..c617393ea767 100644

arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi line 50

Quoted 8 lines
arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi +1 -1
@@ -44,7 +44,7 @@
 
 	wkup_uart0: serial at 42300000 {
 		compatible = "ti,am654-uart";
-		reg = <0x00 0x42300000 0x00 0x100>;
+		reg = <0x42300000 0x100>;
 		reg-shift = <2>;
 		reg-io-width = <4>;
 		interrupts = <GIC_SPI 697 IRQ_TYPE_LEVEL_HIGH>;

Thanks. Tero: we should probably queue for rc fixes. wkup_uart is used by System Firmware logs (if enabled), so kernel usage is limited to some specific platforms. This is a valid fix and my miss..

Signature · 2 lines
Regards,
Nishanth Menon