Skip to contentSkip to conversation

net: dsa: b53: Fix build with B53_SRAB enabled and B53_SERDES=m

PATCH Applied Arnd Bergmann 3 participants 4 messages Sep 27, 2018 – Sep 28, 2018

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: dsa: b53: Fix build with B53_SRAB enabled and B53_SERDES=m

When B53_SERDES is a loadable module, a built-in srab driver still cannot reach it, so the previous fix is incomplete:

b53_srab.c:(.text+0x3f4): undefined reference to b53_serdes_init' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to b53_serdes_link_state' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to b53_serdes_link_set' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to b53_serdes_an_restart' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to b53_serdes_phylink_validate' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to b53_serdes_config'

Add a Kconfig dependency that forces srab to also be a module in this case, but allow it to be built-in when serdes is disabled or built-in.

Fixes 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES")
---
 drivers/net/dsa/b53/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dsa/b53/Kconfig +1 -0
index e83ebfafd881..d32469283f97 100644
@@ -31,6 +31,7 @@ config B53_MMAP_DRIVER
 config B53_SRAB_DRIVER
 	tristate "B53 SRAB connected switch driver"
 	depends on B53 && HAS_IOMEM
+	depends on B53_SERDES || !B53_SERDES
 	default ARCH_BCM_IPROC
 	help
 	  Select to enable support for memory-mapped Switch Register Access
Signature · 1 line
2.18.0
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Arnd Bergmann

When B53_SERDES is a loadable module, a built-in srab driver still cannot reach it, so the previous fix is incomplete:

b53_srab.c:(.text+0x3f4): undefined reference to b53_serdes_init' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to b53_serdes_link_state' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to b53_serdes_link_set' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to b53_serdes_an_restart' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to b53_serdes_phylink_validate' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to b53_serdes_config'

Quoted 6 lines

Add a Kconfig dependency that forces srab to also be a module in this case, but allow it to be built-in when serdes is disabled or built-in.

Fixes 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES")

Thanks!

Signature · 1 line
Florian
maintainer Applied
#2 lore raw

From: Florian Fainelli <[email protected]>
Date: Thu, 27 Sep 2018 12:07:01 -0700

Quoted 11 lines · Arnd Bergmann
Quoted 10 lines

When B53_SERDES is a loadable module, a built-in srab driver still cannot reach it, so the previous fix is incomplete:

b53_srab.c:(.text+0x3f4): undefined reference to b53_serdes_init' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to b53_serdes_link_state' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to b53_serdes_link_set' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to b53_serdes_an_restart' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to b53_serdes_phylink_validate' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to b53_serdes_config'

Quoted 8 lines
Quoted 6 lines

Add a Kconfig dependency that forces srab to also be a module in this case, but allow it to be built-in when serdes is disabled or built-in.

Fixes 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES")

Applied, thanks Arnd.

maintainer Applied
#3 lore raw
In reply to Arnd Bergmann

From: Arnd Bergmann <[email protected]>
Date: Thu, 27 Sep 2018 12:02:38 +0200

Quoted 10 lines

When B53_SERDES is a loadable module, a built-in srab driver still cannot reach it, so the previous fix is incomplete:

b53_srab.c:(.text+0x3f4): undefined reference to b53_serdes_init' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe64): undefined reference to b53_serdes_link_state' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe74): undefined reference to b53_serdes_link_set' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xe88): undefined reference to b53_serdes_an_restart' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea0): undefined reference to b53_serdes_phylink_validate' drivers/net/dsa/b53/b53_srab.o:(.rodata+0xea4): undefined reference to b53_serdes_config'

Quoted 6 lines

Add a Kconfig dependency that forces srab to also be a module in this case, but allow it to be built-in when serdes is disabled or built-in.

Fixes 7a8c7f5c30f9 ("net: dsa: b53: Fix build with B53_SRAB enabled and not B53_SERDES")

Applied, thanks Arnd.