drm/amdgpu/vega20: make power profile output more consistent
Subsystems (2)
PATCH 1/1 drm/amdgpu/vega20: make power profile output more consistent
Make the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1 -1
@@ -3165,7 +3165,7 @@ static int vega20_get_power_profile_mode(struct pp_hwmgr *hwmgr, char *buf)"[GetPowerProfile] Failed to get activity monitor!" , return result); - size +=sprintf (buf + size,"%2d(%14s%s)\n" , + size +=sprintf (buf + size,"%2d %14s%s:\n" , i, profile_name[i], (i == hwmgr->power_profile_mode) ?"*" :" " ); size += sprintf(buf + size, "%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n",
Signature · 6 lines
2.13.6 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180927134611.23292-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org
Quan, Evan
Reviewed-by Evan QuanQuoted 42 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2018年9月27日 21:46
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/vega20: make power profile output more consistentMake the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1
-1@@ -3165,7 +3165,7 @@ static int vega20_get_power_profile_mode(struct pp_hwmgr *hwmgr, char *buf) "[GetPowerProfile] Failed to get activity monitor!", return result); - size += sprintf(buf + size, "%2d(%14s%s)\n", + size += sprintf(buf + size, "%2d %14s%s:\n", i, profile_name[i], (i == hwmgr-Quoted 1 line
power_profile_mode) ? "*" : " ");size += sprintf(buf + size,
"%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", --
2.13.6
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): SN6PR12MB2656AB0BD38E90CF91B2B8E6E4EC0-kxOKjb6HO/FeL/[email protected]
[+Kent]
This may break the rocm-smi tool, which parses the power profile output.
Regards,
Felix
Quoted 43 lines · Evan
Reviewed-by Evan Quan <[email protected]>Quoted 41 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2018年9月27日 21:46
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/vega20: make power profile output more consistentMake the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1
-1@@ -3165,7 +3165,7 @@ static int vega20_get_power_profile_mode(struct pp_hwmgr *hwmgr, char *buf) "[GetPowerProfile] Failed to get activity monitor!", return result); - size += sprintf(buf + size, "%2d(%14s%s)\n", + size += sprintf(buf + size, "%2d %14s%s:\n", i, profile_name[i], (i == hwmgr-Quoted 1 line
power_profile_mode) ? "*" : " ");size += sprintf(buf + size,
"%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", --
2.13.6
Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): fdc500ca-a2b4-6270-3c0d-74bf5c842796-5C7GfCeVMHo@public.gmane.org
Quoted 11 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Felix Kuehling
Sent: Monday, October 1, 2018 3:49 PM
To: Quan, Evan <[email protected]>; Alex Deucher <[email protected]>; [email protected]; Russell, Kent <[email protected]>
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu/vega20: make power profile output more consistent
Quoted 4 lines
[+Kent]
This may break the rocm-smi tool, which parses the power profile output.
This was at the request of rocm-smi. Since the current rocm-smi couldn't parse the new format. This makes it more similar to previous asics.
Alex
Quoted 58 lines
Regards,
FelixQuoted 23 lines · Evan
Reviewed-by Evan Quan <[email protected]>Quoted 21 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2018年9月27日 21:46
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/vega20: make power profile output more consistentMake the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int
Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0@@ -3165,7 +3165,7 @@ static intvega20_get_power_profile_mode(struct
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int · line 3166
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0pp_hwmgr *hwmgr, char *buf) "[GetPowerProfile] Failed to get activitymonitor!",
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1
-1return result); - size +=sprintf (buf + size,"%2d(%14s%s)\n" , + size +=sprintf (buf + size,"%2d %14s%s:\n" , i, profile_name[i], (i == hwmgr- > power_profile_mode) ? "*" : " ");size += sprintf(buf + size,
"%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", --
2.13.6Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1809F36A067CA1ACF6B61CB4F7EF0-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Quoted 11 lines · Alexander
Quoted 11 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Felix Kuehling
Sent: Monday, October 1, 2018 3:49 PM
To: Quan, Evan <[email protected]>; Alex Deucher <[email protected]>; [email protected]; Russell, Kent <[email protected]>
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu/vega20: make power profile output more consistent
Quoted 5 lines
Quoted 4 lines
[+Kent]
This may break the rocm-smi tool, which parses the power profile output.
This was at the request of rocm-smi. Since the current rocm-smi couldn't parse the new format. This makes it more similar to previous asics.
Thanks! I missed that this was for Vega20.
Regards,
Felix
Quoted 64 lines
Alex
Quoted 61 lines
Regards,
FelixQuoted 23 lines · Evan
Reviewed-by Evan Quan <[email protected]>Quoted 21 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2018年9月27日 21:46
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/vega20: make power profile output more consistentMake the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int
Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0@@ -3165,7 +3165,7 @@ static intvega20_get_power_profile_mode(struct
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int · line 3166
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0pp_hwmgr *hwmgr, char *buf) "[GetPowerProfile] Failed to get activitymonitor!",
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1
-1return result); - size +=sprintf (buf + size,"%2d(%14s%s)\n" , + size +=sprintf (buf + size,"%2d %14s%s:\n" , i, profile_name[i], (i == hwmgr- > power_profile_mode) ? "*" : " ");size += sprintf(buf + size,
"%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", --
2.13.6Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): ec5c529b-5b76-45df-641b-5a57d6350899-5C7GfCeVMHo@public.gmane.org
I don't do any parsing of the names of the Power Profiles in the SMI, this was just for the smi_lib which expects specific string formats. I had no issues with it, since it wouldn't muck with the SMI as it currently exists. But it will help if I decide to try to parse these in the SMI tool in the future.
Kent
-----Original Message-----
From: Kuehling, Felix
Sent: Monday, October 01, 2018 4:34 PM
To: Deucher, Alexander <[email protected]>; Quan, Evan <[email protected]>; Alex Deucher <[email protected]>; [email protected]; Russell, Kent <[email protected]>
Subject: Re: [PATCH] drm/amdgpu/vega20: make power profile output more consistent
Quoted 11 lines · Alexander
Quoted 11 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Felix Kuehling
Sent: Monday, October 1, 2018 3:49 PM
To: Quan, Evan <[email protected]>; Alex Deucher <[email protected]>; [email protected]; Russell, Kent <[email protected]>
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu/vega20: make power profile output more consistent
Quoted 5 lines
Quoted 4 lines
[+Kent]
This may break the rocm-smi tool, which parses the power profile output.
This was at the request of rocm-smi. Since the current rocm-smi couldn't parse the new format. This makes it more similar to previous asics.
Thanks! I missed that this was for Vega20.
Regards,
Felix
Quoted 64 lines
Alex
Quoted 61 lines
Regards,
FelixQuoted 23 lines · Evan
Reviewed-by Evan Quan <[email protected]>Quoted 21 lines
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: 2018年9月27日 21:46
To: [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: [PATCH] drm/amdgpu/vega20: make power profile output more consistentMake the profile name line match previous generations more closely.
E.g.,
0 3D_FULL_SCREEN :
vs:
0(3D_FULL_SCREEN )Signed-off-by Alex Deucher <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int
Quoted 6 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0@@ -3165,7 +3165,7 @@ static intvega20_get_power_profile_mode(struct
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c static int · line 3166
Quoted 2 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +0
-0pp_hwmgr *hwmgr, char *buf) "[GetPowerProfile] Failed to get activitymonitor!",
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +1
-1return result); - size +=sprintf (buf + size,"%2d(%14s%s)\n" , + size +=sprintf (buf + size,"%2d %14s%s:\n" , i, profile_name[i], (i == hwmgr- > power_profile_mode) ? "*" : " ");size += sprintf(buf + size,
"%19s %d(%13s) %7d %7d %7d %7d %7d %7d %7d %7d %7d\n", --
2.13.6Quoted 8 lines
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx