Skip to contentSkip to conversation

44/47: tsocks: Add -lssp_nonshared to LIBS explicitly on musl

oe-commits In review Martin Jansa 2 participants 4 messages Sep 27, 2018 – Sep 29, 2018 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Is this really musl specific? I'm seeing the same failure with glibc qemux86 build with security_flags included:

| tsocks.c:954: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:842: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:339: error: undefined reference to '__stack_chk_fail_local'
| tsocks.c:522: error: undefined reference to '__stack_chk_fail_local'
| collect2: error: ld returned 1 exit status
| Makefile:53: recipe for target 'libtsocks.so.1.8' failed
| make: *** [libtsocks.so.1.8] Error 1
Quoted 55 lines · On Tue, Sep 25, 2018 at 6:19 PM <[email protected]> wrote:

This is an automated email from the git hooks/post-receive script.

khem pushed a commit to branch master-next
in repository meta-openembedded.

commit 4a0e53cb229f97e9cc3dd925b8db334e07b85768
Author: Khem Raj <[email protected]>
AuthorDate: Mon Sep 24 10:57:13 2018 -0700

tsocks: Add -lssp_nonshared to LIBS explicitly on musl

tsocks uses -nostdlib while linking shared library, which is not ideal but instead of chasing that and assuming there is a reason for that, we add -lssp_noshared to linker command at the end so it can build when security flags are enabled

Fixes
tsocks.c:954: undefined reference to `__stack_chk_fail_local'

---
 meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +0 -0
index b2757f6..7291357 100644
@@ -18,11 +18,13 @@ SRC_URI[sha256sum] =

"849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863

inherit autotools-brokensep

meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +3 -2
+LIBS_append_libc-musl = " -lssp_nonshared"
+
 S = "${WORKDIR}/tsocks-1.8"
 
 FILES_${PN} = "${libdir}/* ${bindir}/tsocks"
 FILES_${PN}-dev = ""
 INSANE_SKIP_${PN} = "dev-so"
 
-EXTRA_OEMAKE = "SHCC='${CC} -fPIC ${LDFLAGS}'"
+EXTRA_OEMAKE = "SHCC='${CC} -fPIC ${LDFLAGS}' LIBS='${LIBS}'"
 
 
--

To stop receiving notification emails like this one, please contact the administrator of this repository.
--
_______________________________________________
Openembedded-commits mailing list [email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-commits

#3 lore raw

PATCH 1/1 tsocks: use -lssp_nonshared also for glibc

* the issue is reproducible also in glibc builds
* fixes:

  | tsocks.c:954: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:842: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:339: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:522: error: undefined reference to '__stack_chk_fail_local'
  | collect2: error: ld returned 1 exit status
  | Makefile:53: recipe for target 'libtsocks.so.1.8' failed
  | make: *** [libtsocks.so.1.8] Error 1
---
 meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +1 -1
index 72913579af..790a6cc795 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863
 
 inherit autotools-brokensep
 
-LIBS_append_libc-musl = " -lssp_nonshared"
+LIBS = "-lssp_nonshared"
 
 S = "${WORKDIR}/tsocks-1.8"
 
Signature · 1 line
2.17.1
#4 lore raw

Re: [meta-networking][PATCH] tsocks: use -lssp_nonshared also for glibc

Quoted 21 lines · Martin Jansa

* the issue is reproducible also in glibc builds
* fixes:

  | tsocks.c:954: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:842: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:339: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:522: error: undefined reference to '__stack_chk_fail_local'
  | collect2: error: ld returned 1 exit status
  | Makefile:53: recipe for target 'libtsocks.so.1.8' failed
  | make: *** [libtsocks.so.1.8] Error 1
---
 meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +0 -0
index 72913579af..790a6cc795 100644

meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb SRC_URI[sha256sum] = "849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863 · line 22

Quoted 6 lines
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +1 -1
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] = "849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863
 
 inherit autotools-brokensep
 
-LIBS_append_libc-musl = " -lssp_nonshared"
+LIBS = "-lssp_nonshared"
 

hmm, now I think more it is a SECURITY_LDFLAGS element. Since this is not needed otherwise.

Quoted 10 lines
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +0 -1
 S = "${WORKDIR}/tsocks-1.8"
 
--

2.17.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#5 lore raw

Re: [meta-networking][PATCH] tsocks: use -lssp_nonshared also for glibc

In reply to Martin Jansa

This isn't the right fix, causes:

ld: error: cannot find -lssp_nonshared
collect2: error: ld returned 1 exit status Makefile:47: recipe for target 'inspectsocks' failed
make: *** [inspectsocks] Error 1

Sorry for sending too soon.

Quoted 34 lines · Martin Jansa

* the issue is reproducible also in glibc builds
* fixes:

  | tsocks.c:954: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:842: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:339: error: undefined reference to '__stack_chk_fail_local'
  | tsocks.c:522: error: undefined reference to '__stack_chk_fail_local'
  | collect2: error: ld returned 1 exit status
  | Makefile:53: recipe for target 'libtsocks.so.1.8' failed
  | make: *** [libtsocks.so.1.8] Error 1
---
 meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +0 -0
index 72913579af..790a6cc795 100644
@@ -18,7 +18,7 @@ SRC_URI[sha256sum] =

"849d7ef5af80d03e76cc05ed9fb8fa2bcc2b724b51ebfd1b6be11c7863

inherit autotools-brokensep

meta-networking/recipes-protocols/tsocks/tsocks_1.8beta5.bb +1 -2
-LIBS_append_libc-musl = " -lssp_nonshared"
+LIBS = "-lssp_nonshared"
 
 S = "${WORKDIR}/tsocks-1.8"
 
--

2.17.1