Skip to contentSkip to conversation

remoteproc: qcom: pas: Add QCS404 remoteprocs

PATCH In review Bjorn Andersson 2 participants 3 messages Sep 27, 2018 – Oct 6, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 remoteproc: qcom: pas: Add QCS404 remoteprocs

Add compatibles for the three PAS based remote processors found in QCS404.

---

Changes since v1:
- Fixed incorrect sysmon_name, as pointed out by Sibi.

 .../devicetree/bindings/remoteproc/qcom,adsp.txt     |  3 +++
 drivers/remoteproc/qcom_adsp_pil.c                   | 12 ++++++++++++
 2 files changed, 15 insertions(+)
Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt +3 -0
index b7d058228185..9c0cff3a5ed8 100644
@@ -10,6 +10,9 @@ on the Qualcomm ADSP Hexagon core.
 		    "qcom,msm8974-adsp-pil"
 		    "qcom,msm8996-adsp-pil"
 		    "qcom,msm8996-slpi-pil"
+		    "qcom,qcs404-adsp-pas"
+		    "qcom,qcs404-cdsp-pas"
+		    "qcom,qcs404-wcss-pas"
 		    "qcom,sdm845-adsp-pas"
 		    "qcom,sdm845-cdsp-pas"
 
drivers/remoteproc/qcom_adsp_pil.c +12 -0
index da2254ea1135..d5e58235e83a 100644
@@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init = {
 		.ssctl_id = 0x16,
 };
 
+static const struct adsp_data wcss_resource_init = {
+	.crash_reason_smem = 421,
+	.firmware_name = "wcnss.mdt",
+	.pas_id = 6,
+	.ssr_name = "mpss",
+	.sysmon_name = "wcnss",
+	.ssctl_id = 0x12,
+};
+
 static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
+	{ .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
+	{ .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
+	{ .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
 	{ .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init},
 	{ .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init},
 	{ },
Signature · 1 line
2.18.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 6 lines · Bjorn Andersson

Add compatibles for the three PAS based remote processors found in QCS404.

---

Quoted 58 lines

Changes since v1:
- Fixed incorrect sysmon_name, as pointed out by Sibi.

 .../devicetree/bindings/remoteproc/qcom,adsp.txt     |  3 +++
 drivers/remoteproc/qcom_adsp_pil.c                   | 12 ++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt index b7d058228185..9c0cff3a5ed8 100644

Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt +3 -0
@@ -10,6 +10,9 @@ on the Qualcomm ADSP Hexagon core.
 		    "qcom,msm8974-adsp-pil"
 		    "qcom,msm8996-adsp-pil"
 		    "qcom,msm8996-slpi-pil"
+		    "qcom,qcs404-adsp-pas"
+		    "qcom,qcs404-cdsp-pas"
+		    "qcom,qcs404-wcss-pas"
 		    "qcom,sdm845-adsp-pas"
 		    "qcom,sdm845-cdsp-pas"
 
drivers/remoteproc/qcom_adsp_pil.c +9 -0
index da2254ea1135..d5e58235e83a 100644
@@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init 
 = {
 		.ssctl_id = 0x16,
 };
 
+static const struct adsp_data wcss_resource_init = {
+	.crash_reason_smem = 421,
+	.firmware_name = "wcnss.mdt",
+	.pas_id = 6,
+	.ssr_name = "mpss",
+	.sysmon_name = "wcnss",
+	.ssctl_id = 0x12,
+};
+
 static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,msm8974-adsp-pil", .data = 
 &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-adsp-pil", .data = 
 &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-slpi-pil", .data = 

&slpi_resource_init},

drivers/remoteproc/qcom_adsp_pil.c +1 -0
+	{ .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init 

},

drivers/remoteproc/qcom_adsp_pil.c +1 -0
+	{ .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init 

},

drivers/remoteproc/qcom_adsp_pil.c +1 -0
+	{ .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init 

},

drivers/remoteproc/qcom_adsp_pil.c +0 -0
 	{ .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init},
 	{ .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init},
 	{ },
Signature · 3 lines
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
#2 lore raw
Quoted 10 lines · Sibi Sankar
Quoted 6 lines · Bjorn Andersson

Add compatibles for the three PAS based remote processors found in QCS404.

---

Thanks for the review Sibi, applied the patch.

Regards,
Bjorn

Quoted 57 lines
Quoted 52 lines

Changes since v1:
- Fixed incorrect sysmon_name, as pointed out by Sibi.

 .../devicetree/bindings/remoteproc/qcom,adsp.txt     |  3 +++
 drivers/remoteproc/qcom_adsp_pil.c                   | 12 ++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt index b7d058228185..9c0cff3a5ed8 100644

Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt +3 -0
@@ -10,6 +10,9 @@ on the Qualcomm ADSP Hexagon core.
 		    "qcom,msm8974-adsp-pil"
 		    "qcom,msm8996-adsp-pil"
 		    "qcom,msm8996-slpi-pil"
+		    "qcom,qcs404-adsp-pas"
+		    "qcom,qcs404-cdsp-pas"
+		    "qcom,qcs404-wcss-pas"
 		    "qcom,sdm845-adsp-pas"
 		    "qcom,sdm845-cdsp-pas"
 
drivers/remoteproc/qcom_adsp_pil.c +12 -0
index da2254ea1135..d5e58235e83a 100644
@@ -362,10 +362,22 @@ static const struct adsp_data slpi_resource_init =
 {
 		.ssctl_id = 0x16,
 };
 
+static const struct adsp_data wcss_resource_init = {
+	.crash_reason_smem = 421,
+	.firmware_name = "wcnss.mdt",
+	.pas_id = 6,
+	.ssr_name = "mpss",
+	.sysmon_name = "wcnss",
+	.ssctl_id = 0x12,
+};
+
 static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,msm8974-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-adsp-pil", .data = &adsp_resource_init},
 	{ .compatible = "qcom,msm8996-slpi-pil", .data = &slpi_resource_init},
+	{ .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
+	{ .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
+	{ .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
 	{ .compatible = "qcom,sdm845-adsp-pas", .data = &adsp_resource_init},
 	{ .compatible = "qcom,sdm845-cdsp-pas", .data = &cdsp_resource_init},

{ },

Signature · 3 lines
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.