mfd: cros_ec: Avoid unneeded internal declaration warning
Subsystems (2)
PATCH 1/1 mfd: cros_ec: Avoid unneeded internal declaration warning
Clang warns:
drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static const struct platform_device_id cros_ec_id[] = {
^1 warning generated.
Avoid this warning by adding it to the cros_ec_dev_driver definition under the id_table member like all other platform drivers.
---
I looked at several drivers with platform_device_id defintions and I didn't really find any where the definition wasn't then added to the platform_driver so I'm not sure if this was just missed in commit afbf8ec7c4f9 ("platform/chrome: cros_ec_dev - Add a platform device ID table") or if it was an intentional omission. I'm not super familiar with the inner workings of platform devices.
Should this commit be undesirable, the warning can be silenced with the __used attribute but this seemed like a more proper first commit.
drivers/mfd/cros_ec_dev.c | 1 + 1 file changed, 1 insertion(+)
drivers/mfd/cros_ec_dev.c +1 -0
@@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = { .name = DRV_NAME, .pm = &cros_ec_dev_pm_ops, }, + .id_table = cros_ec_id, .probe = ec_device_probe, .remove = ec_device_remove, .shutdown = ec_device_shutdown,
Signature · 1 line
2.19.0
Quoted 42 lines · Nathan Chancellor
Clang warns:
drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not needed and will not be emitted [-Wunneeded-internal-declaration]static const struct platform_device_id cros_ec_id[] = { ^1 warning generated.
Avoid this warning by adding it to the
cros_ec_dev_driverdefinition under theid_tablemember like all other platform drivers.Signed-off-by Nathan Chancellor <[email protected]>---
I looked at several drivers with
platform_device_iddefintions and I didn't really find any where the definition wasn't then added to theplatform_driverso I'm not sure if this was just missed in commitafbf8ec7c4f9("platform/chrome:cros_ec_dev- Add a platform device ID table") or if it was an intentional omission. I'm not super familiar with the inner workings of platform devices.Should this commit be undesirable, the warning can be silenced with the
__usedattribute but this seemed like a more proper first commit.drivers/mfd/cros_ec_dev.c | 1 + 1 file changed, 1 insertion(+)drivers/mfd/cros_ec_dev.c +1
-0@@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = { .name = DRV_NAME, .pm = &cros_ec_dev_pm_ops, }, + .id_table = cros_ec_id, .probe = ec_device_probe, .remove = ec_device_remove, .shutdown = ec_device_shutdown,Signature · 1 line
2.19.0
It just occurred to me I probably should have added some of the Chromium guys who have modified this driver to this patch. I've done that now.
Nathan
Lee Jones
AppliedQuoted 22 lines · Nathan Chancellor
Quoted 21 lines · Nathan Chancellor
Clang warns:
drivers/mfd/cros_ec_dev.c:509:40: warning: variable 'cros_ec_id' is not needed and will not be emitted [-Wunneeded-internal-declaration]static const struct platform_device_id cros_ec_id[] = { ^1 warning generated.
Avoid this warning by adding it to the
cros_ec_dev_driverdefinition under theid_tablemember like all other platform drivers.Signed-off-by Nathan Chancellor <[email protected]>---
I looked at several drivers with
platform_device_iddefintions and I didn't really find any where the definition wasn't then added to theplatform_driverso I'm not sure if this was just missed in commitafbf8ec7c4f9("platform/chrome:cros_ec_dev- Add a platform device ID table") or if it was an intentional omission. I'm not super familiar with the inner workings of platform devices.
Quoted 5 lines
Quoted 5 lines
Should this commit be undesirable, the warning can be silenced with the
__usedattribute but this seemed like a more proper first commit.drivers/mfd/cros_ec_dev.c | 1 + 1 file changed, 1 insertion(+)
Applied, thanks.
Signature · 4 lines
Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Stephen Boyd
Acked-byQuoting Nathan Chancellor (2018-09-27 18:16:14)
Quoted 11 lines · Nathan Chancellor
Quoted 10 lines
drivers/mfd/cros_ec_dev.c +1
-0@@ -546,6 +546,7 @@ static struct platform_driver cros_ec_dev_driver = { .name = DRV_NAME, .pm = &cros_ec_dev_pm_ops, }, + .id_table = cros_ec_id, .probe = ec_device_probe,
Quoted 8 lines
Quoted 5 lines
drivers/mfd/cros_ec_dev.c +0
-0.remove = ec_device_remove, .shutdown = ec_device_shutdown,Signature · 1 line
2.19.0It just occurred to me I probably should have added some of the Chromium guys who have modified this driver to this patch. I've done that now.
Looks OK to me.