Skip to contentSkip to conversation

drivers: oprofile: Avoids building driver from direct make command

PATCH Superseded Leonardo Brás 2 participants 6 messages Sep 27, 2018 – Sep 28, 2018 s390

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 6/7 drivers: oprofile: Avoids building driver from direct make command

Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have no meaning building alone.

---
 drivers/oprofile/Makefile | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 drivers/oprofile/Makefile
drivers/oprofile/Makefile new file +2 -0
new file mode 100644
index 000000000000..acaed2ad6eee
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+
Signature · 1 line
2.19.0
#1 lore raw

Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:

Quoted 18 lines

Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have no meaning building alone.

---
 drivers/oprofile/Makefile | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 drivers/oprofile/Makefile
drivers/oprofile/Makefile new file +0 -0
new file mode 100644
index 000000000000..acaed2ad6eee

drivers/oprofile/Makefile line 2

Quoted 2 lines
drivers/oprofile/Makefile new file +2 -0
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+

Now there is a blank line where it does not need to be.

Eike

#2 lore raw

Hello Rolf,

Quoted 24 lines · Rolf Eike Beer

Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:

Quoted 18 lines

Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have no meaning building alone.

---
 drivers/oprofile/Makefile | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 drivers/oprofile/Makefile
drivers/oprofile/Makefile new file +0 -0
new file mode 100644
index 000000000000..acaed2ad6eee

drivers/oprofile/Makefile line 2

Quoted 2 lines
drivers/oprofile/Makefile new file +2 -0
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+

Now there is a blank line where it does not need to be.

Quoted 1 line

Eike

Oh, it's a Makefile, and as all text files, it have to end with newline. If I am wrong, please let me know.

Thanks for your feedback,

Leonardo Bras,

#3 lore raw

Am 2018-09-27 13:23, schrieb Leonardo Bras:

Quoted 27 lines

Hello Rolf,

Quoted 24 lines · Rolf Eike Beer

Am Donnerstag, 27. September 2018, 03:41:38 CEST schrieb Leonardo Brás:

Quoted 18 lines

Creates new Makefile to avoid building driver if
'make drivers/oprofile/' is called directly.

This driver is usually built from arch/$ARCH and seems to have no meaning building alone.

---
 drivers/oprofile/Makefile | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 drivers/oprofile/Makefile
drivers/oprofile/Makefile new file +0 -0
new file mode 100644
index 000000000000..acaed2ad6eee

drivers/oprofile/Makefile line 2

Quoted 2 lines
drivers/oprofile/Makefile new file +2 -0
@@ -0,0 +1,2 @@
+#Does nothing, since the source is called from arch/$ARCH/ tree.
+

Now there is a blank line where it does not need to be.

Quoted 4 lines
Quoted 1 line

Eike

Oh, it's a Makefile, and as all text files, it have to end with newline. If I am wrong, please let me know.

No, that's fine. But it means it has to have one LF after "tree.". It had none, now it hat 2.

Eike

#4 lore raw

Hello Eike,

Quoted 4 lines

No, that's fine. But it means it has to have one LF after "tree.". It had none, now it hat 2.

Eike

Oh, i haven't noticed. Sorry for the trouble.

Thanks for the feedback!

Leonardo Brás

#5 lore raw
In reply to Rolf Eike Beer

Hello Eike,

Quoted 7 lines
Quoted 2 lines

Oh, it's a Makefile, and as all text files, it have to end with newline. If I am wrong, please let me know.

No, that's fine. But it means it has to have one LF after "tree.". It had none, now it hat 2.

Eike

Oh, i haven't noticed. Sorry for the trouble.

Thanks for the feedback!

Leonardo Bras