Skip to contentSkip to conversation

i2c-omap: Enable i2c-omap driver for AM654 SoCs

PATCH Superseded Vignesh R 4 participants 8 messages Sep 28, 2018 – Nov 7, 2018

Subsystems (2)
Device tree bindings I2C subsystem host drivers

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Vignesh R

author
#0 lore raw

v2 cover i2c-omap: Enable i2c-omap driver for AM654 SoCs

Couple of patches to enable i2c-omap driver to be used with TI's new AM654 platforms.

Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 drivers/i2c/busses/Kconfig                         | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
2.19.0
author
#1 lore raw

PATCH v2 1/2 dt-bindings: i2c-omap: Add new compatible for AM654 SoCs

AM654 SoCs have same I2C IP as OMAP SoCs. Add new compatible to handle AM654 SoCs. While at that reformat the existing compatible list for older SoCs to list one valid compatible per line.

Signed-off-by Vignesh R <[email protected]>

---

v2: Reformat compatible existing compatible list.

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-omap.txt +6 -2
index 7e49839d4124..4b90ba9f31b7 100644
@@ -1,8 +1,12 @@
 I2C for OMAP platforms
 
 Required properties :
-- compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
-  or "ti,omap4-i2c"
+- compatible : Must be
+	"ti,omap2420-i2c" for OMAP2420 SoCs
+	"ti,omap2430-i2c" for OMAP2430 SoCs
+	"ti,omap3-i2c" for OMAP3 SoCs
+	"ti,omap4-i2c" for OMAP4+ SoCs
+	"ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
 - ti,hwmods : Must be "i2c<n>", n being the instance number (1-based)
 - #address-cells = <1>;
 - #size-cells = <0>;
Signature · 1 line
2.19.0
maintainer Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs

Quoted 4 lines · Vignesh R

AM654 SoCs have same I2C IP as OMAP SoCs. Add new compatible to handle AM654 SoCs. While at that reformat the existing compatible list for older SoCs to list one valid compatible per line.

Quoted 8 lines
Signed-off-by Vignesh R <[email protected]>

---

v2: Reformat compatible existing compatible list.

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by Rob Herring <[email protected]>
author
#3 lore raw

PATCH v2 2/2 i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

In reply to Vignesh R

Allow I2C_OMAP to be built for K3 platforms.

Signed-off-by Vignesh R <[email protected]>

---

v2: No changes

 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +1 -1
index 451d4ae50e66..ac4b09642f63 100644
@@ -751,7 +751,7 @@ config I2C_OCORES
 
 config I2C_OMAP
 	tristate "OMAP I2C adapter"
-	depends on ARCH_OMAP
+	depends on ARCH_OMAP || ARCH_K3
 	default y if MACH_OMAP_H3 || MACH_OMAP_OSK
 	help
 	  If you say yes to this option, support will be included for the
Signature · 1 line
2.19.0
author
#4 lore raw
In reply to Vignesh R
Quoted 4 lines · Vignesh R

Couple of patches to enable i2c-omap driver to be used with TI's new AM654 platforms.

Quoted 8 lines

Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 drivers/i2c/busses/Kconfig                         | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

Gentle ping...

Regards
Vignesh

#5 lore raw
Quoted 11 lines · Vignesh R
Quoted 8 lines · Vignesh R

Couple of patches to enable i2c-omap driver to be used with TI's new AM654 platforms.

Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

Quoted 6 lines
Quoted 4 lines
 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 drivers/i2c/busses/Kconfig                         | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)

Gentle ping...

Maintainer tags are missing. Tony is listed for this driver on OMAP2+. Is this his realm? Do we need a specific maintainer for this driver?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181028/a78e623f/attachment-0001.sig>

author
#6 lore raw
Quoted 17 lines · Wolfram Sang
Quoted 16 lines · Vignesh R
Quoted 12 lines · Vignesh R

Couple of patches to enable i2c-omap driver to be used with TI's new AM654 platforms.

Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

 Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
 drivers/i2c/busses/Kconfig                         | 2 +-
 2 files changed, 7 insertions(+), 3 deletions(-)
Quoted 5 lines
Quoted 1 line

Gentle ping...

Maintainer tags are missing. Tony is listed for this driver on OMAP2+. Is this his realm? Do we need a specific maintainer for this driver?

I think this driver needs a separate entry, will send a patch adding my name as reviewer for this driver.

Signature · 2 lines
Regards
Vignesh
Reviewed-by on the v2 series
#7 lore raw
In reply to Vignesh R
Quoted 4 lines · Vignesh R

Couple of patches to enable i2c-omap driver to be used with TI's new AM654 platforms.

Quoted 8 lines

Vignesh R (2):
dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3

  Documentation/devicetree/bindings/i2c/i2c-omap.txt | 8 ++++++--
  drivers/i2c/busses/Kconfig                         | 2 +-
  2 files changed, 7 insertions(+), 3 deletions(-)
Reviewed-by Grygorii Strashko <[email protected]>
Signature · 2 lines
regards,
-grygorii