Skip to contentSkip to conversation

MIPS: stop using _PTRS_PER_PGD

PATCH In review Alexandre Belloni 2 participants 2 messages Sep 28, 2018 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: stop using _PTRS_PER_PGD

gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the asm-offsets.h inclusion.

---
 arch/mips/mm/init.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
arch/mips/mm/init.c +1 -6
index 400676ce03f4..15cae0f11880 100644
@@ -32,7 +32,6 @@
 #include <linux/kcore.h>
 #include <linux/initrd.h>
 
-#include <asm/asm-offsets.h>
 #include <asm/bootinfo.h>
 #include <asm/cachectl.h>
 #include <asm/cpu.h>
@@ -521,17 +520,13 @@ unsigned long pgd_current[NR_CPUS];
 #endif
 
 /*
- * gcc 3.3 and older have trouble determining that PTRS_PER_PGD and PGD_ORDER
- * are constants.  So we use the variants from asm-offset.h until that gcc
- * will officially be retired.
- *
  * Align swapper_pg_dir in to 64K, allows its address to be loaded
  * with a single LUI instruction in the TLB handlers.  If we used
  * __aligned(64K), its size would get rounded up to the alignment
  * size, and waste space.  So we place it in its own section and align
  * it in the linker script.
  */
-pgd_t swapper_pg_dir[_PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
+pgd_t swapper_pg_dir[PTRS_PER_PGD] __section(.bss..swapper_pg_dir);
 #ifndef __PAGETABLE_PUD_FOLDED
 pud_t invalid_pud_table[PTRS_PER_PUD] __page_aligned_bss;
 #endif
Signature · 1 line
2.19.0
#1 lore raw

Hi Alexandre,

Quoted 7 lines · Alexandre Belloni

gcc 3.3 has been retired for a while, use PTRS_PER_PGD and remove the asm-offsets.h inclusion.

---
 arch/mips/mm/init.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Thanks - applied to mips-next for 4.20.

Paul