drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
Subsystems (2)
PATCH 1/1 drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
The PDC irqchp can convert a falling edge or level low interrupt to a rising edge or level high interrupt at the GIC. We just need to setup the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH as IRQ_TYPE_EDGE_RISING at the GIC.
--- drivers/irqchip/qcom-pdc.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/qcom-pdc.c +1 -0
@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)break ;case IRQ_TYPE_EDGE_BOTH : pdc_type =PDC_EDGE_DUAL ; + type =IRQ_TYPE_EDGE_RISING ;break ;case IRQ_TYPE_LEVEL_HIGH : pdc_type =PDC_LEVEL_HIGH ;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Lina Iyer
The PDC irqchp can convert a falling edge or level low interrupt to a rising edge or level high interrupt at the GIC. We just need to setup the GIC correctly. Set up the interrupt type for the
IRQ_TYPE_EDGE_BOTHasIRQ_TYPE_EDGE_RISINGat the GIC.
Quoted 6 lines
Reported-by Evan Green <[email protected]>Signed-off-by Lina Iyer <[email protected]>--- drivers/irqchip/qcom-pdc.c | 1 + 1 file changed, 1 insertion(+)
Quoted 17 lines · Lina Iyer
The PDC irqchp can convert a falling edge or level low interrupt to a rising edge or level high interrupt at the GIC. We just need to setup the GIC correctly. Set up the interrupt type for the
IRQ_TYPE_EDGE_BOTHasIRQ_TYPE_EDGE_RISINGat the GIC.Reported-by Evan Green <[email protected]>Signed-off-by Lina Iyer <[email protected]>--- drivers/irqchip/qcom-pdc.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/qcom-pdc.c +0
-0
drivers/irqchip/qcom-pdc.c static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type) · line 130
Quoted 7 lines
drivers/irqchip/qcom-pdc.c +1
-0@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)break ;case IRQ_TYPE_EDGE_BOTH : pdc_type =PDC_EDGE_DUAL ; + type =IRQ_TYPE_EDGE_RISING ;break ;case IRQ_TYPE_LEVEL_HIGH : pdc_type =PDC_LEVEL_HIGH ;
Queued for 4.20, with
added. Please consider providing these tags in the future.
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
Quoted 28 lines · Marc Zyngier
Quoted 17 lines · Lina Iyer
The PDC irqchp can convert a falling edge or level low interrupt to a rising edge or level high interrupt at the GIC. We just need to setup the GIC correctly. Set up the interrupt type for the
IRQ_TYPE_EDGE_BOTHasIRQ_TYPE_EDGE_RISINGat the GIC.Reported-by Evan Green <[email protected]>Signed-off-by Lina Iyer <[email protected]>--- drivers/irqchip/qcom-pdc.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/qcom-pdc.c +0
-0drivers/irqchip/qcom-pdc.c static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type) · line 130
Quoted 7 lines
drivers/irqchip/qcom-pdc.c +1
-0@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)break ;case IRQ_TYPE_EDGE_BOTH : pdc_type =PDC_EDGE_DUAL ; + type =IRQ_TYPE_EDGE_RISING ;break ;case IRQ_TYPE_LEVEL_HIGH : pdc_type =PDC_LEVEL_HIGH ;Queued for 4.20, with
Quoted 4 lines
Fixes f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller forQCOM SoCs")
added. Please consider providing these tags in the future.
Thanks Marc. Will do.
-- Lina