Skip to contentSkip to conversation

lua: fix dynamic library install

PATCH New Fabrice Fontaine 3 participants 7 messages Sep 28, 2018 – Oct 5, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/2 lua: fix dynamic library install

In 0002-shared-libs-for-lua.patch, revision number is used to set library name:
TO_SOLIB = liblua.so.$(R)

However, library is built using PKG_VERSION which is passed only during build step:
$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?

As a result, dynamic library is not installed in staging or target paths since bump to lua 5.3.5

So, instead of replacing R by PKG_VERSION and passing this variable in all steps, simply update R to 5

Fixes:
- http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>
---
 .../lua/5.3.5/0003-fix-revision-number.patch  | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/lua/5.3.5/0003-fix-revision-number.patch
package/lua/5.3.5/0003-fix-revision-number.patch new file +31 -0
new file mode 100644
index 0000000000..ed2e0460eb
@@ -0,0 +1,31 @@
+Fix revision number
+
+In 0002-shared-libs-for-lua.patch, revision number is used to set 
+library name:
+TO_SOLIB = liblua.so.$(R)
+
+However, library is built using PKG_VERSION which is passed only during
+build step:
+$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?
+
+As a result, dynamic library is not installed in staging or target paths
+since bump to lua 5.3.5
+
+So, instead of replacing R by PKG_VERSION and passing this variable in
+all steps, simply update R to 5
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+
+Index: b/Makefile
+===================================================================
+--- a/Makefile
++++ b/Makefile
+@@ -47,6 +47,6 @@
+
+ # Lua version and release.
+ V= 5.3
+-R= $V.4
++R= $V.5
+
+ # Targets start here.
+ all:    $(PLAT)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 2/2 haproxy: fix linking with lua

Use LUA_LIB_NAME to give lua library name otherwise haproxy can't find it

Fixes:
- http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/haproxy/haproxy.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/haproxy/haproxy.mk +3 -1
index a799e69651..363fc4447f 100644
@@ -25,7 +25,9 @@ endif
 
 ifeq ($(BR2_PACKAGE_LUA_5_3),y)
 HAPROXY_DEPENDENCIES += lua
-HAPROXY_MAKE_OPTS += USE_LUA=1
+HAPROXY_MAKE_OPTS += \
+	LUA_LIB_NAME=lua \
+	USE_LUA=1
 endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
Signature · 1 line
2.17.1
#3 lore raw

PATCH 1/2 lua: fix dynamic library install

In reply to Fabrice Fontaine

Le ven. 28 sept. 2018 ? 19:35, Fabrice Fontaine <[email protected]> a ?crit :

Quoted 11 lines

In 0002-shared-libs-for-lua.patch, revision number is used to set library name:
TO_SOLIB = liblua.so.$(R)

However, library is built using PKG_VERSION which is passed only during build step:
$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?

As a result, dynamic library is not installed in staging or target paths since bump to lua 5.3.5

Quoted 9 lines

So, instead of replacing R by PKG_VERSION and passing this variable in all steps, simply update R to 5

Fixes:
-
http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>
Acked-by Francois Perrad <[email protected]>
Quoted 44 lines
---
 .../lua/5.3.5/0003-fix-revision-number.patch  | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/lua/5.3.5/0003-fix-revision-number.patch
package/lua/5.3.5/0003-fix-revision-number.patch new file +31 -1
new file mode 100644
index 0000000000..ed2e0460eb
@@ -0,0 +1,31 @@
+Fix revision number
+
+In 0002-shared-libs-for-lua.patch, revision number is used to set
+library name:
+TO_SOLIB = liblua.so.$(R)
+
+However, library is built using PKG_VERSION which is passed only during
+build step:
+$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?
+
+As a result, dynamic library is not installed in staging or target paths
+since bump to lua 5.3.5
+
+So, instead of replacing R by PKG_VERSION and passing this variable in
+all steps, simply update R to 5
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+
+Index: b/Makefile
+===================================================================
+--- a/Makefile
++++ b/Makefile
+@@ -47,6 +47,6 @@
+
+ # Lua version and release.
+ V= 5.3
+-R= $V.4
++R= $V.5
+
+ # Targets start here.
+ all:    $(PLAT)
--
Quoted 3 lines

2.17.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180929/9ebe3a88/attachment.html>

#4 lore raw

PATCH 1/2 lua: fix dynamic library install

Le sam. 29 sept. 2018 ? 09:39, Fran?ois Perrad <[email protected]> a ?crit :

Quoted 19 lines

Le ven. 28 sept. 2018 ? 19:35, Fabrice Fontaine <
fontaine.fabrice at gmail.com> a ?crit :

Quoted 14 lines

In 0002-shared-libs-for-lua.patch, revision number is used to set library name:
TO_SOLIB = liblua.so.$(R)

However, library is built using PKG_VERSION which is passed only during build step:
$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?

As a result, dynamic library is not installed in staging or target paths since bump to lua 5.3.5

So, instead of replacing R by PKG_VERSION and passing this variable in all steps, simply update R to 5

Quoted 10 lines
Quoted 6 lines

Fixes:
-
http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>
Acked-by Francois Perrad <[email protected]>

This commit is useful in branch 2018.08.x too.

Fran?ois

---

Quoted 38 lines
Quoted 38 lines
 .../lua/5.3.5/0003-fix-revision-number.patch  | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/lua/5.3.5/0003-fix-revision-number.patch
package/lua/5.3.5/0003-fix-revision-number.patch new file +27 -0
new file mode 100644
index 0000000000..ed2e0460eb
@@ -0,0 +1,31 @@
+Fix revision number
+
+In 0002-shared-libs-for-lua.patch, revision number is used to set
+library name:
+TO_SOLIB = liblua.so.$(R)
+
+However, library is built using PKG_VERSION which is passed only during
+build step:
+$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?
+
+As a result, dynamic library is not installed in staging or target paths
+since bump to lua 5.3.5
+
+So, instead of replacing R by PKG_VERSION and passing this variable in
+all steps, simply update R to 5
+
+Signed-off-by: Fabrice Fontaine <[email protected]>
+
+Index: b/Makefile
+===================================================================
+--- a/Makefile
++++ b/Makefile
+@@ -47,6 +47,6 @@
+
+ # Lua version and release.
+ V= 5.3
+-R= $V.4
Quoted 8 lines
Quoted 8 lines
package/lua/5.3.5/0003-fix-revision-number.patch new file +4 -1
++R= $V.5
+
+ # Targets start here.
+ all:    $(PLAT)
--

2.17.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20181005/95a0fab6/attachment.html>

#5 lore raw

PATCH 1/2 lua: fix dynamic library install

In reply to Fabrice Fontaine
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

In 0002-shared-libs-for-lua.patch, revision number is used to set library name:
TO_SOLIB = liblua.so.$(R)

However, library is built using PKG_VERSION which is passed only during build step:
$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?

As a result, dynamic library is not installed in staging or target paths since bump to lua 5.3.5

Quoted 7 lines

So, instead of replacing R by PKG_VERSION and passing this variable in all steps, simply update R to 5

Fixes:
- http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/2 lua: fix dynamic library install

In reply to Fabrice Fontaine
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

In 0002-shared-libs-for-lua.patch, revision number is used to set library name:
TO_SOLIB = liblua.so.$(R)

However, library is built using PKG_VERSION which is passed only during build step:
$(CC) -o $@.$(PKG_VERSION) -shared -Wl,-soname="$@.$(PKG_VERSION)" $?

As a result, dynamic library is not installed in staging or target paths since bump to lua 5.3.5

Quoted 7 lines

So, instead of replacing R by PKG_VERSION and passing this variable in all steps, simply update R to 5

Fixes:
- http://autobuild.buildroot.net/results/28b6672188bb0082ac1467d3b45904880e3634f3

Signed-off-by Fabrice Fontaine <[email protected]>

Committed to 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard