Skip to contentSkip to conversation

ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle

PATCH In review Tony Lindgren 3 participants 3 messages Sep 29, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am335x: Replace remaining legacy phy_id with phy-handle

Looks like we still have two instances of phy_handle that did not get update by Grygorii's series. Let's replace these too with standard phy-handle.

Cc Arnd Bergmann <[email protected]>
Cc Grygorii Strashko <[email protected]>
Cc Koen Kooi <[email protected]>
Cc Neeraj Dantu <[email protected]>
---
 arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
 arch/arm/boot/dts/am335x-sancloud-bbe.dts   | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am335x-osd3358-sm-red.dts +5 -1
@@ -424,7 +424,7 @@
 };
 
 &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <4>;
+	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-txid";
 };
 
@@ -441,6 +441,10 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 	status = "okay";
+
+	ethphy0: ethernet-phy@4 {
+		reg = <4>;
+	};
 };
 
 &mmc1 {
arch/arm/boot/dts/am335x-sancloud-bbe.dts +5 -1
@@ -103,10 +103,14 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 	status = "okay";
+
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
 };
 
 &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <0>;
+	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-txid";
 };
 
Signature · 1 line
2.19.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Tony Lindgren

Looks like we still have two instances of phy_handle that did not get update by Grygorii's series. Let's replace these too with standard phy-handle.

Cc Arnd Bergmann <[email protected]>
Cc Grygorii Strashko <[email protected]>
Cc Koen Kooi <[email protected]>
Cc Neeraj Dantu <[email protected]>
Quoted 48 lines
---
  arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
  arch/arm/boot/dts/am335x-sancloud-bbe.dts   | 6 +++++-
  2 files changed, 10 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am335x-osd3358-sm-red.dts +5 -1
@@ -424,7 +424,7 @@
  };
 
  &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <4>;
+	phy-handle = <&ethphy0>;
  	phy-mode = "rgmii-txid";
  };
 
@@ -441,6 +441,10 @@
  	pinctrl-0 = <&davinci_mdio_default>;
  	pinctrl-1 = <&davinci_mdio_sleep>;
  	status = "okay";
+
+	ethphy0: ethernet-phy@4 {
+		reg = <4>;
+	};
  };
 
  &mmc1 {
arch/arm/boot/dts/am335x-sancloud-bbe.dts +5 -1
@@ -103,10 +103,14 @@
  	pinctrl-0 = <&davinci_mdio_default>;
  	pinctrl-1 = <&davinci_mdio_sleep>;
  	status = "okay";
+
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
  };
 
  &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <0>;
+	phy-handle = <&ethphy0>;
  	phy-mode = "rgmii-txid";
  };
 
Signature · 2 lines
regards,
-grygorii
Acked-by on v1 1/1
#2 lore raw
In reply to Tony Lindgren
Quoted 8 lines

Op 28 sep. 2018, om 22:34 heeft Tony Lindgren <[email protected]> het volgende geschreven:

Looks like we still have two instances of phy_handle that did not get update by Grygorii's series. Let's replace these too with standard phy-handle.

Quoted 6 lines
Cc Arnd Bergmann <[email protected]>
Cc Grygorii Strashko <[email protected]>
Cc Koen Kooi <[email protected]>
Cc Neeraj Dantu <[email protected]>

Thanks for taking care of this!

Quoted 49 lines

---
arch/arm/boot/dts/am335x-osd3358-sm-red.dts | 6 +++++-
arch/arm/boot/dts/am335x-sancloud-bbe.dts | 6 +++++-

2 files changed, 10 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am335x-osd3358-sm-red.dts +5 -1
@@ -424,7 +424,7 @@
 };
 
 &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <4>;
+	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-txid";
 };
 
@@ -441,6 +441,10 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 	status = "okay";
+
+	ethphy0: ethernet-phy@4 {
+		reg = <4>;
+	};
 };
 
 &mmc1 {
arch/arm/boot/dts/am335x-sancloud-bbe.dts +5 -1
@@ -103,10 +103,14 @@
 	pinctrl-0 = <&davinci_mdio_default>;
 	pinctrl-1 = <&davinci_mdio_sleep>;
 	status = "okay";
+
+	ethphy0: ethernet-phy@0 {
+		reg = <0>;
+	};
 };
 
 &cpsw_emac0 {
-	phy_id = <&davinci_mdio>, <0>;
+	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-txid";
 };
 
Signature · 1 line
2.19.0