Skip to contentSkip to conversation

Bad MAINTAINERS pattern in section 'LOCKING PRIMITIVES'

DISCUSSION Joe Perches 3 participants 3 messages Sep 28, 2018 – Oct 2, 2018

lore
Share & tools
lore

Joe Perches

author Tested-by Jason Low
#0 lore raw

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	8566	LOCKING PRIMITIVES
	8567	M:	Peter Zijlstra <[email protected]>
	8568	M:	Ingo Molnar <[email protected]>
	8569	M:	Will Deacon <[email protected]>
	8570	L:	[email protected]
	8571	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git locking/core
	8572	S:	Maintained
	8573	F:	Documentation/locking/
	8574	F:	include/linux/lockdep.h
	8575	F:	include/linux/spinlock*.h
	8576	F:	arch/*/include/asm/spinlock*.h
	8577	F:	include/linux/rwlock*.h
	8578	F:	include/linux/mutex*.h
-->	8579	F:	arch/*/include/asm/mutex*.h
	8580	F:	include/linux/rwsem*.h
	8581	F:	arch/*/include/asm/rwsem.h
	8582	F:	include/linux/seqlock.h
	8583	F:	lib/locking*.[ch]
	8584	F:	kernel/locking/
	8585	X:	kernel/locking/locktorture.c

Commit that introduced this:

commit d4c3be70ca0e7a1ae308bedd3462900c61e97b11
Author: Ingo Molnar <[email protected]>
Date: Thu Jun 9 12:20:25 2016 +0200

MAINTAINERS: Update locking tree description and file patterns

Update the file patterns, the Git tree URI and also widen the scope from 'LOCKDEP and LOCKSTAT' to 'LOCKING PRIMITIVES'.

Cc Peter Zijlstra <[email protected]>
Cc Linus Torvalds <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Thomas Gleixner <[email protected]>
Cc Paul E. McKenney <[email protected]>
  MAINTAINERS | 16 ++++++++++++----
  1 file changed, 12 insertions(+), 4 deletions(-)

Last commit with arch/*/include/asm/mutex*.h

commit 890658b7ab48d1362a0362df842cecc73c83146f

Author: Peter Zijlstra <[email protected]>
Date:   Tue Aug 23 13:36:04 2016 +0200

locking/mutex: Kill arch specific code

Its all generic atomic_long_t stuff now.

 arch/alpha/include/asm/mutex.h      |   9 ---
 arch/arc/include/asm/mutex.h        |  18 -----
 arch/arm/include/asm/mutex.h        |  21 ------
 arch/arm64/include/asm/Kbuild       |   1 -
 arch/avr32/include/asm/mutex.h      |   9 ---
 arch/blackfin/include/asm/Kbuild    |   1 -
 arch/c6x/include/asm/mutex.h        |   6 --
 arch/cris/include/asm/mutex.h       |   9 ---
 arch/frv/include/asm/mutex.h        |   9 ---
 arch/h8300/include/asm/mutex.h      |   9 ---
 arch/hexagon/include/asm/mutex.h    |   8 ---
 arch/ia64/include/asm/mutex.h       |  90 ------------------------
 arch/m32r/include/asm/mutex.h       |   9 ---
 arch/m68k/include/asm/Kbuild        |   1 -
 arch/metag/include/asm/Kbuild       |   1 -
 arch/microblaze/include/asm/mutex.h |   1 -
 arch/mips/include/asm/Kbuild        |   1 -
 arch/mn10300/include/asm/mutex.h    |  16 -----
 arch/nios2/include/asm/mutex.h      |   1 -
 arch/openrisc/include/asm/mutex.h   |  27 --------
 arch/parisc/include/asm/Kbuild      |   1 -
 arch/powerpc/include/asm/mutex.h    | 132 ------------------------------------
 arch/s390/include/asm/mutex.h       |   9 ---
 arch/score/include/asm/mutex.h      |   6 --
 arch/sh/include/asm/mutex-llsc.h    | 109 -----------------------------
 arch/sh/include/asm/mutex.h         |  12 ----
 arch/sparc/include/asm/Kbuild       |   1 -
 arch/tile/include/asm/Kbuild        |   1 -
 arch/um/include/asm/Kbuild          |   1 -
 arch/unicore32/include/asm/mutex.h  |  20 ------
 arch/x86/include/asm/mutex.h        |   5 --
 arch/x86/include/asm/mutex_32.h     | 110 ------------------------------
 arch/x86/include/asm/mutex_64.h     | 127 ----------------------------------
 arch/xtensa/include/asm/mutex.h     |   9 ---
 include/asm-generic/mutex-dec.h     |  88 ------------------------
 include/asm-generic/mutex-null.h    |  19 ------
 include/asm-generic/mutex-xchg.h    | 120 --------------------------------
 include/asm-generic/mutex.h         |   9 ---
 38 files changed, 1026 deletions(-)
#1 lore raw
Quoted 1 line · Joe Perches

Please fix this defect appropriately.

Patch below, which was probably less effort to write than your report ;)

Will

--->8

From 867b47473ad490c21591378a7041fe7c06b71b59 Mon Sep 17 00:00:00 2001
From: Will Deacon <[email protected]>
Date: Mon, 1 Oct 2018 14:47:58 +0100
Subject: [PATCH] MAINTAINERS: Remove dead path from LOCKING PRIMITIVES entry

Since 890658b7ab48 ("locking/mutex: Kill arch specific code"), there are no mutex header files under arch/, so we can remove the redundant entry from MAINTAINERS.

---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index d870cb57c887..276c32df137a 100644
@@ -8582,7 +8582,6 @@ F:	include/linux/spinlock*.h
 F:	arch/*/include/asm/spinlock*.h
 F:	include/linux/rwlock*.h
 F:	include/linux/mutex*.h
-F:	arch/*/include/asm/mutex*.h
 F:	include/linux/rwsem*.h
 F:	arch/*/include/asm/rwsem.h
 F:	include/linux/seqlock.h
Signature · 1 line
2.1.4
#2 lore raw

[tip:locking/urgent] MAINTAINERS: Remove dead path from LOCKING PRIMITIVES entry

MAINTAINERS: Remove dead path from LOCKING PRIMITIVES entry
Commit-ID:  6d348925b306ab0cc9757a09a8cea6bf288018e4
Gitweb:     https://git.kernel.org/tip/6d348925b306ab0cc9757a09a8cea6bf288018e4
Author:     Will Deacon <[email protected]>
AuthorDate: Mon, 1 Oct 2018 15:28:56 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 2 Oct 2018 10:45:57 +0200

MAINTAINERS: Remove dead path from LOCKING PRIMITIVES entry

Since 890658b7ab48 ("locking/mutex: Kill arch specific code"), there are no mutex header files under arch/, so we can remove the redundant entry from MAINTAINERS.

---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)
MAINTAINERS +0 -1
index a255240d1452..3bd8913b2d78 100644
@@ -8598,7 +8598,6 @@ F:	include/linux/spinlock*.h
 F:	arch/*/include/asm/spinlock*.h
 F:	include/linux/rwlock*.h
 F:	include/linux/mutex*.h
-F:	arch/*/include/asm/mutex*.h
 F:	include/linux/rwsem*.h
 F:	arch/*/include/asm/rwsem.h
 F:	include/linux/seqlock.h