Skip to contentSkip to conversation

Bad MAINTAINERS pattern in section 'NCP FILESYSTEM'

DISCUSSION Joe Perches 1 participant 1 message Sep 28, 2018

lore
Share & tools
lore

Joe Perches

author Acked-by David S. Miller
#0 lore raw

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	10052	NCP FILESYSTEM
	10053	M:	Petr Vandrovec <[email protected]>
	10054	S:	Obsolete

--> 10055 F: drivers/staging/ncpfs/

Commit that introduced this:

commit 1bb8155080c652c4853e6228f8f0d262b3049699
Author: Stephen Hemminger <[email protected]>
Date: Tue Nov 14 08:37:15 2017 -0800

ncpfs: move net/ncpfs to drivers/staging/ncpfs

The Netware Core Protocol is a file system that talks to Netware clients over IPX. Since IPX has been dead for many years move the file system into staging for eventual interment.

  MAINTAINERS                                    | 2 +-
  drivers/staging/Kconfig                        | 2 ++
  drivers/staging/Makefile                       | 1 +
  {fs => drivers/staging}/ncpfs/Kconfig          | 0
  {fs => drivers/staging}/ncpfs/Makefile         | 0
  drivers/staging/ncpfs/TODO                     | 4 ++++
  {fs => drivers/staging}/ncpfs/dir.c            | 0
  {fs => drivers/staging}/ncpfs/file.c           | 0
  {fs => drivers/staging}/ncpfs/getopt.c         | 0
  {fs => drivers/staging}/ncpfs/getopt.h         | 0
  {fs => drivers/staging}/ncpfs/inode.c          | 0
  {fs => drivers/staging}/ncpfs/ioctl.c          | 0
  {fs => drivers/staging}/ncpfs/mmap.c           | 0
  {fs => drivers/staging}/ncpfs/ncp_fs.h         | 0
  {fs => drivers/staging}/ncpfs/ncp_fs_i.h       | 0
  {fs => drivers/staging}/ncpfs/ncp_fs_sb.h      | 0
  {fs => drivers/staging}/ncpfs/ncplib_kernel.c  | 0
  {fs => drivers/staging}/ncpfs/ncplib_kernel.h  | 0
  {fs => drivers/staging}/ncpfs/ncpsign_kernel.c | 0
  {fs => drivers/staging}/ncpfs/ncpsign_kernel.h | 0
  {fs => drivers/staging}/ncpfs/sock.c           | 0
  {fs => drivers/staging}/ncpfs/symlink.c        | 0
  fs/Kconfig                                     | 1 -
  fs/Makefile                                    | 1 -
  24 files changed, 8 insertions(+), 3 deletions(-)

Last commit with drivers/staging/ncpfs/

commit bd32895c750bcd2b511bf93917bf7ae723e3d0b6

Author: Greg Kroah-Hartman <[email protected]>
Date:   Fri Jun 1 20:23:10 2018 +0200

staging: ncpfs: delete it

The ncpfs code moved into the staging tree back in November 2017 and no one has complained or even noticed it was gone. Because of that, let's just delete it.

Cc Stephen Hemminger <[email protected]>
Cc David S. Miller <[email protected]>
 drivers/staging/Kconfig                |    2 -
 drivers/staging/Makefile               |    1 -
 drivers/staging/ncpfs/Kconfig          |  108 ---
 drivers/staging/ncpfs/Makefile         |   17 -
 drivers/staging/ncpfs/TODO             |    4 -
 drivers/staging/ncpfs/dir.c            | 1232 -----------------------------
 drivers/staging/ncpfs/file.c           |  263 -------
 drivers/staging/ncpfs/getopt.c         |   76 --
 drivers/staging/ncpfs/getopt.h         |   17 -
 drivers/staging/ncpfs/inode.c          | 1067 -------------------------
 drivers/staging/ncpfs/ioctl.c          |  923 ----------------------
 drivers/staging/ncpfs/mmap.c           |  125 ---
 drivers/staging/ncpfs/ncp_fs.h         |  101 ---
 drivers/staging/ncpfs/ncp_fs_i.h       |   31 -
 drivers/staging/ncpfs/ncp_fs_sb.h      |  174 -----
 drivers/staging/ncpfs/ncplib_kernel.c  | 1326 --------------------------------
 drivers/staging/ncpfs/ncplib_kernel.h  |  215 ------
 drivers/staging/ncpfs/ncpsign_kernel.c |  128 ---
 drivers/staging/ncpfs/ncpsign_kernel.h |   27 -
 drivers/staging/ncpfs/sock.c           |  855 --------------------
 drivers/staging/ncpfs/symlink.c        |  182 -----
 21 files changed, 6874 deletions(-)