Skip to contentSkip to conversation

Bad MAINTAINERS pattern in section 'PARALLEL LCD/KEYPAD PANEL DRIVER'

DISCUSSION Joe Perches 2 participants 3 messages Sep 28, 2018 – Sep 30, 2018

lore
Share & tools
lore

Joe Perches

author Acked-by Geert Uytterhoeven
#0 lore raw

Please fix this defect appropriately.

linux-next MAINTAINERS section:

11056 PARALLEL LCD/KEYPAD PANEL DRIVER
11057 M: Willy Tarreau <[email protected]>
11058 M: Ksenija Stanojevic <[email protected]>
11059 S: Odd Fixes
11060 F: Documentation/auxdisplay/lcd-panel-cgram.txt
--> 11061 F: drivers/misc/panel.c

Commit that introduced this:

commit 7683e9e529258d01ce99216ad3be21f59eff83ec
Author: Linus Torvalds <[email protected]>
Date: Sun Jul 23 16:06:21 2017 -0700

Properly alphabetize MAINTAINERS file

This adds a perl script to actually parse the MAINTAINERS file, clean up some whitespace in it, warn about errors in it, and then properly sort the end result.

My perl-fu is atrocious, so the script has basically been created by randomly putting various characters in a pile, mixing them around, and then looking it the end result does anything interesting when used as a perl script.

  MAINTAINERS                  | 3585 +++++++++++++++++++++---------------------
  scripts/parse-maintainers.pl |   77 +
  2 files changed, 1868 insertions(+), 1794 deletions(-)

Last commit with drivers/misc/panel.c

commit 51c1e9b554c996284d5d3bd44da829f41a49a21b

Author: Andy Shevchenko <[email protected]>
Date:   Tue Apr 4 20:25:21 2017 +0300

auxdisplay: Move panel.c to drivers/auxdisplay folder

It looks like panel.c belongs to auxdisplay subsystem.

Move it to drivers/auxdisplay folder.
No functional changes intended.

 drivers/auxdisplay/Kconfig           | 280 +++++++++++++++++++++++++++++++++++
 drivers/auxdisplay/Makefile          |   1 +
 drivers/{misc => auxdisplay}/panel.c |   0
 drivers/misc/Kconfig                 | 280 -----------------------------------
 drivers/misc/Makefile                |   1 -
 5 files changed, 281 insertions(+), 281 deletions(-)
#1 lore raw

Hi Joe,

Quoted 2 lines · Joe Perches

Please fix this defect appropriately.

Thanks, will send a PR.

Cheers,
Miguel

#2 lore raw
Quoted 7 lines · Miguel Ojeda
Quoted 2 lines · Joe Perches

Please fix this defect appropriately.

Thanks, will send a PR.

Done & merged by Greg.

Cheers,
Miguel