Staging: vt6656: baseband.c: fixed unnecessary paranthesis
PATCH 1/1 Staging: vt6656: baseband.c: fixed unnecessary paranthesis
From: shubhsherl <[email protected]>
Fixed a coding line issue.
Signed-off-by shubhsherl <[email protected]>
--- drivers/staging/vt6656/baseband.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6656/baseband.c +4 -4
@@ -382,8 +382,8 @@ int vnt_vt3184_init(struct vnt_private *priv)dev_dbg (&priv->usb->dev,"RF Type %d\n" , priv->rf_type); -if ((priv->rf_type ==RF_AL2230 ) || - (priv->rf_type ==RF_AL2230S )) { +if (priv->rf_type ==RF_AL2230 || + priv->rf_type ==RF_AL2230S ) { priv->bb_rx_conf = vnt_vt3184_al2230[10 ]; length =sizeof (vnt_vt3184_al2230); addr = vnt_vt3184_al2230;
@@ -454,8 +454,8 @@ int vnt_vt3184_init(struct vnt_private *priv)vnt_control_out (priv,MESSAGE_TYPE_WRITE ,0 ,MESSAGE_REQUEST_BBAGC , length_agc, array); -if ((priv->rf_type ==RF_VT3226 ) || - (priv->rf_type ==RF_VT3342A0 )) { +if (priv->rf_type ==RF_VT3226 || + priv->rf_type ==RF_VT3342A0 ) {vnt_control_out_u8 (priv,MESSAGE_REQUEST_MACREG ,MAC_REG_ITRTMSET ,0x23 );vnt_mac_reg_bits_on (priv,MAC_REG_PAPEDELAY ,0x01 );
Signature · 1 line
2.18.0
Greg KH
maintainerQuoted 5 lines · Shubham Singh
From: shubhsherl <[email protected]>
Fixed a coding line issue.
Signed-off-by shubhsherl <[email protected]>
We need a real name please.
Quoted 9 lines
--- drivers/staging/vt6656/baseband.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/vt6656/baseband.c +0
-0
drivers/staging/vt6656/baseband.c int vnt_vt3184_init(struct vnt_private *priv) · line 386
Quoted 7 lines
drivers/staging/vt6656/baseband.c +2
-2@@ -382,8 +382,8 @@ int vnt_vt3184_init(struct vnt_private *priv)dev_dbg (&priv->usb->dev,"RF Type %d\n" , priv->rf_type); -if ((priv->rf_type ==RF_AL2230 ) || - (priv->rf_type ==RF_AL2230S )) { +if (priv->rf_type ==RF_AL2230 || + priv->rf_type ==RF_AL2230S ) {
Huh? What coding style issue caused this? The original code is fine, don't you agree? This type of change just makes it harder to work with over time (hint, you have to go look up the order of operations all the time...)
thanks
greg k-h