Skip to contentSkip to conversation

staging: ks7010: Remove unnecessary null check

PATCH New Aymen Qader 1 participant 1 message Sep 30, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ks7010: Remove unnecessary null check

Remove the unnecessary socket buffer null check in hostif_data_request. There is already an appropriate null check in the calling function:

(ks_wlan_net.c) ks_wlan_start_xmit

---
 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/ks7010/ks_hostif.c +2 -2
index 0e554e3359b5..ca030d3f609f 100644
@@ -1023,8 +1023,8 @@ int hostif_data_request(struct ks_wlan_private *priv, struct sk_buff *skb)
 	    priv->wpa.mic_failure.stop) {
 		if (netif_queue_stopped(priv->net_dev))
 			netif_wake_queue(priv->net_dev);
-		if (skb)
-			dev_kfree_skb(skb);
+
+		dev_kfree_skb(skb);
 
 		return 0;
 	}
Signature · 1 line
2.17.1