Skip to contentSkip to conversation

staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

PATCH In review Rick Veens 4 participants 4 messages Sep 30, 2018 – Oct 1, 2018 Staging

lore
Share & tools
lore

Rick Veens

author
#0 lore raw

PATCH 1/1 staging: rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h

The following:
bool efuse_re_pg_sec1flag;
u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.

---
 drivers/staging/rtlwifi/wifi.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtlwifi/wifi.h +0 -4
index a45f0eb..9cb6c79 100644
@@ -1840,10 +1840,6 @@ struct rtl_efuse {
 	u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
 	u16 efuse_usedbytes;
 	u8 efuse_usedpercentage;
-#ifdef EFUSE_REPG_WORKAROUND
-	bool efuse_re_pg_sec1flag;
-	u8 efuse_re_pg_data[8];
-#endif
 
 	u8 autoload_failflag;
 	u8 autoload_status;
Signature · 1 line
2.1.4
#1 lore raw
Quoted 8 lines · Rick Veens

The following:
bool efuse_re_pg_sec1flag;
u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.

---
 drivers/staging/rtlwifi/wifi.h | 4 ----

Presumably the equivalent uses in
drivers/net/wireless/realtek/rtlwifi/wifi.h
should be removed as well.

drivers/staging/rtlwifi/wifi.h

Quoted 1 line
drivers/staging/rtlwifi/wifi.h +0 -0

[]

Quoted 11 lines
drivers/staging/rtlwifi/wifi.h +0 -4
@@ -1840,10 +1840,6 @@ struct rtl_efuse {
 	u8 efuse_map[2][EFUSE_MAX_LOGICAL_SIZE];
 	u16 efuse_usedbytes;
 	u8 efuse_usedpercentage;
-#ifdef EFUSE_REPG_WORKAROUND
-	bool efuse_re_pg_sec1flag;
-	u8 efuse_re_pg_data[8];
-#endif
 
 	u8 autoload_failflag;
 	u8 autoload_status;
#2 lore raw
Quoted 6 lines · Joe Perches
Quoted 5 lines · Rick Veens

The following:
bool efuse_re_pg_sec1flag;
u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.

Quoted 7 lines
Quoted 3 lines
---
 drivers/staging/rtlwifi/wifi.h | 4 ----

Presumably the equivalent uses in
drivers/net/wireless/realtek/rtlwifi/wifi.h
should be removed as well.

But if it's needed, just do it in separate patch as the patches go via different trees.

Signature · 1 line
Kalle Valo
#3 lore raw
Quoted 12 lines · Kalle Valo
Quoted 10 lines · Joe Perches
Quoted 8 lines · Rick Veens

The following:
  bool efuse_re_pg_sec1flag;
  u8 efuse_re_pg_data[8];
are not referenced anywhere in the rtlwifi code.

---
  drivers/staging/rtlwifi/wifi.h | 4 ----

Quoted 7 lines
Quoted 3 lines

Presumably the equivalent uses in drivers/net/wireless/realtek/rtlwifi/wifi.h should be removed as well.

But if it's needed, just do it in separate patch as the patches go via different trees.

I can send this patch.

--
PK