Skip to contentSkip to conversation

ipw2x00: clean up clang warning on extraneous parentheses

PATCH In review Colin King 3 participants 3 messages Sep 30, 2018 – Oct 1, 2018

Subsystems (4)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 ipw2x00: clean up clang warning on extraneous parentheses

From: Colin Ian King <[email protected]>

There are extraneous parantheses that are causing clang to produce a warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

---
 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/ipw2x00/ipw2200.c +1 -1
index 9644e7b93645..bbdca13c5a9f 100644
@@ -5652,7 +5652,7 @@ static void ipw_merge_adhoc_network(struct work_struct *work)
 		}
 
 		mutex_lock(&priv->mutex);
-		if ((priv->ieee->iw_mode = IW_MODE_ADHOC)) {
+		if (priv->ieee->iw_mode = IW_MODE_ADHOC) {
 			IPW_DEBUG_MERGE("remove network %*pE\n",
 					priv->essid_len, priv->essid);
 			ipw_remove_current_network(priv);
Signature · 1 line
2.17.1
#1 lore raw

Hello!

Quoted 3 lines · Colin King

From: Colin Ian King <[email protected]>

There are extraneous parantheses that are causing clang to produce a

Parentheses.

Quoted 6 lines

warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

[...]

MBR, Sergei

#2 lore raw
In reply to Colin King
Quoted 9 lines · Colin King

From: Colin Ian King <[email protected]>

There are extraneous parantheses that are causing clang to produce a warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

I applied an identical patch few minutes ago:

c15ace868dd1 ipw2x00: Remove unnecessary parentheses

Patch set to Rejected.

Signature · 3 lines
https://patchwork.kernel.org/patch/10621549/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches